From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, bleung@chromium.org, sre@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
dlaurie@chromium.org, lamzin@google.com, bartfab@google.com,
derat@google.com, dtor@google.com, sjg@chromium.org,
jchwong@chromium.org, Nick Crews <ncrews@chromium.org>
Subject: [PATCH] power_supply: platform/chrome: wilco_ec: fix ptr_ret.cocci warnings
Date: Sat, 20 Apr 2019 12:30:16 +0800 [thread overview]
Message-ID: <20190420043016.GA4464@lkp-kbuild13> (raw)
In-Reply-To: <20190418233838.149545-1-ncrews@chromium.org>
From: kbuild test robot <lkp@intel.com>
drivers/power/supply/wilco-charger.c:173:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Fixes: 2600e89ec94e ("power_supply: platform/chrome: wilco_ec: Add charging config driver")
CC: Nick Crews <ncrews@chromium.org>
Signed-off-by: kbuild test robot <lkp@intel.com>
---
url: https://github.com/0day-ci/linux/commits/Nick-Crews/power_supply-platform-chrome-wilco_ec-Add-charging-config-driver/20190420-041913
wilco-charger.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/power/supply/wilco-charger.c
+++ b/drivers/power/supply/wilco-charger.c
@@ -170,10 +170,7 @@ static int wilco_charge_probe(struct pla
psy_cfg.drv_data = ec;
psy = devm_power_supply_register(&pdev->dev, &wilco_ps_desc, &psy_cfg);
- if (IS_ERR(psy))
- return PTR_ERR(psy);
-
- return 0;
+ return PTR_ERR_OR_ZERO(psy);
}
static struct platform_driver wilco_charge_driver = {
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Nick Crews <ncrews@chromium.org>
Cc: kbuild-all@01.org, bleung@chromium.org, sre@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
dlaurie@chromium.org, lamzin@google.com, bartfab@google.com,
derat@google.com, dtor@google.com, sjg@chromium.org,
jchwong@chromium.org, Nick Crews <ncrews@chromium.org>
Subject: [PATCH] power_supply: platform/chrome: wilco_ec: fix ptr_ret.cocci warnings
Date: Sat, 20 Apr 2019 12:30:16 +0800 [thread overview]
Message-ID: <20190420043016.GA4464@lkp-kbuild13> (raw)
Message-ID: <20190420043016.bUX9JgXjAC2LrM-gsPHVYr5GK1uj63IbEAW0Y35FY4c@z> (raw)
In-Reply-To: <20190418233838.149545-1-ncrews@chromium.org>
From: kbuild test robot <lkp@intel.com>
drivers/power/supply/wilco-charger.c:173:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Fixes: 2600e89ec94e ("power_supply: platform/chrome: wilco_ec: Add charging config driver")
CC: Nick Crews <ncrews@chromium.org>
Signed-off-by: kbuild test robot <lkp@intel.com>
---
url: https://github.com/0day-ci/linux/commits/Nick-Crews/power_supply-platform-chrome-wilco_ec-Add-charging-config-driver/20190420-041913
wilco-charger.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/power/supply/wilco-charger.c
+++ b/drivers/power/supply/wilco-charger.c
@@ -170,10 +170,7 @@ static int wilco_charge_probe(struct pla
psy_cfg.drv_data = ec;
psy = devm_power_supply_register(&pdev->dev, &wilco_ps_desc, &psy_cfg);
- if (IS_ERR(psy))
- return PTR_ERR(psy);
-
- return 0;
+ return PTR_ERR_OR_ZERO(psy);
}
static struct platform_driver wilco_charge_driver = {
next prev parent reply other threads:[~2019-04-20 4:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <--to=enric.balletbo@collabora.com>
2019-04-18 23:38 ` [PATCH v5] power_supply: platform/chrome: wilco_ec: Add charging config driver Nick Crews
2019-04-18 23:38 ` Nick Crews
2019-04-20 4:30 ` kbuild test robot [this message]
2019-04-20 4:30 ` [PATCH] power_supply: platform/chrome: wilco_ec: fix ptr_ret.cocci warnings kbuild test robot
2019-04-20 9:37 ` [PATCH v5] power_supply: platform/chrome: wilco_ec: Add charging config driver kbuild test robot
2019-04-20 9:37 ` kbuild test robot
2019-04-12 0:20 [PATCH v3 2/2] " Nick Crews
2019-04-12 15:52 ` [PATCH] power_supply: platform/chrome: wilco_ec: fix ptr_ret.cocci warnings kbuild test robot
2019-04-12 15:52 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190420043016.GA4464@lkp-kbuild13 \
--to=lkp@intel.com \
--cc=bartfab@google.com \
--cc=bleung@chromium.org \
--cc=derat@google.com \
--cc=dlaurie@chromium.org \
--cc=dtor@google.com \
--cc=jchwong@chromium.org \
--cc=kbuild-all@01.org \
--cc=lamzin@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ncrews@chromium.org \
--cc=sjg@chromium.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox