Re: [PATCH] x86/cpu: Add Elkhart Lake to Intel family

[Peter Zijlstra <peterz@infradead.org>]

On Thu, Aug 08, 2019 at 05:58:35PM +0530, Bhardwaj, Rajneesh wrote:
> Hello Peter,
> 
> Thanks for the review.
> 
> On 08-Aug-19 4:12 PM, Peter Zijlstra wrote:
> > On Thu, Aug 08, 2019 at 03:40:45PM +0530, Rajneesh Bhardwaj wrote:
> > > Elkhart Lake is Atom based SoC that uses model number 0x96. CPUID details
> > > will be documented in a future version of Intel Software Development
> > > Manual.
> > > 
> > > Cc: bp@suse.de
> > > Cc: Borislav Petkov <bp@alien8.de>
> > > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > > Cc: Kan Liang <kan.liang@linux.intel.com>
> > > Cc: Peter Zijlstra <peterz@infradead.org>
> > > Cc: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
> > > Cc: Len Brown <lenb@kernel.org>
> > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > Cc: x86-ml <x86@kernel.org>
> > > Cc: Linux PM <linux-pm@vger.kernel.org>
> > > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
> > > ---
> > >   arch/x86/include/asm/intel-family.h | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h
> > > index 0278aa66ef62..06e94ae65f28 100644
> > > --- a/arch/x86/include/asm/intel-family.h
> > > +++ b/arch/x86/include/asm/intel-family.h
> > > @@ -79,6 +79,7 @@
> > >   #define INTEL_FAM6_ATOM_GOLDMONT_PLUS	0x7A /* Gemini Lake */
> > >   #define INTEL_FAM6_ATOM_TREMONT_X	0x86 /* Jacobsville */
> > > +#define INTEL_FAM6_ATOM_ELKHART_LAKE	0x96 /*Elkhart Lake */
> > Almost, please try again.
> 
> Did you mean "It should be after Gemini Lake"? And / Or a Space inside
> comment before 'E' ?

The comment :-)