Re: [PATCH] x86/cpu: Add Elkhart Lake to Intel family

[Borislav Petkov <bp@alien8.de>]

On Thu, Aug 08, 2019 at 09:54:53AM -0700, Dave Hansen wrote:
> On 8/8/19 9:38 AM, Borislav Petkov wrote:
> > On Thu, Aug 08, 2019 at 09:30:49AM -0700, Dave Hansen wrote:
> >> Could someone also add some "how to add an entry to this file" in the
> >> top of that file?  We seem to have the same, tortuous conversations
> >> about one-line patches each time.
> > There is some doc at the top:
> 
> HOWTO Build an INTEL_FAM6_ definition:
> 
> 1. Start with INTEL_FAM6_
> 2. If not Core-family, add a note about it, like "ATOM".  There are only
>    two options for this (Xeon Phi and Atom).  It is exceedingly unlikely
>    that you are adding a cpu which needs a new option here.
> 3. Add the processor microarchitecture, not the platform name
> 4. Add a short differentiator if necessary.  Add an _X to differentiate
>    Server from Client.
> 5. Add an optional comment with the platform name(s)
> 
> It should end up looking like this:
> 
> INTEL_FAM6_<ATOM?>_<MICROARCH>_<SHORT...> /* Platform Name */

LGTM. I'd take it in a patch form. :)

Btw, according to this scheme, this new model should be

INTEL_FAM6_ATOM_TREMONT

yes?

Even though the model number is higher than the Jacobsville, i.e., the
server one?

Or

INTEL_FAM6_ATOM_TREMONT_EHL

?

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.