From: Mike Tipton <quic_mdtipton@quicinc.com>
To: <djakov@kernel.org>, <gregkh@linuxfoundation.org>, <rafael@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<quic_okukatla@quicinc.com>, <quic_viveka@quicinc.com>,
Mike Tipton <quic_mdtipton@quicinc.com>
Subject: [PATCH 1/3] debugfs: Add write support to debugfs_create_str()
Date: Mon, 24 Jul 2023 18:28:57 -0700 [thread overview]
Message-ID: <20230725012859.18474-2-quic_mdtipton@quicinc.com> (raw)
In-Reply-To: <20230725012859.18474-1-quic_mdtipton@quicinc.com>
Implementation taken from original patch series that added
debugfs_create_str() [0]. Write support was present in the initial patch
revisions, but was later removed due to lack of users. We have a user
now, so reintroduce it.
[0] https://lore.kernel.org/all/YF3Hv5zXb%2F6lauzs@hirez.programming.kicks-ass.net/
Signed-off-by: Mike Tipton <quic_mdtipton@quicinc.com>
---
fs/debugfs/file.c | 48 +++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 46 insertions(+), 2 deletions(-)
diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
index b7711888dd17..87b3753aa4b1 100644
--- a/fs/debugfs/file.c
+++ b/fs/debugfs/file.c
@@ -904,8 +904,52 @@ EXPORT_SYMBOL_GPL(debugfs_create_str);
static ssize_t debugfs_write_file_str(struct file *file, const char __user *user_buf,
size_t count, loff_t *ppos)
{
- /* This is really only for read-only strings */
- return -EINVAL;
+ struct dentry *dentry = F_DENTRY(file);
+ char *old, *new = NULL;
+ int pos = *ppos;
+ int r;
+
+ r = debugfs_file_get(dentry);
+ if (unlikely(r))
+ return r;
+
+ old = *(char **)file->private_data;
+
+ /* only allow strict concatenation */
+ r = -EINVAL;
+ if (pos && pos != strlen(old))
+ goto error;
+
+ r = -E2BIG;
+ if (pos + count + 1 > PAGE_SIZE)
+ goto error;
+
+ r = -ENOMEM;
+ new = kmalloc(pos + count + 1, GFP_KERNEL);
+ if (!new)
+ goto error;
+
+ if (pos)
+ memcpy(new, old, pos);
+
+ r = -EFAULT;
+ if (copy_from_user(new + pos, user_buf, count))
+ goto error;
+
+ new[pos + count] = '\0';
+ strim(new);
+
+ rcu_assign_pointer(*(char **)file->private_data, new);
+ synchronize_rcu();
+ kfree(old);
+
+ debugfs_file_put(dentry);
+ return count;
+
+error:
+ kfree(new);
+ debugfs_file_put(dentry);
+ return r;
}
static const struct file_operations fops_str = {
--
2.17.1
next prev parent reply other threads:[~2023-07-25 1:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 1:28 [PATCH 0/3] Add interconnect debugfs client Mike Tipton
2023-07-25 1:28 ` Mike Tipton [this message]
2023-07-25 1:28 ` [PATCH 2/3] interconnect: Reintroduce icc_get() Mike Tipton
2023-07-25 5:48 ` Pavan Kondeti
2023-07-26 1:24 ` Mike Tipton
2023-07-25 8:07 ` kernel test robot
2023-07-25 8:49 ` kernel test robot
2023-07-25 1:28 ` [PATCH 3/3] interconnect: Add debugfs test client Mike Tipton
2023-07-25 5:46 ` Pavan Kondeti
2023-07-25 15:59 ` Mike Tipton
2023-07-25 5:30 ` [PATCH 0/3] Add interconnect debugfs client Pavan Kondeti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725012859.18474-2-quic_mdtipton@quicinc.com \
--to=quic_mdtipton@quicinc.com \
--cc=djakov@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_okukatla@quicinc.com \
--cc=quic_viveka@quicinc.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox