From: Pavan Kondeti <quic_pkondeti@quicinc.com>
To: Mike Tipton <quic_mdtipton@quicinc.com>
Cc: <djakov@kernel.org>, <gregkh@linuxfoundation.org>,
<rafael@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <quic_okukatla@quicinc.com>,
<quic_viveka@quicinc.com>
Subject: Re: [PATCH 0/3] Add interconnect debugfs client
Date: Tue, 25 Jul 2023 11:00:07 +0530 [thread overview]
Message-ID: <b96376a1-4d53-4288-9380-caf9e83817cb@quicinc.com> (raw)
In-Reply-To: <20230725012859.18474-1-quic_mdtipton@quicinc.com>
On Mon, Jul 24, 2023 at 06:28:56PM -0700, Mike Tipton wrote:
> This series introduces interconnect debugfs files that support voting
> for any path the framework supports.
>
> We've historically relied on an out-of-tree module for this, which used
> the old icc_get() that was recently removed in [0]. The old icc_get()
> took integer endpoint IDs, which made identifying paths in our old
> implementation non-intuitive. The logical node names typically don't
> change much chip-to-chip, but the raw integer IDs do. Take this
> opportunity to introduce an icc_get() that uses string names instead,
> which allows for a more intuitive and generic debugfs interface.
>
> We rely on this support for debug, test, and verification. Hopefully
> it'll be useful for other vendors as well.
Thanks Mike for working on this series. The downstream driver has been
helpful in quickly pushing NOCs to max during throughput issues
debugging. I have tested this series on v6.4 + revert mentioned here on
SM8550 MTP and it works as advertised.
Thanks,
Pavan
prev parent reply other threads:[~2023-07-25 5:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 1:28 [PATCH 0/3] Add interconnect debugfs client Mike Tipton
2023-07-25 1:28 ` [PATCH 1/3] debugfs: Add write support to debugfs_create_str() Mike Tipton
2023-07-25 1:28 ` [PATCH 2/3] interconnect: Reintroduce icc_get() Mike Tipton
2023-07-25 5:48 ` Pavan Kondeti
2023-07-26 1:24 ` Mike Tipton
2023-07-25 8:07 ` kernel test robot
2023-07-25 8:49 ` kernel test robot
2023-07-25 1:28 ` [PATCH 3/3] interconnect: Add debugfs test client Mike Tipton
2023-07-25 5:46 ` Pavan Kondeti
2023-07-25 15:59 ` Mike Tipton
2023-07-25 5:30 ` Pavan Kondeti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b96376a1-4d53-4288-9380-caf9e83817cb@quicinc.com \
--to=quic_pkondeti@quicinc.com \
--cc=djakov@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_okukatla@quicinc.com \
--cc=quic_viveka@quicinc.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox