From: Mike Tipton <quic_mdtipton@quicinc.com>
To: Pavan Kondeti <quic_pkondeti@quicinc.com>
Cc: <djakov@kernel.org>, <gregkh@linuxfoundation.org>,
<rafael@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <quic_okukatla@quicinc.com>,
<quic_viveka@quicinc.com>
Subject: Re: [PATCH 2/3] interconnect: Reintroduce icc_get()
Date: Tue, 25 Jul 2023 18:24:30 -0700 [thread overview]
Message-ID: <20230726012430.GA7072@hu-mdtipton-lv.qualcomm.com> (raw)
In-Reply-To: <c68630ee-9f94-40ec-adb1-a899dc22ca1b@quicinc.com>
On Tue, Jul 25, 2023 at 11:18:58AM +0530, Pavan Kondeti wrote:
> On Mon, Jul 24, 2023 at 06:28:58PM -0700, Mike Tipton wrote:
> > The original icc_get() that took integer node IDs was removed due to
> > lack of users. Reintroduce a new version that takes string node names,
> > which is needed for the debugfs client.
> >
[..]
>
> Is this API meant to be public()? As you pointed out, it was removed
> recently as there were no users. Since debugfs client is part of ICC
> frarmwork, should it be made private?
With debugfs as the only user, it could technically be made private.
Generally speaking, people should use of_icc_get() instead of this. We
have some other downstream users of icc_get(), but we'll likely push
them to switch to of_icc_get() instead. There are some potential future
use cases that would require exporting this, but none immediate.
next prev parent reply other threads:[~2023-07-26 1:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 1:28 [PATCH 0/3] Add interconnect debugfs client Mike Tipton
2023-07-25 1:28 ` [PATCH 1/3] debugfs: Add write support to debugfs_create_str() Mike Tipton
2023-07-25 1:28 ` [PATCH 2/3] interconnect: Reintroduce icc_get() Mike Tipton
2023-07-25 5:48 ` Pavan Kondeti
2023-07-26 1:24 ` Mike Tipton [this message]
2023-07-25 8:07 ` kernel test robot
2023-07-25 8:49 ` kernel test robot
2023-07-25 1:28 ` [PATCH 3/3] interconnect: Add debugfs test client Mike Tipton
2023-07-25 5:46 ` Pavan Kondeti
2023-07-25 15:59 ` Mike Tipton
2023-07-25 5:30 ` [PATCH 0/3] Add interconnect debugfs client Pavan Kondeti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726012430.GA7072@hu-mdtipton-lv.qualcomm.com \
--to=quic_mdtipton@quicinc.com \
--cc=djakov@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_okukatla@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_viveka@quicinc.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox