From: "Mario Limonciello (AMD)" <superm1@kernel.org>
To: mario.limonciello@amd.com, airlied@gmail.com,
alexander.deucher@amd.com, christian.koenig@amd.com,
dakr@kernel.org, gregkh@linuxfoundation.org, lenb@kernel.org,
pavel@kernel.org, rafael@kernel.org, simona@ffwll.ch
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Mario Limonciello <superm1@kernel.org>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-pm@vger.kernel.org
Subject: [RFC 2/3] PM: Don't pass up device_resume() -EBUSY errors
Date: Mon, 20 Oct 2025 11:50:48 -0500 [thread overview]
Message-ID: <20251020165317.3992933-3-superm1@kernel.org> (raw)
In-Reply-To: <20251020165317.3992933-1-superm1@kernel.org>
From: Mario Limonciello <mario.limonciello@amd.com>
If a device resume returns -EBUSY the device resume sequence has
been skipped. Don't show errors for this or pass it up to async
resume. If resume is run again in another stage the device should
try again.
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
---
drivers/base/power/main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index bf9c3d79c455f..f6bc7ef9a8371 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -1112,7 +1112,9 @@ static void device_resume(struct device *dev, pm_message_t state, bool async)
TRACE_RESUME(error);
- if (error) {
+ if (error == -EBUSY)
+ pm_dev_dbg(dev, state, async ? " async" : "");
+ else if (error) {
WRITE_ONCE(async_error, error);
dpm_save_failed_dev(dev_name(dev));
pm_dev_err(dev, state, async ? " async" : "", error);
--
2.43.0
next prev parent reply other threads:[~2025-10-20 16:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 16:50 [RFC 0/3] Fixups for cancelled hibernate Mario Limonciello (AMD)
2025-10-20 16:50 ` [RFC 1/3] PM: Mark device as suspended if it failed to resume Mario Limonciello (AMD)
2025-10-20 16:58 ` Muhammad Usama Anjum
2025-10-20 17:15 ` Rafael J. Wysocki
2025-10-20 16:50 ` Mario Limonciello (AMD) [this message]
2025-10-20 16:58 ` [RFC 2/3] PM: Don't pass up device_resume() -EBUSY errors Muhammad Usama Anjum
2025-10-20 17:18 ` Rafael J. Wysocki
2025-10-20 17:24 ` Mario Limonciello (AMD) (kernel.org)
2025-10-20 16:50 ` [RFC 3/3] drm/amd: Return -EBUSY for amdgpu_pmops_thaw() on success Mario Limonciello (AMD)
2025-10-20 16:59 ` Muhammad Usama Anjum
2025-10-20 17:21 ` Rafael J. Wysocki
2025-10-20 17:28 ` Mario Limonciello (AMD) (kernel.org)
2025-10-20 17:39 ` Rafael J. Wysocki
2025-10-20 18:32 ` Mario Limonciello (AMD) (kernel.org)
2025-10-20 18:50 ` Rafael J. Wysocki
2025-10-20 19:14 ` Mario Limonciello (AMD) (kernel.org)
2025-10-20 19:18 ` Rafael J. Wysocki
2025-10-20 19:34 ` Mario Limonciello (AMD) (kernel.org)
2025-10-20 19:55 ` Rafael J. Wysocki
2025-10-20 21:09 ` Mario Limonciello (AMD) (kernel.org)
2025-10-21 13:25 ` Rafael J. Wysocki
2025-10-21 14:19 ` Mario Limonciello (AMD) (kernel.org)
2025-10-21 14:12 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251020165317.3992933-3-superm1@kernel.org \
--to=superm1@kernel.org \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
--cc=simona@ffwll.ch \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox