From: Pan Chuang <panchuang@vivo.com>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Lukasz Luba" <lukasz.luba@arm.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"John Madieu" <john.madieu.xa@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org (open list:RENESAS R-CAR
THERMAL DRIVERS), linux-pm@vger.kernel.org (open list:THERMAL),
linux-kernel@vger.kernel.org (open list)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 14/18] thermal/drivers/renesas: Remove redundant dev_err()
Date: Thu, 9 Jul 2026 10:30:17 +0800 [thread overview]
Message-ID: <20260709023048.599150-15-panchuang@vivo.com> (raw)
In-Reply-To: <20260709023048.599150-1-panchuang@vivo.com>
The devm_request_threaded_irq() now automatically logs detailed error
messages on failure. This eliminates the need for driver-specific
dev_err() calls that previously printed generic messages.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/thermal/renesas/rcar_thermal.c | 4 +---
drivers/thermal/renesas/rzg3e_thermal.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/thermal/renesas/rcar_thermal.c b/drivers/thermal/renesas/rcar_thermal.c
index 6e5dcac5d47a..cf80e2655416 100644
--- a/drivers/thermal/renesas/rcar_thermal.c
+++ b/drivers/thermal/renesas/rcar_thermal.c
@@ -446,10 +446,8 @@ static int rcar_thermal_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, irq, rcar_thermal_irq,
IRQF_SHARED, dev_name(dev), common);
- if (ret) {
- dev_err(dev, "irq request failed\n");
+ if (ret)
goto error_unregister;
- }
/* update ENR bits */
if (chip->irq_per_ch)
diff --git a/drivers/thermal/renesas/rzg3e_thermal.c b/drivers/thermal/renesas/rzg3e_thermal.c
index f0e29fe633db..c44f5b8858d0 100644
--- a/drivers/thermal/renesas/rzg3e_thermal.c
+++ b/drivers/thermal/renesas/rzg3e_thermal.c
@@ -461,10 +461,8 @@ static int rzg3e_thermal_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, irq, rzg3e_thermal_irq,
rzg3e_thermal_irq_thread,
IRQF_ONESHOT, "rzg3e_thermal", priv);
- if (ret) {
- dev_err(dev, "Failed to request IRQ: %d\n", ret);
+ if (ret)
goto err_pm_put;
- }
/* Add hwmon sysfs interface */
ret = devm_thermal_add_hwmon_sysfs(dev, priv->zone);
--
2.34.1
next prev parent reply other threads:[~2026-07-09 2:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 2:30 [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-09 2:30 ` [PATCH 01/18] thermal/drivers/airoha: Remove redundant dev_err() Pan Chuang
2026-07-09 2:30 ` [PATCH 02/18] thermal/drivers/armada: " Pan Chuang
2026-07-09 2:30 ` [PATCH 03/18] thermal/drivers/db8500: " Pan Chuang
2026-07-09 2:30 ` [PATCH 04/18] thermal/drivers/hisi: " Pan Chuang
2026-07-09 2:30 ` [PATCH 05/18] thermal/drivers/imx: " Pan Chuang
2026-07-09 3:38 ` Frank Li
2026-07-09 2:30 ` [PATCH 06/18] thermal/drivers/loongson2: Remove redundant dev_err_probe() Pan Chuang
2026-07-09 2:30 ` [PATCH 07/18] thermal/drivers/max77620: Remove redundant dev_err() Pan Chuang
2026-07-09 2:30 ` [PATCH 08/18] thermal/drivers/rockchip: Remove redundant dev_err_probe() Pan Chuang
2026-07-09 2:30 ` [PATCH 09/18] thermal/drivers/brcmstb_thermal: " Pan Chuang
2026-07-09 2:30 ` [PATCH 10/18] thermal: intel: int340x: Remove redundant dev_err() Pan Chuang
2026-07-09 2:30 ` [PATCH 11/18] thermal/drivers/intel/bxt_pmic: " Pan Chuang
2026-07-09 2:30 ` [PATCH 12/18] thermal/drivers/mediatek/lvts_thermal: " Pan Chuang
2026-07-09 2:30 ` [PATCH 13/18] thermal/drivers/qcom: " Pan Chuang
2026-07-09 2:30 ` Pan Chuang [this message]
2026-07-09 10:36 ` [PATCH 14/18] thermal/drivers/renesas: " Geert Uytterhoeven
2026-07-09 2:30 ` [PATCH 15/18] thermal/drivers/exynos: " Pan Chuang
2026-07-09 2:30 ` [PATCH 16/18] thermal/drivers/st: " Pan Chuang
2026-07-09 7:33 ` Andy Shevchenko
2026-07-09 2:30 ` [PATCH 17/18] thermal/drivers/tegra: Remove redundant dev_err() and dev_err_probe() Pan Chuang
2026-07-09 2:30 ` [PATCH 18/18] thermal/drivers/imx91: Remove redundant dev_err_probe() Pan Chuang
2026-07-09 3:38 ` Frank Li
2026-07-09 7:09 ` [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure Krzysztof Kozlowski
2026-07-09 7:24 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709023048.599150-15-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=daniel.lezcano@kernel.org \
--cc=geert+renesas@glider.be \
--cc=john.madieu.xa@bp.renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=magnus.damm@gmail.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox