Linux Power Management development
 help / color / mirror / Atom feed
From: Pan Chuang <panchuang@vivo.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Pan Chuang <panchuang@vivo.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-pm@vger.kernel.org (open list:THERMAL),
	linux-kernel@vger.kernel.org (open list),
	linux-stm32@st-md-mailman.stormreply.com (moderated
	list:ARM/STM32 ARCHITECTURE),
	linux-arm-kernel@lists.infradead.org (moderated list:ARM/STM32
	ARCHITECTURE)
Subject: [PATCH 16/18] thermal/drivers/st: Remove redundant dev_err()
Date: Thu,  9 Jul 2026 10:30:19 +0800	[thread overview]
Message-ID: <20260709023048.599150-17-panchuang@vivo.com> (raw)
In-Reply-To: <20260709023048.599150-1-panchuang@vivo.com>

The devm_request_threaded_irq() now automatically logs detailed error
messages on failure. This eliminates the need for driver-specific
dev_err() calls that previously printed generic messages.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/thermal/st/st_thermal_memmap.c | 4 +---
 drivers/thermal/st/stm_thermal.c       | 5 +----
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/thermal/st/st_thermal_memmap.c b/drivers/thermal/st/st_thermal_memmap.c
index 8f76e50ea567..e3dbe4df80cb 100644
--- a/drivers/thermal/st/st_thermal_memmap.c
+++ b/drivers/thermal/st/st_thermal_memmap.c
@@ -101,10 +101,8 @@ static int st_mmap_register_enable_irq(struct st_thermal_sensor *sensor)
 					NULL, st_mmap_thermal_trip_handler,
 					IRQF_TRIGGER_RISING | IRQF_ONESHOT,
 					dev->driver->name, sensor);
-	if (ret) {
-		dev_err(dev, "failed to register IRQ %d\n", sensor->irq);
+	if (ret)
 		return ret;
-	}
 
 	return st_mmap_enable_irq(sensor);
 }
diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c
index 5d8170bfb382..3290da7ab607 100644
--- a/drivers/thermal/st/stm_thermal.c
+++ b/drivers/thermal/st/stm_thermal.c
@@ -390,11 +390,8 @@ static int stm_register_irq(struct stm_thermal_sensor *sensor)
 					stm_thermal_irq_handler,
 					IRQF_ONESHOT,
 					dev->driver->name, sensor);
-	if (ret) {
-		dev_err(dev, "%s: Failed to register IRQ %d\n", __func__,
-			sensor->irq);
+	if (ret)
 		return ret;
-	}
 
 	dev_dbg(dev, "%s: thermal IRQ registered", __func__);
 
-- 
2.34.1


  parent reply	other threads:[~2026-07-09  2:32 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  2:30 [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-09  2:30 ` [PATCH 01/18] thermal/drivers/airoha: Remove redundant dev_err() Pan Chuang
2026-07-09  2:30 ` [PATCH 02/18] thermal/drivers/armada: " Pan Chuang
2026-07-09  2:30 ` [PATCH 03/18] thermal/drivers/db8500: " Pan Chuang
2026-07-09  2:30 ` [PATCH 04/18] thermal/drivers/hisi: " Pan Chuang
2026-07-09  2:30 ` [PATCH 05/18] thermal/drivers/imx: " Pan Chuang
2026-07-09  3:38   ` Frank Li
2026-07-09  2:30 ` [PATCH 06/18] thermal/drivers/loongson2: Remove redundant dev_err_probe() Pan Chuang
2026-07-09  2:30 ` [PATCH 07/18] thermal/drivers/max77620: Remove redundant dev_err() Pan Chuang
2026-07-09  2:30 ` [PATCH 08/18] thermal/drivers/rockchip: Remove redundant dev_err_probe() Pan Chuang
2026-07-09  2:30 ` [PATCH 09/18] thermal/drivers/brcmstb_thermal: " Pan Chuang
2026-07-09  2:30 ` [PATCH 10/18] thermal: intel: int340x: Remove redundant dev_err() Pan Chuang
2026-07-09  2:30 ` [PATCH 11/18] thermal/drivers/intel/bxt_pmic: " Pan Chuang
2026-07-09  2:30 ` [PATCH 12/18] thermal/drivers/mediatek/lvts_thermal: " Pan Chuang
2026-07-09  2:30 ` [PATCH 13/18] thermal/drivers/qcom: " Pan Chuang
2026-07-09  2:30 ` [PATCH 14/18] thermal/drivers/renesas: " Pan Chuang
2026-07-09 10:36   ` Geert Uytterhoeven
2026-07-09  2:30 ` [PATCH 15/18] thermal/drivers/exynos: " Pan Chuang
2026-07-09  2:30 ` Pan Chuang [this message]
2026-07-09  7:33   ` [PATCH 16/18] thermal/drivers/st: " Andy Shevchenko
2026-07-09  2:30 ` [PATCH 17/18] thermal/drivers/tegra: Remove redundant dev_err() and dev_err_probe() Pan Chuang
2026-07-09  2:30 ` [PATCH 18/18] thermal/drivers/imx91: Remove redundant dev_err_probe() Pan Chuang
2026-07-09  3:38   ` Frank Li
2026-07-09  7:09 ` [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure Krzysztof Kozlowski
2026-07-09  7:24   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260709023048.599150-17-panchuang@vivo.com \
    --to=panchuang@vivo.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=daniel.lezcano@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=lukasz.luba@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox