From: Frank Li <Frank.li@oss.nxp.com>
To: Pan Chuang <panchuang@vivo.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<imx@lists.linux.dev>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/18] thermal/drivers/imx: Remove redundant dev_err()
Date: Wed, 8 Jul 2026 22:38:03 -0500 [thread overview]
Message-ID: <ak8Xm0taDauxMsIZ@SMW015318> (raw)
In-Reply-To: <20260709023048.599150-6-panchuang@vivo.com>
On Thu, Jul 09, 2026 at 10:30:08AM +0800, Pan Chuang wrote:
>
> The devm_request_threaded_irq() now automatically logs detailed error
> messages on failure. This eliminates the need for driver-specific
> dev_err() calls that previously printed generic messages.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/thermal/imx_thermal.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
> index 5aaacbc53478..416d89c6287a 100644
> --- a/drivers/thermal/imx_thermal.c
> +++ b/drivers/thermal/imx_thermal.c
> @@ -732,10 +732,8 @@ static int imx_thermal_probe(struct platform_device *pdev)
> ret = devm_request_threaded_irq(dev, data->irq,
> imx_thermal_alarm_irq, imx_thermal_alarm_irq_thread,
> 0, "imx_thermal", data);
> - if (ret < 0) {
> - dev_err(dev, "failed to request alarm irq: %d\n", ret);
> + if (ret < 0)
> goto thermal_zone_unregister;
> - }
>
> pm_runtime_put(data->dev);
>
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2026-07-09 3:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 2:30 [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-09 2:30 ` [PATCH 01/18] thermal/drivers/airoha: Remove redundant dev_err() Pan Chuang
2026-07-09 2:30 ` [PATCH 02/18] thermal/drivers/armada: " Pan Chuang
2026-07-09 2:30 ` [PATCH 03/18] thermal/drivers/db8500: " Pan Chuang
2026-07-09 2:30 ` [PATCH 04/18] thermal/drivers/hisi: " Pan Chuang
2026-07-09 2:30 ` [PATCH 05/18] thermal/drivers/imx: " Pan Chuang
2026-07-09 3:38 ` Frank Li [this message]
2026-07-09 2:30 ` [PATCH 06/18] thermal/drivers/loongson2: Remove redundant dev_err_probe() Pan Chuang
2026-07-09 2:30 ` [PATCH 07/18] thermal/drivers/max77620: Remove redundant dev_err() Pan Chuang
2026-07-09 2:30 ` [PATCH 08/18] thermal/drivers/rockchip: Remove redundant dev_err_probe() Pan Chuang
2026-07-09 2:30 ` [PATCH 09/18] thermal/drivers/brcmstb_thermal: " Pan Chuang
2026-07-09 2:30 ` [PATCH 10/18] thermal: intel: int340x: Remove redundant dev_err() Pan Chuang
2026-07-09 2:30 ` [PATCH 11/18] thermal/drivers/intel/bxt_pmic: " Pan Chuang
2026-07-09 2:30 ` [PATCH 12/18] thermal/drivers/mediatek/lvts_thermal: " Pan Chuang
2026-07-09 2:30 ` [PATCH 13/18] thermal/drivers/qcom: " Pan Chuang
2026-07-09 2:30 ` [PATCH 14/18] thermal/drivers/renesas: " Pan Chuang
2026-07-09 10:36 ` Geert Uytterhoeven
2026-07-09 2:30 ` [PATCH 15/18] thermal/drivers/exynos: " Pan Chuang
2026-07-09 2:30 ` [PATCH 16/18] thermal/drivers/st: " Pan Chuang
2026-07-09 7:33 ` Andy Shevchenko
2026-07-09 2:30 ` [PATCH 17/18] thermal/drivers/tegra: Remove redundant dev_err() and dev_err_probe() Pan Chuang
2026-07-09 2:30 ` [PATCH 18/18] thermal/drivers/imx91: Remove redundant dev_err_probe() Pan Chuang
2026-07-09 3:38 ` Frank Li
2026-07-09 7:09 ` [PATCH 00/18] thermal/drivers: Remove redundant error messages on IRQ request failure Krzysztof Kozlowski
2026-07-09 7:24 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak8Xm0taDauxMsIZ@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=daniel.lezcano@kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=panchuang@vivo.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox