From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Linux PM <linux-pm@vger.kernel.org>,
Christian Loehle <christian.loehle@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Reka Norman <rekanorman@chromium.org>
Subject: [PATCH v1 3/4] cpuidle: governors: teo: Use s64 consistently in teo_update()
Date: Wed, 12 Nov 2025 17:24:40 +0100 [thread overview]
Message-ID: <3026616.e9J7NaK4W3@rafael.j.wysocki> (raw)
In-Reply-To: <4701737.LvFx2qVVIh@rafael.j.wysocki>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Two local variables in teo_update() are defined as u64, but their
values are then compared with s64 values, so it is more consistent
to use s64 as their data type.
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/cpuidle/governors/teo.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--- a/drivers/cpuidle/governors/teo.c
+++ b/drivers/cpuidle/governors/teo.c
@@ -157,8 +157,7 @@ static void teo_update(struct cpuidle_dr
{
struct teo_cpu *cpu_data = per_cpu_ptr(&teo_cpus, dev->cpu);
int i, idx_timer = 0, idx_duration = 0;
- s64 target_residency_ns;
- u64 measured_ns;
+ s64 target_residency_ns, measured_ns;
cpu_data->short_idles -= cpu_data->short_idles >> DECAY_SHIFT;
@@ -167,9 +166,9 @@ static void teo_update(struct cpuidle_dr
* If one of the safety nets has triggered, assume that this
* might have been a long sleep.
*/
- measured_ns = U64_MAX;
+ measured_ns = S64_MAX;
} else {
- u64 lat_ns = drv->states[dev->last_state_idx].exit_latency_ns;
+ s64 lat_ns = drv->states[dev->last_state_idx].exit_latency_ns;
measured_ns = dev->last_residency_ns;
/*
next prev parent reply other threads:[~2025-11-12 16:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 16:21 [PATCH v1 0/4] cpuidle: governors: teo: Assorted improvements Rafael J. Wysocki
2025-11-12 16:22 ` [PATCH v1 1/4] cpuidle: governors: teo: Drop incorrect target residency check Rafael J. Wysocki
2025-11-13 11:32 ` Christian Loehle
2025-11-13 11:41 ` Rafael J. Wysocki
2025-11-13 11:47 ` Rafael J. Wysocki
2025-11-13 13:26 ` Rafael J. Wysocki
2025-11-13 13:24 ` [PATCH v2 1/4] cpuidle: governors: teo: Drop misguided " Rafael J. Wysocki
2025-11-14 9:16 ` Christian Loehle
2025-11-12 16:23 ` [PATCH v1 2/4] cpuidle: governors: teo: Drop redundant function parameter Rafael J. Wysocki
2025-11-13 11:46 ` Christian Loehle
2025-11-12 16:24 ` Rafael J. Wysocki [this message]
2025-11-13 11:48 ` [PATCH v1 3/4] cpuidle: governors: teo: Use s64 consistently in teo_update() Christian Loehle
2025-11-12 16:25 ` [PATCH v1 4/4] cpuidle: governors: teo: Decay metrics below DECAY_SHIFT threshold Rafael J. Wysocki
2025-11-12 17:29 ` Christian Loehle
2025-11-12 17:51 ` Rafael J. Wysocki
2025-11-12 18:00 ` Christian Loehle
2025-11-12 18:03 ` [PATCH v2 " Rafael J. Wysocki
2025-11-13 11:49 ` Christian Loehle
2025-11-13 15:21 ` [PATCH v1 0/4] cpuidle: governors: teo: Assorted improvements Christian Loehle
2025-11-13 15:25 ` Rafael J. Wysocki
2025-11-19 22:52 ` Doug Smythies
2025-11-20 11:02 ` Rafael J. Wysocki
2025-11-20 13:35 ` Christian Loehle
2025-11-20 13:38 ` Rafael J. Wysocki
2025-11-20 13:57 ` Rafael J. Wysocki
2025-11-20 15:21 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3026616.e9J7NaK4W3@rafael.j.wysocki \
--to=rafael@kernel.org \
--cc=christian.loehle@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rekanorman@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox