* [PATCH V2] cpufreq: make cpufreq_boost_enabled return bool
@ 2024-06-27 6:01 Dhruva Gole
2024-06-27 18:57 ` Mario Limonciello
0 siblings, 1 reply; 3+ messages in thread
From: Dhruva Gole @ 2024-06-27 6:01 UTC (permalink / raw)
To: Viresh Kumar, Rafael J . Wysocki
Cc: linux-pm, linux-kernel, Mario Limonciello, Dhruva Gole
Since this function is supposed to return boost_enabled which is anyway
a bool type make sure that it's return value is also marked as bool.
This helps maintain better consistency in data types being used.
Signed-off-by: Dhruva Gole <d-gole@ti.com>
---
Changelog:
"return false" instead of 0 as per Mario's suggestion.
Link to previous patch:
https://lore.kernel.org/linux-pm/20240626084354.1762483-1-d-gole@ti.com/
---
drivers/cpufreq/cpufreq.c | 2 +-
include/linux/cpufreq.h | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 82c500389a40..709e7b1f9826 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -2873,7 +2873,7 @@ int cpufreq_enable_boost_support(void)
}
EXPORT_SYMBOL_GPL(cpufreq_enable_boost_support);
-int cpufreq_boost_enabled(void)
+bool cpufreq_boost_enabled(void)
{
return cpufreq_driver->boost_enabled;
}
diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
index 20f7e98ee8af..6f57de7de433 100644
--- a/include/linux/cpufreq.h
+++ b/include/linux/cpufreq.h
@@ -785,7 +785,7 @@ ssize_t cpufreq_show_cpus(const struct cpumask *mask, char *buf);
#ifdef CONFIG_CPU_FREQ
int cpufreq_boost_trigger_state(int state);
-int cpufreq_boost_enabled(void);
+bool cpufreq_boost_enabled(void);
int cpufreq_enable_boost_support(void);
bool policy_has_boost_freq(struct cpufreq_policy *policy);
@@ -1164,9 +1164,9 @@ static inline int cpufreq_boost_trigger_state(int state)
{
return 0;
}
-static inline int cpufreq_boost_enabled(void)
+static inline bool cpufreq_boost_enabled(void)
{
- return 0;
+ return false;
}
static inline int cpufreq_enable_boost_support(void)
base-commit: df9574a57d02b265322e77fb8628d4d33641dda9
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH V2] cpufreq: make cpufreq_boost_enabled return bool
2024-06-27 6:01 [PATCH V2] cpufreq: make cpufreq_boost_enabled return bool Dhruva Gole
@ 2024-06-27 18:57 ` Mario Limonciello
2024-06-28 18:59 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Mario Limonciello @ 2024-06-27 18:57 UTC (permalink / raw)
To: Dhruva Gole, Viresh Kumar, Rafael J . Wysocki; +Cc: linux-pm, linux-kernel
On 6/27/2024 01:01, Dhruva Gole wrote:
> Since this function is supposed to return boost_enabled which is anyway
> a bool type make sure that it's return value is also marked as bool.
> This helps maintain better consistency in data types being used.
>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>
> Changelog:
> "return false" instead of 0 as per Mario's suggestion.
>
> Link to previous patch:
> https://lore.kernel.org/linux-pm/20240626084354.1762483-1-d-gole@ti.com/
>
> ---
>
> drivers/cpufreq/cpufreq.c | 2 +-
> include/linux/cpufreq.h | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 82c500389a40..709e7b1f9826 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -2873,7 +2873,7 @@ int cpufreq_enable_boost_support(void)
> }
> EXPORT_SYMBOL_GPL(cpufreq_enable_boost_support);
>
> -int cpufreq_boost_enabled(void)
> +bool cpufreq_boost_enabled(void)
> {
> return cpufreq_driver->boost_enabled;
> }
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index 20f7e98ee8af..6f57de7de433 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -785,7 +785,7 @@ ssize_t cpufreq_show_cpus(const struct cpumask *mask, char *buf);
>
> #ifdef CONFIG_CPU_FREQ
> int cpufreq_boost_trigger_state(int state);
> -int cpufreq_boost_enabled(void);
> +bool cpufreq_boost_enabled(void);
> int cpufreq_enable_boost_support(void);
> bool policy_has_boost_freq(struct cpufreq_policy *policy);
>
> @@ -1164,9 +1164,9 @@ static inline int cpufreq_boost_trigger_state(int state)
> {
> return 0;
> }
> -static inline int cpufreq_boost_enabled(void)
> +static inline bool cpufreq_boost_enabled(void)
> {
> - return 0;
> + return false;
> }
>
> static inline int cpufreq_enable_boost_support(void)
>
> base-commit: df9574a57d02b265322e77fb8628d4d33641dda9
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V2] cpufreq: make cpufreq_boost_enabled return bool
2024-06-27 18:57 ` Mario Limonciello
@ 2024-06-28 18:59 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2024-06-28 18:59 UTC (permalink / raw)
To: Mario Limonciello, Dhruva Gole
Cc: Viresh Kumar, Rafael J . Wysocki, linux-pm, linux-kernel
On Thu, Jun 27, 2024 at 8:57 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> On 6/27/2024 01:01, Dhruva Gole wrote:
> > Since this function is supposed to return boost_enabled which is anyway
> > a bool type make sure that it's return value is also marked as bool.
> > This helps maintain better consistency in data types being used.
> >
> > Signed-off-by: Dhruva Gole <d-gole@ti.com>
>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Applied as 6.11 material, thanks!
> > ---
> >
> > Changelog:
> > "return false" instead of 0 as per Mario's suggestion.
> >
> > Link to previous patch:
> > https://lore.kernel.org/linux-pm/20240626084354.1762483-1-d-gole@ti.com/
> >
> > ---
> >
> > drivers/cpufreq/cpufreq.c | 2 +-
> > include/linux/cpufreq.h | 6 +++---
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index 82c500389a40..709e7b1f9826 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -2873,7 +2873,7 @@ int cpufreq_enable_boost_support(void)
> > }
> > EXPORT_SYMBOL_GPL(cpufreq_enable_boost_support);
> >
> > -int cpufreq_boost_enabled(void)
> > +bool cpufreq_boost_enabled(void)
> > {
> > return cpufreq_driver->boost_enabled;
> > }
> > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> > index 20f7e98ee8af..6f57de7de433 100644
> > --- a/include/linux/cpufreq.h
> > +++ b/include/linux/cpufreq.h
> > @@ -785,7 +785,7 @@ ssize_t cpufreq_show_cpus(const struct cpumask *mask, char *buf);
> >
> > #ifdef CONFIG_CPU_FREQ
> > int cpufreq_boost_trigger_state(int state);
> > -int cpufreq_boost_enabled(void);
> > +bool cpufreq_boost_enabled(void);
> > int cpufreq_enable_boost_support(void);
> > bool policy_has_boost_freq(struct cpufreq_policy *policy);
> >
> > @@ -1164,9 +1164,9 @@ static inline int cpufreq_boost_trigger_state(int state)
> > {
> > return 0;
> > }
> > -static inline int cpufreq_boost_enabled(void)
> > +static inline bool cpufreq_boost_enabled(void)
> > {
> > - return 0;
> > + return false;
> > }
> >
> > static inline int cpufreq_enable_boost_support(void)
> >
> > base-commit: df9574a57d02b265322e77fb8628d4d33641dda9
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-28 18:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-27 6:01 [PATCH V2] cpufreq: make cpufreq_boost_enabled return bool Dhruva Gole
2024-06-27 18:57 ` Mario Limonciello
2024-06-28 18:59 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox