From: Krzysztof Kozlowski <krzk@kernel.org>
To: Akhil P Oommen <akhilpo@oss.qualcomm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Sean Paul <sean@poorly.run>,
Konrad Dybcio <konradybcio@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: opp: adreno: Update regex of OPP entry
Date: Wed, 11 Jun 2025 13:20:57 +0200 [thread overview]
Message-ID: <492417fe-c086-4980-b108-0487bad08155@kernel.org> (raw)
In-Reply-To: <20250611-x1p-adreno-v2-1-5074907bebbd@oss.qualcomm.com>
On 11/06/2025 13:15, Akhil P Oommen wrote:
> Update regex to allow multi-worded OPP entry names.
Why would we want multi-worded? This needs to be explained here.
>
> Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml
> index a27ba7b663d456f964628a91a661b51a684de1be..bba95799919eb52d12afa42354ed909d0ef3c627 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml
> @@ -23,7 +23,7 @@ properties:
> const: operating-points-v2-adreno
>
> patternProperties:
> - '^opp-[0-9]+$':
> + '^opp(-?[0-9]+)*$':
Not correct regex. You allow "opp", "opp1" and all other unusual
variants. Commit does not explain what problem you are solving, so I
have no clue what you want here, but for sure opp1 is wrong.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-11 11:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 11:15 [PATCH v2 0/4] Support for Adreno X1-45 GPU Akhil P Oommen
2025-06-11 11:15 ` [PATCH v2 1/4] dt-bindings: opp: adreno: Update regex of OPP entry Akhil P Oommen
2025-06-11 11:20 ` Krzysztof Kozlowski [this message]
2025-06-11 12:24 ` Akhil P Oommen
2025-06-12 11:29 ` Krzysztof Kozlowski
2025-06-16 16:48 ` Akhil P Oommen
2025-06-17 8:27 ` Krzysztof Kozlowski
2025-06-11 11:15 ` [PATCH v2 2/4] arm64: defconfig: Enable X1P42100_GPUCC driver Akhil P Oommen
2025-06-11 11:25 ` Krzysztof Kozlowski
2025-06-11 12:28 ` Akhil P Oommen
2025-06-11 11:15 ` [PATCH v2 3/4] drm/msm/adreno: Add Adreno X1-45 support Akhil P Oommen
2025-06-11 11:15 ` [PATCH v2 4/4] arm64: dts: qcom: Add GPU support to X1P42100 SoC Akhil P Oommen
2025-06-11 11:22 ` Krzysztof Kozlowski
2025-06-11 12:25 ` Akhil P Oommen
2025-06-12 12:02 ` [PATCH v2 0/4] Support for Adreno X1-45 GPU Jens Glathe
2025-06-12 21:19 ` Akhil P Oommen
2025-06-14 18:42 ` Konrad Dybcio
2025-06-16 12:58 ` Akhil P Oommen
2025-06-15 20:42 ` Jens Glathe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492417fe-c086-4980-b108-0487bad08155@kernel.org \
--to=krzk@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=akhilpo@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=vireshk@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox