[PATCH v2] thermal/drivers/rcar_gen3: Document R-Car Gen4 and RZ/G2 support in driver comment

[PATCH v2] thermal/drivers/rcar_gen3: Document R-Car Gen4 and RZ/G2 support in driver comment

[Marek Vasut]

The R-Car Gen3 thermal driver supports both R-Car Gen3 and Gen4 SoCs
as well as RZ/G2. Update the driver comment. No functional change.

Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Lukasz Luba <lukasz.luba@arm.com>
Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: linux-pm@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
---
V2: Fix up the commit message, include RZ/G2
---
 drivers/thermal/renesas/rcar_gen3_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/renesas/rcar_gen3_thermal.c b/drivers/thermal/renesas/rcar_gen3_thermal.c
index 3223de238d014..a143b087a8ea7 100644
--- a/drivers/thermal/renesas/rcar_gen3_thermal.c
+++ b/drivers/thermal/renesas/rcar_gen3_thermal.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- *  R-Car Gen3 THS thermal sensor driver
+ *  R-Car Gen3/Gen4 and RZ/G2 THS thermal sensor driver
  *  Based on rcar_thermal.c and work from Hien Dang and Khiem Nguyen.
  *
  * Copyright (C) 2016 Renesas Electronics Corporation.
-- 
2.51.0

Re: [PATCH v2] thermal/drivers/rcar_gen3: Document R-Car Gen4 and RZ/G2 support in driver comment

[Niklas Söderlund]

On 2025-10-15 17:58:52 +0200, Marek Vasut wrote:
> The R-Car Gen3 thermal driver supports both R-Car Gen3 and Gen4 SoCs
> as well as RZ/G2. Update the driver comment. No functional change.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Lukasz Luba <lukasz.luba@arm.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org
> ---
> V2: Fix up the commit message, include RZ/G2
> ---
>  drivers/thermal/renesas/rcar_gen3_thermal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/renesas/rcar_gen3_thermal.c b/drivers/thermal/renesas/rcar_gen3_thermal.c
> index 3223de238d014..a143b087a8ea7 100644
> --- a/drivers/thermal/renesas/rcar_gen3_thermal.c
> +++ b/drivers/thermal/renesas/rcar_gen3_thermal.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - *  R-Car Gen3 THS thermal sensor driver
> + *  R-Car Gen3/Gen4 and RZ/G2 THS thermal sensor driver

Super nit: I would write "Gen3, Gen4 and RZ/...". Compared to v1 you 
updated the commit message not the comment here. Not a big deal all the 
information is there.

With or without this,

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

>   *  Based on rcar_thermal.c and work from Hien Dang and Khiem Nguyen.
>   *
>   * Copyright (C) 2016 Renesas Electronics Corporation.
> -- 
> 2.51.0
> 

-- 
Kind Regards,
Niklas Söderlund

Re: [PATCH v2] thermal/drivers/rcar_gen3: Document R-Car Gen4 and RZ/G2 support in driver comment

[Marek Vasut]

On 10/15/25 7:33 PM, Niklas Söderlund wrote:

Hello Niklas,

>> - *  R-Car Gen3 THS thermal sensor driver
>> + *  R-Car Gen3/Gen4 and RZ/G2 THS thermal sensor driver
> 
> Super nit: I would write "Gen3, Gen4 and RZ/...". Compared to v1 you
> updated the commit message not the comment here. Not a big deal all the
> information is there.

Like this, right ? I will include that in V3, thanks:

diff --git a/drivers/thermal/renesas/rcar_gen3_thermal.c 
b/drivers/thermal/renesas/rcar_gen3_thermal.c
index a143b087a8ea7..1f4f02e939ef8 100644
--- a/drivers/thermal/renesas/rcar_gen3_thermal.c
+++ b/drivers/thermal/renesas/rcar_gen3_thermal.c
@@ -1,6 +1,6 @@
  // SPDX-License-Identifier: GPL-2.0
  /*
- *  R-Car Gen3/Gen4 and RZ/G2 THS thermal sensor driver
+ *  R-Car Gen3, Gen4 and RZ/G2 THS thermal sensor driver
   *  Based on rcar_thermal.c and work from Hien Dang and Khiem Nguyen.
   *
   * Copyright (C) 2016 Renesas Electronics Corporation.

Re: [PATCH v2] thermal/drivers/rcar_gen3: Document R-Car Gen4 and RZ/G2 support in driver comment

[Daniel Lezcano]

Hi Marek,

On 10/15/25 20:11, Marek Vasut wrote:
> On 10/15/25 7:33 PM, Niklas Söderlund wrote:
> 
> Hello Niklas,
> 
>>> - *  R-Car Gen3 THS thermal sensor driver
>>> + *  R-Car Gen3/Gen4 and RZ/G2 THS thermal sensor driver
>>
>> Super nit: I would write "Gen3, Gen4 and RZ/...". Compared to v1 you
>> updated the commit message not the comment here. Not a big deal all the
>> information is there.
> 
> Like this, right ? I will include that in V3, thanks:

Did you send the V3 ? Not sure if I missed it or if you had no time to 
send it yet


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH v2] thermal/drivers/rcar_gen3: Document R-Car Gen4 and RZ/G2 support in driver comment

[Marek Vasut]

On 11/10/25 12:54 PM, Daniel Lezcano wrote:

Hello Daniel,

> On 10/15/25 20:11, Marek Vasut wrote:
>> On 10/15/25 7:33 PM, Niklas Söderlund wrote:
>>
>> Hello Niklas,
>>
>>>> - *  R-Car Gen3 THS thermal sensor driver
>>>> + *  R-Car Gen3/Gen4 and RZ/G2 THS thermal sensor driver
>>>
>>> Super nit: I would write "Gen3, Gen4 and RZ/...". Compared to v1 you
>>> updated the commit message not the comment here. Not a big deal all the
>>> information is there.
>>
>> Like this, right ? I will include that in V3, thanks:
> 
> Did you send the V3 ? Not sure if I missed it or if you had no time to 
> send it yet
Thank you for the reminder, I sent a V3 now.

Re: [PATCH v2] thermal/drivers/rcar_gen3: Document R-Car Gen4 and RZ/G2 support in driver comment

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]


> - *  R-Car Gen3 THS thermal sensor driver
> + *  R-Car Gen3/Gen4 and RZ/G2 THS thermal sensor driver

I am not opposed to the patch. Just want to mention that such
information gets stale all the time, so I would suggest:

+ R-Car Gen3 THS and compatible thermal sensor driver


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2] thermal/drivers/rcar_gen3: Document R-Car Gen4 and RZ/G2 support in driver comment

[Marek Vasut]

On 10/15/25 7:47 PM, Wolfram Sang wrote:
> 
>> - *  R-Car Gen3 THS thermal sensor driver
>> + *  R-Car Gen3/Gen4 and RZ/G2 THS thermal sensor driver
> 
> I am not opposed to the patch. Just want to mention that such
> information gets stale all the time, so I would suggest:
> 
> + R-Car Gen3 THS and compatible thermal sensor driver
This won't cover RZ/G2 which something else, and Gen5 seems like it will 
be also a bit different, so maybe the list is now exhaustive?

Re: [PATCH v2] thermal/drivers/rcar_gen3: Document R-Car Gen4 and RZ/G2 support in driver comment

[Geert Uytterhoeven]

Hi Marek,

My
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
on v1 is still valid

On Wed, 15 Oct 2025 at 22:13, Marek Vasut <marek.vasut@mailbox.org> wrote:
> On 10/15/25 7:47 PM, Wolfram Sang wrote:
> >> - *  R-Car Gen3 THS thermal sensor driver
> >> + *  R-Car Gen3/Gen4 and RZ/G2 THS thermal sensor driver
> >
> > I am not opposed to the patch. Just want to mention that such
> > information gets stale all the time, so I would suggest:
> >
> > + R-Car Gen3 THS and compatible thermal sensor driver
> This won't cover RZ/G2 which something else, and Gen5 seems like it will
> be also a bit different, so maybe the list is now exhaustive?

Until it gets reused in a non-R-Car SoC, a decade later...
BTW, do you know the origins of RZ/T2H RSCI?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2] thermal/drivers/rcar_gen3: Document R-Car Gen4 and RZ/G2 support in driver comment

[Wolfram Sang]

> > I am not opposed to the patch. Just want to mention that such
> > information gets stale all the time, so I would suggest:
> > 
> > + R-Car Gen3 THS and compatible thermal sensor driver
> This won't cover RZ/G2 which something else, and Gen5 seems like it will be
> also a bit different, so maybe the list is now exhaustive?

Sorry, I don't understand: If RZ/xx THS is compatible with R-Car Gen3
THS, why is this not covered?

RE: [PATCH v2] thermal/drivers/rcar_gen3: Document R-Car Gen4 and RZ/G2 support in driver comment

[Biju Das]

Hi Wolfram,

> -----Original Message-----
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Sent: 16 October 2025 09:02
> Subject: Re: [PATCH v2] thermal/drivers/rcar_gen3: Document R-Car Gen4 and RZ/G2 support in driver
> comment
> 
> 
> > > I am not opposed to the patch. Just want to mention that such
> > > information gets stale all the time, so I would suggest:
> > >
> > > + R-Car Gen3 THS and compatible thermal sensor driver
> > This won't cover RZ/G2 which something else, and Gen5 seems like it
> > will be also a bit different, so maybe the list is now exhaustive?
> 
> Sorry, I don't understand: If RZ/xx THS is compatible with R-Car Gen3 THS, why is this not covered?

RZ/G2{H,M,N,E} thermal sensors should be compatible with R-Car Gen3{H,M3W,M3N,E}
But RZ/{G2L,G2LC,G2UL,V2L} uses different compatible.

Cheers,
Biju

Re: [PATCH v2] thermal/drivers/rcar_gen3: Document R-Car Gen4 and RZ/G2 support in driver comment

[wsa+renesas]

> > > > I am not opposed to the patch. Just want to mention that such
> > > > information gets stale all the time, so I would suggest:
> > > >
> > > > + R-Car Gen3 THS and compatible thermal sensor driver
> > > This won't cover RZ/G2 which something else, and Gen5 seems like it
> > > will be also a bit different, so maybe the list is now exhaustive?
> > 
> > Sorry, I don't understand: If RZ/xx THS is compatible with R-Car Gen3 THS, why is this not covered?
> 
> RZ/G2{H,M,N,E} thermal sensors should be compatible with R-Car Gen3{H,M3W,M3N,E}
> But RZ/{G2L,G2LC,G2UL,V2L} uses different compatible.

I do understand this.

But if I say "this driver supports R-Car Gen3 THS and all THS instances
compatible with it", this includes all RZ which are, well, compatible
with it. And not those which are, well, not compatible with it?

Where is the misunderstanding? I am feeling a little awkward here...

Re: [PATCH v2] thermal/drivers/rcar_gen3: Document R-Car Gen4 and RZ/G2 support in driver comment

[Marek Vasut]

On 10/16/25 10:20 AM, wsa+renesas wrote:
> 
>>>>> I am not opposed to the patch. Just want to mention that such
>>>>> information gets stale all the time, so I would suggest:
>>>>>
>>>>> + R-Car Gen3 THS and compatible thermal sensor driver
>>>> This won't cover RZ/G2 which something else, and Gen5 seems like it
>>>> will be also a bit different, so maybe the list is now exhaustive?
>>>
>>> Sorry, I don't understand: If RZ/xx THS is compatible with R-Car Gen3 THS, why is this not covered?
>>
>> RZ/G2{H,M,N,E} thermal sensors should be compatible with R-Car Gen3{H,M3W,M3N,E}
>> But RZ/{G2L,G2LC,G2UL,V2L} uses different compatible.
> 
> I do understand this.
> 
> But if I say "this driver supports R-Car Gen3 THS and all THS instances
> compatible with it", this includes all RZ which are, well, compatible
> with it. And not those which are, well, not compatible with it?
> 
> Where is the misunderstanding? I am feeling a little awkward here...
I think the only misunderstanding is, that if I spell the list of 
supported devices fully, it is easier for the reader. Gen3 and 
compatible pushes the onus of looking up whether their SoC has THS 
compatible with Gen3 onto the reader. It seems no other entries will be 
added in the foreseeable future, so the list is currently likely 
exhaustive for a while.