* [PATCH] x86/cstate: Add Zhaoxin ACPI Cx FFH MWAIT support
@ 2022-06-22 3:29 Tony W Wang-oc
2022-06-22 13:38 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Tony W Wang-oc @ 2022-06-22 3:29 UTC (permalink / raw)
To: rafael, len.brown, pavel, tglx, mingo, bp, dave.hansen, x86, hpa,
linux-pm, linux-kernel
Cc: CobeChen, TimGuo, LindaChai, LeoLiu
Recent Zhaoxin CPUs support X86_FEATURE_MWAIT that implies the
MONITOR/MWAIT instructions can be used for ACPI Cx state. The BIOS
declares Cx state in _CST object to use FFH on Zhaoxin systems. So
let function ffh_cstate_init() support Zhaoxin too.
Signed-off-by: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
---
arch/x86/kernel/acpi/cstate.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
index 7945eae..d4185e1 100644
--- a/arch/x86/kernel/acpi/cstate.c
+++ b/arch/x86/kernel/acpi/cstate.c
@@ -213,7 +213,9 @@ static int __init ffh_cstate_init(void)
if (c->x86_vendor != X86_VENDOR_INTEL &&
c->x86_vendor != X86_VENDOR_AMD &&
- c->x86_vendor != X86_VENDOR_HYGON)
+ c->x86_vendor != X86_VENDOR_HYGON &&
+ c->x86_vendor != X86_VENDOR_CENTAUR &&
+ c->x86_vendor != X86_VENDOR_ZHAOXIN)
return -1;
cpu_cstate_entry = alloc_percpu(struct cstate_entry);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/cstate: Add Zhaoxin ACPI Cx FFH MWAIT support
2022-06-22 3:29 [PATCH] x86/cstate: Add Zhaoxin ACPI Cx FFH MWAIT support Tony W Wang-oc
@ 2022-06-22 13:38 ` Rafael J. Wysocki
2022-06-23 1:10 ` Tony W Wang-oc
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2022-06-22 13:38 UTC (permalink / raw)
To: Tony W Wang-oc
Cc: Rafael J. Wysocki, Len Brown, Pavel Machek, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, Dave Hansen,
the arch/x86 maintainers, H. Peter Anvin, Linux PM,
Linux Kernel Mailing List, CobeChen, TimGuo, LindaChai, LeoLiu,
ACPI Devel Maling List
Please CC linux-acpi@vger.kernel.org on ACPI-related changes (added now).
On Wed, Jun 22, 2022 at 5:29 AM Tony W Wang-oc <TonyWWang-oc@zhaoxin.com> wrote:
>
> Recent Zhaoxin CPUs support X86_FEATURE_MWAIT that implies the
> MONITOR/MWAIT instructions can be used for ACPI Cx state. The BIOS
> declares Cx state in _CST object to use FFH on Zhaoxin systems. So
> let function ffh_cstate_init() support Zhaoxin too.
>
> Signed-off-by: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
> ---
> arch/x86/kernel/acpi/cstate.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
> index 7945eae..d4185e1 100644
> --- a/arch/x86/kernel/acpi/cstate.c
> +++ b/arch/x86/kernel/acpi/cstate.c
> @@ -213,7 +213,9 @@ static int __init ffh_cstate_init(void)
>
> if (c->x86_vendor != X86_VENDOR_INTEL &&
> c->x86_vendor != X86_VENDOR_AMD &&
> - c->x86_vendor != X86_VENDOR_HYGON)
> + c->x86_vendor != X86_VENDOR_HYGON &&
> + c->x86_vendor != X86_VENDOR_CENTAUR &&
> + c->x86_vendor != X86_VENDOR_ZHAOXIN)
Centaur is not mentioned in the changelog and it should be.
> return -1;
>
> cpu_cstate_entry = alloc_percpu(struct cstate_entry);
> --
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/cstate: Add Zhaoxin ACPI Cx FFH MWAIT support
2022-06-22 13:38 ` Rafael J. Wysocki
@ 2022-06-23 1:10 ` Tony W Wang-oc
0 siblings, 0 replies; 3+ messages in thread
From: Tony W Wang-oc @ 2022-06-23 1:10 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Len Brown, Pavel Machek, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, Dave Hansen, the arch/x86 maintainers,
H. Peter Anvin, Linux PM, Linux Kernel Mailing List, CobeChen,
TimGuo, LindaChai, LeoLiu, ACPI Devel Maling List
On 22/6/2022 21:38, Rafael J. Wysocki wrote:
> Please CC linux-acpi@vger.kernel.org on ACPI-related changes (added now).
Ok.
>
> On Wed, Jun 22, 2022 at 5:29 AM Tony W Wang-oc <TonyWWang-oc@zhaoxin.com> wrote:
>>
>> Recent Zhaoxin CPUs support X86_FEATURE_MWAIT that implies the
>> MONITOR/MWAIT instructions can be used for ACPI Cx state. The BIOS
>> declares Cx state in _CST object to use FFH on Zhaoxin systems. So
>> let function ffh_cstate_init() support Zhaoxin too.
>>
>> Signed-off-by: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
>> ---
>> arch/x86/kernel/acpi/cstate.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
>> index 7945eae..d4185e1 100644
>> --- a/arch/x86/kernel/acpi/cstate.c
>> +++ b/arch/x86/kernel/acpi/cstate.c
>> @@ -213,7 +213,9 @@ static int __init ffh_cstate_init(void)
>>
>> if (c->x86_vendor != X86_VENDOR_INTEL &&
>> c->x86_vendor != X86_VENDOR_AMD &&
>> - c->x86_vendor != X86_VENDOR_HYGON)
>> + c->x86_vendor != X86_VENDOR_HYGON &&
>> + c->x86_vendor != X86_VENDOR_CENTAUR &&
>> + c->x86_vendor != X86_VENDOR_ZHAOXIN)
>
> Centaur is not mentioned in the changelog and it should be.
Will add Centaur in the changelog. Thanks a lot.
>
>> return -1;
>>
>> cpu_cstate_entry = alloc_percpu(struct cstate_entry);
>> --
> .
>
--
Sincerely
TonyWWang-oc
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-23 1:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-22 3:29 [PATCH] x86/cstate: Add Zhaoxin ACPI Cx FFH MWAIT support Tony W Wang-oc
2022-06-22 13:38 ` Rafael J. Wysocki
2022-06-23 1:10 ` Tony W Wang-oc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox