Linux PWM subsystem development
 help / color / mirror / Atom feed
* [PATCH] pwm: imx: Switch to SPDX identifier
@ 2018-05-20 15:40 Fabio Estevam
  2018-06-06  9:09 ` Thierry Reding
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2018-05-20 15:40 UTC (permalink / raw)
  To: thierry.reding; +Cc: linux-pwm, Fabio Estevam

From: Fabio Estevam <fabio.estevam@nxp.com>

Adopt the SPDX license identifier headers to ease license compliance
management.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 drivers/pwm/pwm-imx.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index 08cbe81..6ddd6fd 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -1,12 +1,8 @@
-/*
- * simple driver for PWM (Pulse Width Modulator) controller
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * Derived from pxa PWM driver by eric miao <eric.miao@marvell.com>
- */
+// SPDX-License-Identifier: GPL-2.0
+//
+// simple driver for PWM (Pulse Width Modulator) controller
+//
+// Derived from pxa PWM driver by eric miao <eric.miao@marvell.com>
 
 #include <linux/module.h>
 #include <linux/kernel.h>
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] pwm: imx: Switch to SPDX identifier
  2018-05-20 15:40 [PATCH] pwm: imx: Switch to SPDX identifier Fabio Estevam
@ 2018-06-06  9:09 ` Thierry Reding
  2018-06-06 11:38   ` Fabio Estevam
  0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2018-06-06  9:09 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: linux-pwm, Fabio Estevam

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

On Sun, May 20, 2018 at 12:40:15PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Adopt the SPDX license identifier headers to ease license compliance
> management.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  drivers/pwm/pwm-imx.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
> index 08cbe81..6ddd6fd 100644
> --- a/drivers/pwm/pwm-imx.c
> +++ b/drivers/pwm/pwm-imx.c
> @@ -1,12 +1,8 @@
> -/*
> - * simple driver for PWM (Pulse Width Modulator) controller
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
> - * Derived from pxa PWM driver by eric miao <eric.miao@marvell.com>
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +//
> +// simple driver for PWM (Pulse Width Modulator) controller
> +//
> +// Derived from pxa PWM driver by eric miao <eric.miao@marvell.com>

Why do you replace the complete comment by C++ style? I thought only the
SPDX identifier was required to be in that style.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pwm: imx: Switch to SPDX identifier
  2018-06-06  9:09 ` Thierry Reding
@ 2018-06-06 11:38   ` Fabio Estevam
  0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2018-06-06 11:38 UTC (permalink / raw)
  To: Thierry Reding; +Cc: linux-pwm, Fabio Estevam

Hi Thierry,

On Wed, Jun 6, 2018 at 6:09 AM, Thierry Reding <thierry.reding@gmail.com> wrote:

> Why do you replace the complete comment by C++ style? I thought only the
> SPDX identifier was required to be in that style.

Putting everything as // is Linus Torvalds' preferred style:
https://lkml.org/lkml/2017/11/25/133

Regards,

Fabio Estevam

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-06 11:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-20 15:40 [PATCH] pwm: imx: Switch to SPDX identifier Fabio Estevam
2018-06-06  9:09 ` Thierry Reding
2018-06-06 11:38   ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox