* [PATCH] md/md-bitmap: Add missing destroy_work_on_stack()
@ 2024-11-05 13:01 Yuan Can
2024-11-06 1:05 ` Yu Kuai
0 siblings, 1 reply; 2+ messages in thread
From: Yuan Can @ 2024-11-05 13:01 UTC (permalink / raw)
To: song, yukuai3, linux-raid; +Cc: yuancan
This commit add missed destroy_work_on_stack() operations for
unplug_work.work in bitmap_unplug_async().
Fixes: a022325ab970 ("md/md-bitmap: add a new helper to unplug bitmap asynchrously")
Signed-off-by: Yuan Can <yuancan@huawei.com>
---
drivers/md/md-bitmap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
index 29da10e6f703..c3a42dd66ce5 100644
--- a/drivers/md/md-bitmap.c
+++ b/drivers/md/md-bitmap.c
@@ -1285,6 +1285,7 @@ static void bitmap_unplug_async(struct bitmap *bitmap)
queue_work(md_bitmap_wq, &unplug_work.work);
wait_for_completion(&done);
+ destroy_work_on_stack(&unplug_work.work);
}
static void bitmap_unplug(struct mddev *mddev, bool sync)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] md/md-bitmap: Add missing destroy_work_on_stack()
2024-11-05 13:01 [PATCH] md/md-bitmap: Add missing destroy_work_on_stack() Yuan Can
@ 2024-11-06 1:05 ` Yu Kuai
0 siblings, 0 replies; 2+ messages in thread
From: Yu Kuai @ 2024-11-06 1:05 UTC (permalink / raw)
To: Yuan Can, song, linux-raid, yukuai (C)
在 2024/11/05 21:01, Yuan Can 写道:
> This commit add missed destroy_work_on_stack() operations for
> unplug_work.work in bitmap_unplug_async().
>
> Fixes: a022325ab970 ("md/md-bitmap: add a new helper to unplug bitmap asynchrously")
> Signed-off-by: Yuan Can <yuancan@huawei.com>
> ---
> drivers/md/md-bitmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
LGTM
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
> diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
> index 29da10e6f703..c3a42dd66ce5 100644
> --- a/drivers/md/md-bitmap.c
> +++ b/drivers/md/md-bitmap.c
> @@ -1285,6 +1285,7 @@ static void bitmap_unplug_async(struct bitmap *bitmap)
>
> queue_work(md_bitmap_wq, &unplug_work.work);
> wait_for_completion(&done);
> + destroy_work_on_stack(&unplug_work.work);
> }
>
> static void bitmap_unplug(struct mddev *mddev, bool sync)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-06 1:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-05 13:01 [PATCH] md/md-bitmap: Add missing destroy_work_on_stack() Yuan Can
2024-11-06 1:05 ` Yu Kuai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox