From: John Garry <john.g.garry@oracle.com>
To: agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com,
song@kernel.org, yukuai3@huawei.com, hch@lst.de,
nilay@linux.ibm.com, axboe@kernel.dk
Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, linux-block@vger.kernel.org,
ojaswin@linux.ibm.com, martin.petersen@oracle.com,
John Garry <john.g.garry@oracle.com>
Subject: [PATCH v2 4/5] dm-stripe: limit chunk_sectors to the stripe size
Date: Wed, 18 Jun 2025 08:37:36 +0000 [thread overview]
Message-ID: <20250618083737.4084373-5-john.g.garry@oracle.com> (raw)
In-Reply-To: <20250618083737.4084373-1-john.g.garry@oracle.com>
Same as done for raid0, set chunk_sectors limit to appropriately set the
atomic write size limit.
Setting chunk_sectors limit in this way overrides the stacked limit
already calculated based on the bottom device limits. This is ok, as
when any bios are sent to the bottom devices, the block layer will still
respect the bottom device chunk_sectors.
Signed-off-by: John Garry <john.g.garry@oracle.com>
---
drivers/md/dm-stripe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/md/dm-stripe.c b/drivers/md/dm-stripe.c
index a7dc04bd55e5..5bbbdf8fc1bd 100644
--- a/drivers/md/dm-stripe.c
+++ b/drivers/md/dm-stripe.c
@@ -458,6 +458,7 @@ static void stripe_io_hints(struct dm_target *ti,
struct stripe_c *sc = ti->private;
unsigned int chunk_size = sc->chunk_size << SECTOR_SHIFT;
+ limits->chunk_sectors = sc->chunk_size;
limits->io_min = chunk_size;
limits->io_opt = chunk_size * sc->stripes;
}
--
2.31.1
next prev parent reply other threads:[~2025-06-18 8:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 8:37 [PATCH v2 0/5] block/md/dm: set chunk_sectors from stacked dev stripe size John Garry
2025-06-18 8:37 ` [PATCH v2 1/5] block: sanitize chunk_sectors for atomic write limits John Garry
2025-06-20 14:30 ` Nilay Shroff
2025-06-18 8:37 ` [PATCH v2 2/5] md/raid0: set chunk_sectors limit John Garry
2025-06-20 14:31 ` Nilay Shroff
2025-07-02 9:33 ` Yu Kuai
2025-06-18 8:37 ` [PATCH v2 3/5] md/raid10: " John Garry
2025-06-20 14:32 ` Nilay Shroff
2025-07-02 9:33 ` Yu Kuai
2025-06-18 8:37 ` John Garry [this message]
2025-06-20 14:33 ` [PATCH v2 4/5] dm-stripe: limit chunk_sectors to the stripe size Nilay Shroff
2025-06-23 9:49 ` Mikulas Patocka
2025-06-18 8:37 ` [PATCH v2 5/5] block: use chunk_sectors when evaluating stacked atomic write limits John Garry
2025-06-20 2:40 ` Martin K. Petersen
2025-06-20 11:35 ` John Garry
2025-06-20 14:33 ` Nilay Shroff
2025-06-20 14:29 ` [PATCH v2 0/5] block/md/dm: set chunk_sectors from stacked dev stripe size Nilay Shroff
2025-06-26 9:36 ` John Garry
2025-07-02 8:28 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618083737.4084373-5-john.g.garry@oracle.com \
--to=john.g.garry@oracle.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpatocka@redhat.com \
--cc=nilay@linux.ibm.com \
--cc=ojaswin@linux.ibm.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox