From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.g.garry@oracle.com>
Cc: <agk@redhat.com>, <snitzer@kernel.org>, <mpatocka@redhat.com>,
<song@kernel.org>, <yukuai3@huawei.com>, <hch@lst.de>,
<nilay@linux.ibm.com>, <axboe@kernel.dk>,
<dm-devel@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<linux-raid@vger.kernel.org>, <linux-block@vger.kernel.org>,
<ojaswin@linux.ibm.com>, <martin.petersen@oracle.com>
Subject: Re: [PATCH v2 5/5] block: use chunk_sectors when evaluating stacked atomic write limits
Date: Thu, 19 Jun 2025 22:40:52 -0400 [thread overview]
Message-ID: <yq1tt4bt9y5.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250618083737.4084373-6-john.g.garry@oracle.com> (John Garry's message of "Wed, 18 Jun 2025 08:37:37 +0000")
John,
> Furthermore, io_min may be mutated when stacking devices, and this
> makes it a poor candidate to hold the stripe size. Such an example (of
> when io_min may change) would be when the io_min is less than the
> physical block size.
io_min is not allowed to be smaller than the physical_block_size. How
did we end up violating that requirement?
logical_block_size <= physical_block_size <= io_min <= io_opt
--
Martin K. Petersen
next prev parent reply other threads:[~2025-06-20 2:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 8:37 [PATCH v2 0/5] block/md/dm: set chunk_sectors from stacked dev stripe size John Garry
2025-06-18 8:37 ` [PATCH v2 1/5] block: sanitize chunk_sectors for atomic write limits John Garry
2025-06-20 14:30 ` Nilay Shroff
2025-06-18 8:37 ` [PATCH v2 2/5] md/raid0: set chunk_sectors limit John Garry
2025-06-20 14:31 ` Nilay Shroff
2025-07-02 9:33 ` Yu Kuai
2025-06-18 8:37 ` [PATCH v2 3/5] md/raid10: " John Garry
2025-06-20 14:32 ` Nilay Shroff
2025-07-02 9:33 ` Yu Kuai
2025-06-18 8:37 ` [PATCH v2 4/5] dm-stripe: limit chunk_sectors to the stripe size John Garry
2025-06-20 14:33 ` Nilay Shroff
2025-06-23 9:49 ` Mikulas Patocka
2025-06-18 8:37 ` [PATCH v2 5/5] block: use chunk_sectors when evaluating stacked atomic write limits John Garry
2025-06-20 2:40 ` Martin K. Petersen [this message]
2025-06-20 11:35 ` John Garry
2025-06-20 14:33 ` Nilay Shroff
2025-06-20 14:29 ` [PATCH v2 0/5] block/md/dm: set chunk_sectors from stacked dev stripe size Nilay Shroff
2025-06-26 9:36 ` John Garry
2025-07-02 8:28 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1tt4bt9y5.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=nilay@linux.ibm.com \
--cc=ojaswin@linux.ibm.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox