Linux RAID subsystem development
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com,
	song@kernel.org, yukuai3@huawei.com, hch@lst.de,
	nilay@linux.ibm.com, axboe@kernel.dk
Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-block@vger.kernel.org,
	ojaswin@linux.ibm.com, martin.petersen@oracle.com
Subject: Re: [PATCH v2 0/5] block/md/dm: set chunk_sectors from stacked dev stripe size
Date: Thu, 26 Jun 2025 10:36:45 +0100	[thread overview]
Message-ID: <32a644b7-4f27-47b4-80ad-04026b2bfc7d@oracle.com> (raw)
In-Reply-To: <20250618083737.4084373-1-john.g.garry@oracle.com>

On 18/06/2025 09:37, John Garry wrote:
> This value in io_min is used to configure any atomic write limit for the
> stacked device. The idea is that the atomic write unit max is a
> power-of-2 factor of the stripe size, and the stripe size is available
> in io_min.
> 
> Using io_min causes issues, as:
> a. it may be mutated
> b. the check for io_min being set for determining if we are dealing with
> a striped device is hard to get right, as reported in [0].
> 
> This series now sets chunk_sectors limit to share stripe size.

Any more comments here? It would be good to have the md/raid0 and 
md/raid10 changes checked by the md maintainers.

Thanks

> 
> [0] https://lore.kernel.org/linux-block/888f3b1d-7817-4007-b3b3-1a2ea04df771@linux.ibm.com/T/#mecca17129f72811137d3c2f1e477634e77f06781
> 
> Based on v6.16-rc2
> 
> Differences to RFC:
> - sanitize chunk_sectors for atomic write limits
> - set chunk_sectors in stripe_io_hints()
> 
> John Garry (5):
>    block: sanitize chunk_sectors for atomic write limits
>    md/raid0: set chunk_sectors limit
>    md/raid10: set chunk_sectors limit
>    dm-stripe: limit chunk_sectors to the stripe size
>    block: use chunk_sectors when evaluating stacked atomic write limits
> 
>   block/blk-settings.c   | 60 ++++++++++++++++++++++++++----------------
>   drivers/md/dm-stripe.c |  1 +
>   drivers/md/raid0.c     |  1 +
>   drivers/md/raid10.c    |  1 +
>   4 files changed, 40 insertions(+), 23 deletions(-)
> 


  parent reply	other threads:[~2025-06-26  9:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-18  8:37 [PATCH v2 0/5] block/md/dm: set chunk_sectors from stacked dev stripe size John Garry
2025-06-18  8:37 ` [PATCH v2 1/5] block: sanitize chunk_sectors for atomic write limits John Garry
2025-06-20 14:30   ` Nilay Shroff
2025-06-18  8:37 ` [PATCH v2 2/5] md/raid0: set chunk_sectors limit John Garry
2025-06-20 14:31   ` Nilay Shroff
2025-07-02  9:33   ` Yu Kuai
2025-06-18  8:37 ` [PATCH v2 3/5] md/raid10: " John Garry
2025-06-20 14:32   ` Nilay Shroff
2025-07-02  9:33   ` Yu Kuai
2025-06-18  8:37 ` [PATCH v2 4/5] dm-stripe: limit chunk_sectors to the stripe size John Garry
2025-06-20 14:33   ` Nilay Shroff
2025-06-23  9:49   ` Mikulas Patocka
2025-06-18  8:37 ` [PATCH v2 5/5] block: use chunk_sectors when evaluating stacked atomic write limits John Garry
2025-06-20  2:40   ` Martin K. Petersen
2025-06-20 11:35     ` John Garry
2025-06-20 14:33   ` Nilay Shroff
2025-06-20 14:29 ` [PATCH v2 0/5] block/md/dm: set chunk_sectors from stacked dev stripe size Nilay Shroff
2025-06-26  9:36 ` John Garry [this message]
2025-07-02  8:28   ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32a644b7-4f27-47b4-80ad-04026b2bfc7d@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mpatocka@redhat.com \
    --cc=nilay@linux.ibm.com \
    --cc=ojaswin@linux.ibm.com \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox