Re: [PATCH] mdadm: Unitialized variable rdev

Re: [PATCH] mdadm: Unitialized variable rdev

[Jes Sorensen]

On 05/11/2017 05:15 PM, James John wrote:
> mdadm: Uninitialized variable rdev
> 
> rdev is not initialized properly causing compiler complaint.
> 
> Signed-off-by: James Puthukattukaran <joejames70@gmail.com>
> 
> diff --git a/super-ddf.c b/super-ddf.c
> index 9c82f4f..ac14017 100644
> --- a/super-ddf.c
> +++ b/super-ddf.c
> @@ -3526,7 +3526,7 @@ static int validate_geometry_ddf_bvd(
> struct supertype *st,
>                  return 1;
>          }
>          /* This device must be a member of the set */
> -       if (!stat_is_blkdev(dev, NULL))
> +       if (!stat_is_blkdev(dev, &rdev))
>                  return 0;
>          for (dl = ddf->dlist ; dl ; dl = dl->next) {
>                  if (dl->major == (int)major(rdev) &&
> 

Hi James,

This looks correct, but unfortunately you are using a broken mail client 
which replaced the tabs with spaces, and also included HTML junk.

Would you mind sending me a version that works, and I'll be happy to 
apply it.

Thanks,
Jes

Re: [PATCH] mdadm: Unitialized variable rdev

[Zhilong Liu]

On 05/16/2017 05:22 AM, Jes Sorensen wrote:
> On 05/11/2017 05:15 PM, James John wrote:
>> mdadm: Uninitialized variable rdev
>>
>> rdev is not initialized properly causing compiler complaint.
>>
>> Signed-off-by: James Puthukattukaran <joejames70@gmail.com>
>>

Hi James,

Thanks very very much for fixing this.

Best regards,
-Zhilong

>> diff --git a/super-ddf.c b/super-ddf.c
>> index 9c82f4f..ac14017 100644
>> --- a/super-ddf.c
>> +++ b/super-ddf.c
>> @@ -3526,7 +3526,7 @@ static int validate_geometry_ddf_bvd(
>> struct supertype *st,
>>                  return 1;
>>          }
>>          /* This device must be a member of the set */
>> -       if (!stat_is_blkdev(dev, NULL))
>> +       if (!stat_is_blkdev(dev, &rdev))
>>                  return 0;
>>          for (dl = ddf->dlist ; dl ; dl = dl->next) {
>>                  if (dl->major == (int)major(rdev) &&
>>
>
> Hi James,
>
> This looks correct, but unfortunately you are using a broken mail 
> client which replaced the tabs with spaces, and also included HTML junk.
>
> Would you mind sending me a version that works, and I'll be happy to 
> apply it.
>
> Thanks,
> Jes
>
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>