From: Martin KaFai Lau <martin.lau@linux.dev>
To: "D. Wythe" <alibuda@linux.alibaba.com>
Cc: kgraul@linux.ibm.com, wenjia@linux.ibm.com, jaka@linux.ibm.com,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
pabeni@redhat.com, song@kernel.org, sdf@google.com,
haoluo@google.com, yhs@fb.com, edumazet@google.com,
john.fastabend@gmail.com, kpsingh@kernel.org, jolsa@kernel.org,
guwen@linux.alibaba.com, kuba@kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
linux-rdma@vger.kernel.org, bpf@vger.kernel.org,
dtcccc@linux.alibaba.com
Subject: Re: [PATCH net-next 3/4] net/smc: Introduce smc_bpf_ops
Date: Fri, 25 Oct 2024 11:30:10 -0700 [thread overview]
Message-ID: <0e5712f2-7ecc-457a-afb7-4b304eb1bffa@linux.dev> (raw)
In-Reply-To: <e398770a-1ab5-478b-820d-16c6060e0008@linux.alibaba.com>
On 10/25/24 4:05 AM, D. Wythe wrote:
> Our main concern is to avoid introducing kfuncs as much as possible. For our
> subsystem, we might need to maintain it in a way that maintains a uapi, as we
> certainly have user applications depending on it.
The smc_bpf_ops can read/write the tp and ireq. In patch 4, there is
'tp->syn_smc = 1'. I assume the real bpf prog will read something from the tp to
make the decision also. Note that tp/ireq is also not in the uapi but the CO-RE
can help in case the tp->syn_smc bool is moved around.
From looking at the selftest in patch 4 again, I think all it needs is for the
bpf prog (i.e. the ops) to return a bool instead of allowing the bpf prog to
write or call a kfunc to change the tp/ireq.
next prev parent reply other threads:[~2024-10-25 18:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 2:42 [PATCH bpf-next 0/4] net/smc: Introduce smc_bpf_ops D. Wythe
2024-10-24 2:42 ` [PATCH bpf-next 1/4] bpf: export necessary sympols for modules D. Wythe
2024-10-24 2:42 ` [PATCH bpf-next 2/4] bpf: allow to access bpf_prog during bpf_struct_access D. Wythe
2024-10-25 9:14 ` kernel test robot
2024-10-25 12:20 ` kernel test robot
2024-10-24 2:42 ` [PATCH net-next 3/4] net/smc: Introduce smc_bpf_ops D. Wythe
2024-10-25 0:26 ` Martin KaFai Lau
2024-10-25 11:05 ` D. Wythe
2024-10-25 18:30 ` Martin KaFai Lau [this message]
2024-10-29 8:53 ` D. Wythe
2024-10-24 2:42 ` [PATCH bpf-next 4/4] bpf/selftests: add simple selftest for bpf_smc_ops D. Wythe
2024-10-24 4:04 ` D. Wythe
2024-10-24 4:49 ` Tianchen Ding
2024-10-24 5:49 ` D. Wythe
2024-11-03 13:01 ` Zhu Yanjun
2024-11-21 2:00 ` D. Wythe
2024-11-25 10:52 ` Zhu Yanjun
2024-11-25 23:32 ` Martin KaFai Lau
2024-11-26 8:29 ` Zhu Yanjun
2024-11-29 4:11 ` D. Wythe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e5712f2-7ecc-457a-afb7-4b304eb1bffa@linux.dev \
--to=martin.lau@linux.dev \
--cc=alibuda@linux.alibaba.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dtcccc@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=haoluo@google.com \
--cc=jaka@linux.ibm.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kgraul@linux.ibm.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=wenjia@linux.ibm.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox