public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
	RDMA list <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCHv9 09/12] ib_core: Add VLAN support to IBoE
Date: Tue, 17 Aug 2010 17:36:23 +0300	[thread overview]
Message-ID: <20100817143623.GA626@mtldesk30> (raw)
In-Reply-To: <adaeidyw6bd.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>

On Mon, Aug 16, 2010 at 03:17:42PM -0700, Roland Dreier wrote:
> 
> I'm having a hard time figuring out what this sentence has to do with
> this patch.  I don't see anywhere in the patch where the sl field is
> used except for copying the TOS into it, and I don't see what "user
> priority field" might be referring to.
(per the RoCE spec) the 3 LSbs of the SL in the address vector carry
the value that is meant to be used in the 802.1Q priority field
(user_priority).

> 
> Also, how do VLANs work with multicast?  As far as I can tell, there are
> no spare bits in an IB MGID or IPv6 multicast address that can be stolen
> to use for a VLAN ID.  For example, how would I create an AH to use to
> send to MGID ff02::1 on VLAN 25?
> 
We take the VLAN from the SGID.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-08-17 14:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-06 14:41 [PATCHv9 09/12] ib_core: Add VLAN support to IBoE Eli Cohen
2010-08-06 16:49 ` Jason Gunthorpe
     [not found]   ` <20100806164915.GL11306-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-08-16 12:51     ` Eli Cohen
2010-08-16 22:17       ` Roland Dreier
     [not found]         ` <adaeidyw6bd.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-08-17 14:36           ` Eli Cohen [this message]
2010-08-17 16:43             ` Roland Dreier
     [not found]               ` <adatymtur55.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-08-17 18:29                 ` Eli Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100817143623.GA626@mtldesk30 \
    --to=eli-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox