[PATCH] rdma: replace deprecated ifconfig in doc

[PATCH] rdma: replace deprecated ifconfig in doc

[Stephen Hemminger]

The ifconfig command has been deprecated for many years.
To encourage new users not to continue using it and learning
iproute2; the ifconfig should not be used in examples.

Signed-off-by: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>


--- a/Documentation/filesystems/nfs/nfs-rdma.txt	2014-09-28 16:27:20.393505440 -0700
+++ b/Documentation/filesystems/nfs/nfs-rdma.txt	2015-03-08 16:33:21.483985810 -0700
@@ -187,8 +187,10 @@ Check RDMA and NFS Setup
     To further test the InfiniBand software stack, use IPoIB (this
     assumes you have two IB hosts named host1 and host2):
 
-    host1$ ifconfig ib0 a.b.c.x
-    host2$ ifconfig ib0 a.b.c.y
+    host1$ ip link set dev ib0 up
+    host1$ ip address add dev ib0 a.b.c.x
+    host2$ ip link set dev ib0 up
+    host2$ ip address add dev ib0 a.b.c.y
     host1$ ping a.b.c.y
     host2$ ping a.b.c.x
 
@@ -229,7 +231,8 @@ NFS/RDMA Setup
 
     $ modprobe ib_mthca
     $ modprobe ib_ipoib
-    $ ifconfig ib0 a.b.c.d
+    $ ip li set dev ib0 up
+    $ ip addr add dev ib0 a.b.c.d
 
     NOTE: use unique addresses for the client and server
 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rdma: replace deprecated ifconfig in doc

[Yann Droneaud]

Hi,

Le dimanche 08 mars 2015 à 16:36 -0700, Stephen Hemminger a écrit :
> The ifconfig command has been deprecated for many years.
> To encourage new users not to continue using it and learning
> iproute2; the ifconfig should not be used in examples.
> 
> Signed-off-by: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
> 
> 
> --- a/Documentation/filesystems/nfs/nfs-rdma.txt	2014-09-28 16:27:20.393505440 -0700
> +++ b/Documentation/filesystems/nfs/nfs-rdma.txt	2015-03-08 16:33:21.483985810 -0700
> @@ -187,8 +187,10 @@ Check RDMA and NFS Setup
>      To further test the InfiniBand software stack, use IPoIB (this
>      assumes you have two IB hosts named host1 and host2):
>  
> -    host1$ ifconfig ib0 a.b.c.x
> -    host2$ ifconfig ib0 a.b.c.y
> +    host1$ ip link set dev ib0 up
> +    host1$ ip address add dev ib0 a.b.c.x
> +    host2$ ip link set dev ib0 up

I don't think we need to "up" the device twice.

> +    host2$ ip address add dev ib0 a.b.c.y
>      host1$ ping a.b.c.y
>      host2$ ping a.b.c.x
>  
> @@ -229,7 +231,8 @@ NFS/RDMA Setup
>  
>      $ modprobe ib_mthca
>      $ modprobe ib_ipoib
> -    $ ifconfig ib0 a.b.c.d
> +    $ ip li set dev ib0 up

s/li/link ?

> +    $ ip addr add dev ib0 a.b.c.d
>  
>      NOTE: use unique addresses for the client and server

Regards.

-- 
Yann Droneaud
OPTEYA



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rdma: replace deprecated ifconfig in doc

[Stephen Hemminger]

On Mon, 09 Mar 2015 13:06:30 +0100
Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org> wrote:

> Hi,
> 
> Le dimanche 08 mars 2015 à 16:36 -0700, Stephen Hemminger a écrit :
> > The ifconfig command has been deprecated for many years.
> > To encourage new users not to continue using it and learning
> > iproute2; the ifconfig should not be used in examples.
> > 
> > Signed-off-by: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
> > 
> > 
> > --- a/Documentation/filesystems/nfs/nfs-rdma.txt	2014-09-28 16:27:20.393505440 -0700
> > +++ b/Documentation/filesystems/nfs/nfs-rdma.txt	2015-03-08 16:33:21.483985810 -0700
> > @@ -187,8 +187,10 @@ Check RDMA and NFS Setup
> >      To further test the InfiniBand software stack, use IPoIB (this
> >      assumes you have two IB hosts named host1 and host2):
> >  
> > -    host1$ ifconfig ib0 a.b.c.x
> > -    host2$ ifconfig ib0 a.b.c.y
> > +    host1$ ip link set dev ib0 up
> > +    host1$ ip address add dev ib0 a.b.c.x
> > +    host2$ ip link set dev ib0 up
> 
> I don't think we need to "up" the device twice.

You need to do it on each host.

> > +    host2$ ip address add dev ib0 a.b.c.y
> >      host1$ ping a.b.c.y
> >      host2$ ping a.b.c.x
> >  
> > @@ -229,7 +231,8 @@ NFS/RDMA Setup
> >  
> >      $ modprobe ib_mthca
> >      $ modprobe ib_ipoib
> > -    $ ifconfig ib0 a.b.c.d
> > +    $ ip li set dev ib0 up
> 
> s/li/link ?

ip commands support shorthand.

> > +    $ ip addr add dev ib0 a.b.c.d
> >  
> >      NOTE: use unique addresses for the client and server
> 
> Regards.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rdma: replace deprecated ifconfig in doc

[Yann Droneaud]

Hi,

Le lundi 09 mars 2015 à 11:29 -0700, Stephen Hemminger a écrit :
> On Mon, 09 Mar 2015 13:06:30 +0100
> Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org> wrote:
> > Le dimanche 08 mars 2015 à 16:36 -0700, Stephen Hemminger a écrit :
> > > The ifconfig command has been deprecated for many years.
> > > To encourage new users not to continue using it and learning
> > > iproute2; the ifconfig should not be used in examples.
> > > 
> > > Signed-off-by: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
> > > 
> > > 
> > > --- a/Documentation/filesystems/nfs/nfs-rdma.txt	2014-09-28 16:27:20.393505440 -0700
> > > +++ b/Documentation/filesystems/nfs/nfs-rdma.txt	2015-03-08 16:33:21.483985810 -0700
> > > @@ -187,8 +187,10 @@ Check RDMA and NFS Setup
> > >      To further test the InfiniBand software stack, use IPoIB (this
> > >      assumes you have two IB hosts named host1 and host2):
> > >  
> > > -    host1$ ifconfig ib0 a.b.c.x
> > > -    host2$ ifconfig ib0 a.b.c.y
> > > +    host1$ ip link set dev ib0 up
> > > +    host1$ ip address add dev ib0 a.b.c.x
> > > +    host2$ ip link set dev ib0 up
> > 
> > I don't think we need to "up" the device twice.
> 
> You need to do it on each host.
> 

Oops, missed that. Sorry.

> > > +    host2$ ip address add dev ib0 a.b.c.y
> > >      host1$ ping a.b.c.y
> > >      host2$ ping a.b.c.x
> > >  
> > > @@ -229,7 +231,8 @@ NFS/RDMA Setup
> > >  
> > >      $ modprobe ib_mthca
> > >      $ modprobe ib_ipoib
> > > -    $ ifconfig ib0 a.b.c.d
> > > +    $ ip li set dev ib0 up
> > 
> > s/li/link ?
> 
> ip commands support shorthand.
> 

Yes, sure, but here, it's looking more like a typo.
It should be consistent throughout the document.

Regards.

-- 
Yann Droneaud
OPTEYA


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html