[target:nvmet-configfs-ng 22/27] drivers/nvme/target/rdma.c:1441:1-3: WARNING: PTR_ERR_OR_ZERO can be used

[target:nvmet-configfs-ng 22/27] drivers/nvme/target/rdma.c:1441:1-3: WARNING: PTR_ERR_OR_ZERO can be used

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git nvmet-configfs-ng
head:   9589c853cae62cadabb17a3c48f9fdb3da5fa83c
commit: 49503f06b9b36b6c691435b25a31f6ab6c808f13 [22/27] nvmet/rdma: Convert to struct nvmet_port_binding


coccinelle warnings: (new ones prefixed by >>)

>> drivers/nvme/target/rdma.c:1441:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] nvmet/rdma: fix ptr_ret.cocci warnings

[kbuild test robot]

drivers/nvme/target/rdma.c:1441:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Signed-off-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---

 rdma.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -1438,10 +1438,7 @@ static int nvmet_rdma_add_port(struct nv
 	mutex_unlock(&nvmet_rdma_ports_mutex);
 
 	rdma_port = nvmet_rdma_listen_cmid(pb);
-	if (IS_ERR(rdma_port))
-		return PTR_ERR(rdma_port);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(rdma_port);
 }
 
 static void nvmet_rdma_remove_port(struct nvmet_port_binding *pb)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] nvmet/rdma: fix ptr_ret.cocci warnings

[Nicholas A. Bellinger]

On Tue, 2016-06-14 at 13:25 +0800, kbuild test robot wrote:
> drivers/nvme/target/rdma.c:1441:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> 
>  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>  rdma.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> --- a/drivers/nvme/target/rdma.c
> +++ b/drivers/nvme/target/rdma.c
> @@ -1438,10 +1438,7 @@ static int nvmet_rdma_add_port(struct nv
>  	mutex_unlock(&nvmet_rdma_ports_mutex);
>  
>  	rdma_port = nvmet_rdma_listen_cmid(pb);
> -	if (IS_ERR(rdma_port))
> -		return PTR_ERR(rdma_port);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(rdma_port);
>  }
>  

Applied.  Thanks Fengguang!