Re: [PATCH rdma-next 1/9] RDMA/bnxt_re: Update sysfs entries with appropriate data

[Leon Romanovsky <leon@kernel.org>]

On Thu, Aug 14, 2025 at 04:55:47PM +0530, Kalesh AP wrote:
> From: Anantha Prabhu <anantha.prabhu@broadcom.com>
> 
> Updated the existing sysfs entries with correct data.
> This change is to align the behavior with our OOB driver.
> Added "board_id" sysfs entry which will provide the
> VPD Part number, if exists.
> 
> Signed-off-by: Anantha Prabhu <anantha.prabhu@broadcom.com>
> Signed-off-by: Saravanan Vajravel <saravanan.vajravel@broadcom.com>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> ---
>  drivers/infiniband/hw/bnxt_re/bnxt_re.h |  2 +
>  drivers/infiniband/hw/bnxt_re/main.c    | 49 ++++++++++++++++++++++++-
>  2 files changed, 49 insertions(+), 2 deletions(-)

<...>

> +static ssize_t board_id_show(struct device *device, struct device_attribute *attr,
> +			     char *buf)
> +{
> +	struct bnxt_re_dev *rdev = rdma_device_to_drv_device(device,
> +							     struct bnxt_re_dev, ibdev);
> +	char buffer[BNXT_VPD_FLD_LEN] = {};
> +
> +	if (!rdev->is_virtfn)
> +		memcpy(buffer, rdev->board_partno, BNXT_VPD_FLD_LEN - 1);
> +	else
> +		scnprintf(buffer, BNXT_VPD_FLD_LEN, "0x%x-VF",
> +			  rdev->en_dev->pdev->device);
> +
> +	return scnprintf(buf, PAGE_SIZE, "%s\n", buffer);

You should use sysfs_emit() here.

> +}
> +static DEVICE_ATTR_RO(board_id);

Thanks