Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
To: leon@kernel.org, jgg@ziepe.ca
Cc: linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com,
	selvin.xavier@broadcom.com, kalesh-anakkur.purayil@broadcom.com,
	Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: [PATCH rdma-next v2 3/8] RDMA/bnxt_re: Update sq depth for app allocated QPs
Date: Fri, 27 Mar 2026 14:47:50 +0530	[thread overview]
Message-ID: <20260327091755.47754-4-sriharsha.basavapatna@broadcom.com> (raw)
In-Reply-To: <20260327091755.47754-1-sriharsha.basavapatna@broadcom.com>

For app allocated QPs, there's no need to reserve extra slots.
The application accounts for this while allocating the SQ.

Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Reviewed-by: Selvin Xavier <selvin.xavier@broadcom.com>
---
 drivers/infiniband/hw/bnxt_re/ib_verbs.c | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
index 61879222248d..9a101f862c32 100644
--- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
+++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
@@ -1542,7 +1542,8 @@ static void bnxt_re_adjust_gsi_rq_attr(struct bnxt_re_qp *qp)
 static int bnxt_re_init_sq_attr(struct bnxt_re_qp *qp,
 				struct ib_qp_init_attr *init_attr,
 				struct bnxt_re_ucontext *uctx,
-				struct bnxt_re_qp_req *ureq)
+				struct bnxt_re_qp_req *ureq,
+				bool app_qp)
 {
 	struct bnxt_qplib_dev_attr *dev_attr;
 	struct bnxt_qplib_qp *qplqp;
@@ -1583,13 +1584,18 @@ static int bnxt_re_init_sq_attr(struct bnxt_re_qp *qp,
 			sq->max_sw_wqe = sq->max_wqe;
 
 	}
-	sq->q_full_delta = diff + 1;
-	/*
-	 * Reserving one slot for Phantom WQE. Application can
-	 * post one extra entry in this case. But allowing this to avoid
-	 * unexpected Queue full condition
-	 */
-	qplqp->sq.q_full_delta -= 1;
+	if (!app_qp) {
+		sq->q_full_delta = diff + 1;
+		/*
+		 * Reserving one slot for Phantom WQE. Application can
+		 * post one extra entry in this case. But allowing this to avoid
+		 * unexpected Queue full condition
+		 */
+		qplqp->sq.q_full_delta -= 1;
+	} else {
+		sq->q_full_delta = 0;
+	}
+
 	qplqp->sq.sg_info.pgsize = PAGE_SIZE;
 	qplqp->sq.sg_info.pgshft = PAGE_SHIFT;
 
@@ -1738,7 +1744,7 @@ static int bnxt_re_init_qp_attr(struct bnxt_re_qp *qp, struct bnxt_re_pd *pd,
 		bnxt_re_adjust_gsi_rq_attr(qp);
 
 	/* Setup SQ */
-	rc = bnxt_re_init_sq_attr(qp, init_attr, uctx, ureq);
+	rc = bnxt_re_init_sq_attr(qp, init_attr, uctx, ureq, app_qp);
 	if (rc)
 		return rc;
 	if (init_attr->qp_type == IB_QPT_GSI)
-- 
2.51.2.636.ga99f379adf


  parent reply	other threads:[~2026-03-27  9:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27  9:17 [PATCH rdma-next v2 0/8] RDMA/bnxt_re: Support QP uapi extensions Sriharsha Basavapatna
2026-03-27  9:17 ` [PATCH rdma-next v2 1/8] RDMA/bnxt_re: Refactor bnxt_re_init_user_qp() Sriharsha Basavapatna
2026-03-27  9:17 ` [PATCH rdma-next v2 2/8] RDMA/bnxt_re: Update rq depth for app allocated QPs Sriharsha Basavapatna
2026-03-27  9:17 ` Sriharsha Basavapatna [this message]
2026-03-27  9:17 ` [PATCH rdma-next v2 4/8] RDMA/bnxt_re: Update umem " Sriharsha Basavapatna
2026-03-27  9:17 ` [PATCH rdma-next v2 5/8] RDMA/bnxt_re: Update msn table size " Sriharsha Basavapatna
2026-03-27  9:17 ` [PATCH rdma-next v2 6/8] RDMA/bnxt_re: Update hwq depth " Sriharsha Basavapatna
2026-03-27  9:17 ` [PATCH rdma-next v2 7/8] RDMA/bnxt_re: Support doorbells " Sriharsha Basavapatna
2026-03-27  9:17 ` [PATCH rdma-next v2 8/8] RDMA/bnxt_re: Enable " Sriharsha Basavapatna
2026-04-10 15:27   ` Jason Gunthorpe
2026-04-14  6:13     ` Sriharsha Basavapatna
2026-04-14 12:34       ` Jason Gunthorpe
2026-04-14 13:40         ` Sriharsha Basavapatna
2026-04-14 13:54           ` Jason Gunthorpe
2026-04-14 14:06             ` Sriharsha Basavapatna
2026-04-14 14:19               ` Jason Gunthorpe
2026-04-14 14:34                 ` Sriharsha Basavapatna
2026-04-14 15:09                   ` Jason Gunthorpe
2026-04-14 15:14                     ` Sriharsha Basavapatna
2026-04-10 15:25 ` [PATCH rdma-next v2 0/8] RDMA/bnxt_re: Support QP uapi extensions Jason Gunthorpe
2026-04-14  6:13   ` Sriharsha Basavapatna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260327091755.47754-4-sriharsha.basavapatna@broadcom.com \
    --to=sriharsha.basavapatna@broadcom.com \
    --cc=andrew.gospodarek@broadcom.com \
    --cc=jgg@ziepe.ca \
    --cc=kalesh-anakkur.purayil@broadcom.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=selvin.xavier@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox