Re: [PATCH rdma-next v2 8/8] RDMA/bnxt_re: Enable app allocated QPs

[Jason Gunthorpe <jgg@ziepe.ca>]

On Tue, Apr 14, 2026 at 11:43:51AM +0530, Sriharsha Basavapatna wrote:
> On Fri, Apr 10, 2026 at 8:57 PM Jason Gunthorpe <jgg@ziepe.ca> wrote:
> >
> > On Fri, Mar 27, 2026 at 02:47:55PM +0530, Sriharsha Basavapatna wrote:
> > > The driver supports a new comp_mask: APP_ALLOCATED_QP_ENABLE.
> > > The application sets this comp_mask bit in the CREATE_QP ureq
> > > to indicate direct control of the QP. The driver goes through
> > > the required processing for app allocated QPs. Only variable
> > > WQE mode is supported for these QPs.
> >
> > I thought we talked about this, no weird names like this.
> Are you talking about the comp_mask name or the wqe_mode (VARIABLE)
> name? We used the comp_mask name (APP_ALLOCATED_QP) because the
> application allocates (and owns/manages) this QP memory instead of the
> library.
> If it is the comp_mask, how about one of these alternatives?
> - USER_MEMORY_QP
> - USER_MANAGED_QP
> - USER_CONFIGURABLE_QP
> - EXTERNAL_MEMORY_QP
> - DIRECT_ACCESS_QP
> 
> For the WQE variable mode, please see my response below.

Still no, make the flags reflect micro functionality relative to the
kernel operation. None of the above in any way explain what the flag
is doing to the ioctl.

The only thing the flag does is this:

> > > @@ -1734,6 +1734,8 @@ static int bnxt_re_init_qp_attr(struct bnxt_re_qp *qp, struct bnxt_re_pd *pd,
> > >               return qptype;
> > >       qplqp->type = (u8)qptype;
> > >       qplqp->wqe_mode = bnxt_re_is_var_size_supported(rdev, uctx);
> > > +     if (app_qp && qplqp->wqe_mode != BNXT_QPLIB_WQE_MODE_VARIABLE)
> > > +             return -EOPNOTSUPP;
> >
> > Give a sensible name for whatever this is and use it only for
> > this.

So what is this even? FORCE_WQE_MODE_TO_VARIABLE?

> > I kind of thinking you can just fully drop it? What is the point in
> > checking userspace set VARIABLE? It isn't signalling HW and it isn't
> > protecting anything.
> VARIABLE wqe_mode is not something that we introduced in this series.
> It already exists and is understood by the FW/HW. In
> bnxt_qplib_create_qp(), hardware is signaled through flags.

Yes, and it's fine, you added app_qp and the only thing it does is
check that userspace set VARIABLE. Why?

Jason