Re: [PATCH rdma-next v2 8/8] RDMA/bnxt_re: Enable app allocated QPs

[Jason Gunthorpe <jgg@ziepe.ca>]

On Tue, Apr 14, 2026 at 08:04:22PM +0530, Sriharsha Basavapatna wrote:
> On Tue, Apr 14, 2026 at 7:49 PM Jason Gunthorpe <jgg@ziepe.ca> wrote:
> >
> > On Tue, Apr 14, 2026 at 07:36:48PM +0530, Sriharsha Basavapatna wrote:
> > > On Tue, Apr 14, 2026 at 7:24 PM Jason Gunthorpe <jgg@ziepe.ca> wrote:
> > > >
> > > > On Tue, Apr 14, 2026 at 07:10:41PM +0530, Sriharsha Basavapatna wrote:
> > > >
> > > > > > Yes, and it's fine, you added app_qp and the only thing it does is
> > > > > > check that userspace set VARIABLE. Why?
> > > > > No, app_qp (boolean) is used to make other decisions too. It is passed
> > > > > down to other routines and all that logic is in earlier patches (2-7).
> > > > > This patch just enables it.
> > > >
> > > > So list what it actually does?
> > > That is described in the commit messages of prior patches. To summarize:
> > > - update rq depth
> > > - update sq depth
> > > - update msn table size
> > > - update hwq depth
> >
> > What does "update" mean? All these parameters already exist in the input.
> Yes, they are existing variables, but they are set differently if
> app_qp is enabled. We don't need to compute their values (such as
> adding extra slots or rounding up, etc). The application handles that,
> and the driver just uses those values. And so we "update them
> differently for app_qps".

So your comp_mask setting is more like "RAW VALUES" for those existing
inputs, similar to what you did in CQ

Jasoon