* [PATCH for-next v2] RDMA/rxe: Remove unused mask parameter
@ 2022-07-15 3:46 lizhijian
2022-07-15 17:21 ` Bob Pearson
2022-07-18 11:52 ` Leon Romanovsky
0 siblings, 2 replies; 3+ messages in thread
From: lizhijian @ 2022-07-15 3:46 UTC (permalink / raw)
To: Yanjun Zhu, Jason Gunthorpe, linux-rdma@vger.kernel.org
Cc: Bob Pearson, lizhijian@fujitsu.com
This parameter had beed deprecated since below commit:
1a7085b34291 ("RDMA/rxe: Skip adjusting remote addr for write in retry operation")
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
Feel free to add above commit to fixes tag if needed.
V2: add commit log.
---
drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index 69fc35485e60..35a249727435 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -15,8 +15,7 @@ static int next_opcode(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
u32 opcode);
static inline void retry_first_write_send(struct rxe_qp *qp,
- struct rxe_send_wqe *wqe,
- unsigned int mask, int npsn)
+ struct rxe_send_wqe *wqe, int npsn)
{
int i;
@@ -83,7 +82,7 @@ static void req_retry(struct rxe_qp *qp)
if (mask & WR_WRITE_OR_SEND_MASK) {
npsn = (qp->comp.psn - wqe->first_psn) &
BTH_PSN_MASK;
- retry_first_write_send(qp, wqe, mask, npsn);
+ retry_first_write_send(qp, wqe, npsn);
}
if (mask & WR_READ_MASK) {
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH for-next v2] RDMA/rxe: Remove unused mask parameter
2022-07-15 3:46 [PATCH for-next v2] RDMA/rxe: Remove unused mask parameter lizhijian
@ 2022-07-15 17:21 ` Bob Pearson
2022-07-18 11:52 ` Leon Romanovsky
1 sibling, 0 replies; 3+ messages in thread
From: Bob Pearson @ 2022-07-15 17:21 UTC (permalink / raw)
To: lizhijian@fujitsu.com, Yanjun Zhu, Jason Gunthorpe,
linux-rdma@vger.kernel.org
On 7/14/22 22:46, lizhijian@fujitsu.com wrote:
> This parameter had beed deprecated since below commit:
> 1a7085b34291 ("RDMA/rxe: Skip adjusting remote addr for write in retry operation")
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> Feel free to add above commit to fixes tag if needed.
> V2: add commit log.
> ---
> drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
> index 69fc35485e60..35a249727435 100644
> --- a/drivers/infiniband/sw/rxe/rxe_req.c
> +++ b/drivers/infiniband/sw/rxe/rxe_req.c
> @@ -15,8 +15,7 @@ static int next_opcode(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
> u32 opcode);
>
> static inline void retry_first_write_send(struct rxe_qp *qp,
> - struct rxe_send_wqe *wqe,
> - unsigned int mask, int npsn)
> + struct rxe_send_wqe *wqe, int npsn)
> {
> int i;
>
> @@ -83,7 +82,7 @@ static void req_retry(struct rxe_qp *qp)
> if (mask & WR_WRITE_OR_SEND_MASK) {
> npsn = (qp->comp.psn - wqe->first_psn) &
> BTH_PSN_MASK;
> - retry_first_write_send(qp, wqe, mask, npsn);
> + retry_first_write_send(qp, wqe, npsn);
> }
>
> if (mask & WR_READ_MASK) {
Reviewed-by: Bob Pearson <rpearsonhpe@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH for-next v2] RDMA/rxe: Remove unused mask parameter
2022-07-15 3:46 [PATCH for-next v2] RDMA/rxe: Remove unused mask parameter lizhijian
2022-07-15 17:21 ` Bob Pearson
@ 2022-07-18 11:52 ` Leon Romanovsky
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2022-07-18 11:52 UTC (permalink / raw)
To: lizhijian@fujitsu.com
Cc: Yanjun Zhu, Jason Gunthorpe, linux-rdma@vger.kernel.org,
Bob Pearson
On Fri, Jul 15, 2022 at 03:46:36AM +0000, lizhijian@fujitsu.com wrote:
> This parameter had beed deprecated since below commit:
> 1a7085b34291 ("RDMA/rxe: Skip adjusting remote addr for write in retry operation")
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> Feel free to add above commit to fixes tag if needed.
> V2: add commit log.
> ---
> drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
Thanks, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-18 11:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-15 3:46 [PATCH for-next v2] RDMA/rxe: Remove unused mask parameter lizhijian
2022-07-15 17:21 ` Bob Pearson
2022-07-18 11:52 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox