* [PATCH] infiniband: hw: Drop unnecessary continue
@ 2018-03-03 13:03 Arushi Singhal
2018-03-03 14:07 ` [Outreachy kernel] " Julia Lawall
2018-03-03 15:32 ` Dennis Dalessandro
0 siblings, 2 replies; 4+ messages in thread
From: Arushi Singhal @ 2018-03-03 13:03 UTC (permalink / raw)
To: dennis.dalessandro
Cc: mike.marciniszyn, Doug Ledford, Jason Gunthorpe, linux-rdma,
linux-kernel, outreachy-kernel
Continue at the bottom of a loop are removed.
Issue found using drop_continue.cocci Coccinelle script.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/infiniband/hw/qib/qib_init.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c
index 3990f38..1bd3b32 100644
--- a/drivers/infiniband/hw/qib/qib_init.c
+++ b/drivers/infiniband/hw/qib/qib_init.c
@@ -681,7 +681,6 @@ int qib_init(struct qib_devdata *dd, int reinit)
if (lastfail) {
qib_dev_err(dd,
"failed to allocate kernel ctxt's rcvhdrq and/or egr bufs\n");
- continue;
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] [PATCH] infiniband: hw: Drop unnecessary continue
2018-03-03 13:03 [PATCH] infiniband: hw: Drop unnecessary continue Arushi Singhal
@ 2018-03-03 14:07 ` Julia Lawall
2018-03-03 15:34 ` Dennis Dalessandro
2018-03-03 15:32 ` Dennis Dalessandro
1 sibling, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2018-03-03 14:07 UTC (permalink / raw)
To: Arushi Singhal
Cc: dennis.dalessandro, mike.marciniszyn, Doug Ledford,
Jason Gunthorpe, linux-rdma, linux-kernel, outreachy-kernel
On Sat, 3 Mar 2018, Arushi Singhal wrote:
> Continue at the bottom of a loop are removed.
> Issue found using drop_continue.cocci Coccinelle script.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/infiniband/hw/qib/qib_init.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c
> index 3990f38..1bd3b32 100644
> --- a/drivers/infiniband/hw/qib/qib_init.c
> +++ b/drivers/infiniband/hw/qib/qib_init.c
> @@ -681,7 +681,6 @@ int qib_init(struct qib_devdata *dd, int reinit)
> if (lastfail) {
> qib_dev_err(dd,
> "failed to allocate kernel ctxt's rcvhdrq and/or egr bufs\n");
> - continue;
> }
Again, the braces should be dropped too.
julia
> }
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180303130336.GA8210%40seema-Inspiron-15-3567.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] [PATCH] infiniband: hw: Drop unnecessary continue
2018-03-03 14:07 ` [Outreachy kernel] " Julia Lawall
@ 2018-03-03 15:34 ` Dennis Dalessandro
0 siblings, 0 replies; 4+ messages in thread
From: Dennis Dalessandro @ 2018-03-03 15:34 UTC (permalink / raw)
To: Julia Lawall, Arushi Singhal
Cc: mike.marciniszyn, Doug Ledford, Jason Gunthorpe, linux-rdma,
linux-kernel, outreachy-kernel
On 3/3/2018 9:07 AM, Julia Lawall wrote:
>> diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c
>> index 3990f38..1bd3b32 100644
>> --- a/drivers/infiniband/hw/qib/qib_init.c
>> +++ b/drivers/infiniband/hw/qib/qib_init.c
>> @@ -681,7 +681,6 @@ int qib_init(struct qib_devdata *dd, int reinit)
>> if (lastfail) {
>> qib_dev_err(dd,
>> "failed to allocate kernel ctxt's rcvhdrq and/or egr bufs\n");
>> - continue;
>> }
>
> Again, the braces should be dropped too.
Thanks Julia, I just noticed the same thing! :)
-Denny
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] infiniband: hw: Drop unnecessary continue
2018-03-03 13:03 [PATCH] infiniband: hw: Drop unnecessary continue Arushi Singhal
2018-03-03 14:07 ` [Outreachy kernel] " Julia Lawall
@ 2018-03-03 15:32 ` Dennis Dalessandro
1 sibling, 0 replies; 4+ messages in thread
From: Dennis Dalessandro @ 2018-03-03 15:32 UTC (permalink / raw)
To: Arushi Singhal
Cc: mike.marciniszyn, Doug Ledford, Jason Gunthorpe, linux-rdma,
linux-kernel, outreachy-kernel
On 3/3/2018 8:03 AM, Arushi Singhal wrote:
> Continue at the bottom of a loop are removed.
> Issue found using drop_continue.cocci Coccinelle script.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/infiniband/hw/qib/qib_init.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c
> index 3990f38..1bd3b32 100644
> --- a/drivers/infiniband/hw/qib/qib_init.c
> +++ b/drivers/infiniband/hw/qib/qib_init.c
> @@ -681,7 +681,6 @@ int qib_init(struct qib_devdata *dd, int reinit)
> if (lastfail) {
> qib_dev_err(dd,
> "failed to allocate kernel ctxt's rcvhdrq and/or egr bufs\n");
> - continue;
> }
> }
>
>
Please run checkpatch before posting patches. This will fail as you left
braces around a single line.
-Denny
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-03 15:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-03 13:03 [PATCH] infiniband: hw: Drop unnecessary continue Arushi Singhal
2018-03-03 14:07 ` [Outreachy kernel] " Julia Lawall
2018-03-03 15:34 ` Dennis Dalessandro
2018-03-03 15:32 ` Dennis Dalessandro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox