* [PATCH] hwspinlock: omap: drop of_match_ptr for ID table
@ 2023-03-11 11:14 Krzysztof Kozlowski
2023-03-13 1:25 ` Baolin Wang
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-11 11:14 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson, Baolin Wang, linux-omap,
linux-remoteproc, linux-kernel
Cc: Krzysztof Kozlowski
The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it might not be relevant here).
drivers/hwspinlock/omap_hwspinlock.c:164:34: error: ‘omap_hwspinlock_of_match’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/hwspinlock/omap_hwspinlock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwspinlock/omap_hwspinlock.c b/drivers/hwspinlock/omap_hwspinlock.c
index 1fb3a2550e29..dfe82952671b 100644
--- a/drivers/hwspinlock/omap_hwspinlock.c
+++ b/drivers/hwspinlock/omap_hwspinlock.c
@@ -174,7 +174,7 @@ static struct platform_driver omap_hwspinlock_driver = {
.remove = omap_hwspinlock_remove,
.driver = {
.name = "omap_hwspinlock",
- .of_match_table = of_match_ptr(omap_hwspinlock_of_match),
+ .of_match_table = omap_hwspinlock_of_match,
},
};
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwspinlock: omap: drop of_match_ptr for ID table
2023-03-11 11:14 [PATCH] hwspinlock: omap: drop of_match_ptr for ID table Krzysztof Kozlowski
@ 2023-03-13 1:25 ` Baolin Wang
0 siblings, 0 replies; 2+ messages in thread
From: Baolin Wang @ 2023-03-13 1:25 UTC (permalink / raw)
To: Krzysztof Kozlowski, Ohad Ben-Cohen, Bjorn Andersson, linux-omap,
linux-remoteproc, linux-kernel
On 3/11/2023 7:14 PM, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).
>
> drivers/hwspinlock/omap_hwspinlock.c:164:34: error: ‘omap_hwspinlock_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> drivers/hwspinlock/omap_hwspinlock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwspinlock/omap_hwspinlock.c b/drivers/hwspinlock/omap_hwspinlock.c
> index 1fb3a2550e29..dfe82952671b 100644
> --- a/drivers/hwspinlock/omap_hwspinlock.c
> +++ b/drivers/hwspinlock/omap_hwspinlock.c
> @@ -174,7 +174,7 @@ static struct platform_driver omap_hwspinlock_driver = {
> .remove = omap_hwspinlock_remove,
> .driver = {
> .name = "omap_hwspinlock",
> - .of_match_table = of_match_ptr(omap_hwspinlock_of_match),
> + .of_match_table = omap_hwspinlock_of_match,
> },
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-13 1:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-11 11:14 [PATCH] hwspinlock: omap: drop of_match_ptr for ID table Krzysztof Kozlowski
2023-03-13 1:25 ` Baolin Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox