[PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed

[PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed

[Yoshihiro Shimoda]

After system resumed on some environment board, the promiscuous mode
is disabled because the SoC turned off. So, call ravb_set_rx_mode() in
the ravb_resume() to fix the issue.

Reported-by: Tho Vu <tho.vu.wh@renesas.com>
Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 drivers/net/ethernet/renesas/ravb_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 36324126db6d..6bc923326268 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -3020,6 +3020,7 @@ static int __maybe_unused ravb_resume(struct device *dev)
 		ret = ravb_open(ndev);
 		if (ret < 0)
 			return ret;
+		ravb_set_rx_mode(ndev);
 		netif_device_attach(ndev);
 	}
 
-- 
2.25.1

Re: [PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed

[Pavan Chebbi]

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

On Mon, Nov 28, 2022 at 12:27 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
>
> After system resumed on some environment board, the promiscuous mode
> is disabled because the SoC turned off. So, call ravb_set_rx_mode() in
> the ravb_resume() to fix the issue.
>
> Reported-by: Tho Vu <tho.vu.wh@renesas.com>
> Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>  drivers/net/ethernet/renesas/ravb_main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 36324126db6d..6bc923326268 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -3020,6 +3020,7 @@ static int __maybe_unused ravb_resume(struct device *dev)
>                 ret = ravb_open(ndev);
>                 if (ret < 0)
>                         return ret;
> +               ravb_set_rx_mode(ndev);
>                 netif_device_attach(ndev);
>         }
>
> --
> 2.25.1
>

Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

Re: [PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed

[Sergey Shtylyov]

Hello!

On 11/28/22 9:56 AM, Yoshihiro Shimoda wrote:

> After system resumed on some environment board, the promiscuous mode
> is disabled because the SoC turned off. So, call ravb_set_rx_mode() in
> the ravb_resume() to fix the issue.

   Hm, it seems sh_eth.c has the same issue...

> Reported-by: Tho Vu <tho.vu.wh@renesas.com>
> Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

[...]

MBR, Sergey

Re: [PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 28 Nov 2022 15:56:04 +0900 you wrote:
> After system resumed on some environment board, the promiscuous mode
> is disabled because the SoC turned off. So, call ravb_set_rx_mode() in
> the ravb_resume() to fix the issue.
> 
> Reported-by: Tho Vu <tho.vu.wh@renesas.com>
> Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> 
> [...]

Here is the summary with links:
  - [net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed
    https://git.kernel.org/netdev/net/c/d66233a312ec

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html