* [PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed
@ 2022-11-28 6:56 Yoshihiro Shimoda
2022-11-28 7:24 ` Pavan Chebbi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yoshihiro Shimoda @ 2022-11-28 6:56 UTC (permalink / raw)
To: s.shtylyov, davem, edumazet, kuba, pabeni
Cc: netdev, linux-renesas-soc, Yoshihiro Shimoda, Tho Vu
After system resumed on some environment board, the promiscuous mode
is disabled because the SoC turned off. So, call ravb_set_rx_mode() in
the ravb_resume() to fix the issue.
Reported-by: Tho Vu <tho.vu.wh@renesas.com>
Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
drivers/net/ethernet/renesas/ravb_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 36324126db6d..6bc923326268 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -3020,6 +3020,7 @@ static int __maybe_unused ravb_resume(struct device *dev)
ret = ravb_open(ndev);
if (ret < 0)
return ret;
+ ravb_set_rx_mode(ndev);
netif_device_attach(ndev);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed
2022-11-28 6:56 [PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed Yoshihiro Shimoda
@ 2022-11-28 7:24 ` Pavan Chebbi
2022-11-28 18:26 ` Sergey Shtylyov
2022-11-29 17:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Pavan Chebbi @ 2022-11-28 7:24 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: s.shtylyov, davem, edumazet, kuba, pabeni, netdev,
linux-renesas-soc, Tho Vu
[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]
On Mon, Nov 28, 2022 at 12:27 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
>
> After system resumed on some environment board, the promiscuous mode
> is disabled because the SoC turned off. So, call ravb_set_rx_mode() in
> the ravb_resume() to fix the issue.
>
> Reported-by: Tho Vu <tho.vu.wh@renesas.com>
> Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> drivers/net/ethernet/renesas/ravb_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 36324126db6d..6bc923326268 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -3020,6 +3020,7 @@ static int __maybe_unused ravb_resume(struct device *dev)
> ret = ravb_open(ndev);
> if (ret < 0)
> return ret;
> + ravb_set_rx_mode(ndev);
> netif_device_attach(ndev);
> }
>
> --
> 2.25.1
>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed
2022-11-28 6:56 [PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed Yoshihiro Shimoda
2022-11-28 7:24 ` Pavan Chebbi
@ 2022-11-28 18:26 ` Sergey Shtylyov
2022-11-29 17:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Sergey Shtylyov @ 2022-11-28 18:26 UTC (permalink / raw)
To: Yoshihiro Shimoda, davem, edumazet, kuba, pabeni
Cc: netdev, linux-renesas-soc, Tho Vu
Hello!
On 11/28/22 9:56 AM, Yoshihiro Shimoda wrote:
> After system resumed on some environment board, the promiscuous mode
> is disabled because the SoC turned off. So, call ravb_set_rx_mode() in
> the ravb_resume() to fix the issue.
Hm, it seems sh_eth.c has the same issue...
> Reported-by: Tho Vu <tho.vu.wh@renesas.com>
> Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed
2022-11-28 6:56 [PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed Yoshihiro Shimoda
2022-11-28 7:24 ` Pavan Chebbi
2022-11-28 18:26 ` Sergey Shtylyov
@ 2022-11-29 17:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-29 17:00 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: s.shtylyov, davem, edumazet, kuba, pabeni, netdev,
linux-renesas-soc, tho.vu.wh
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 28 Nov 2022 15:56:04 +0900 you wrote:
> After system resumed on some environment board, the promiscuous mode
> is disabled because the SoC turned off. So, call ravb_set_rx_mode() in
> the ravb_resume() to fix the issue.
>
> Reported-by: Tho Vu <tho.vu.wh@renesas.com>
> Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> [...]
Here is the summary with links:
- [net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed
https://git.kernel.org/netdev/net/c/d66233a312ec
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-29 17:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-28 6:56 [PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed Yoshihiro Shimoda
2022-11-28 7:24 ` Pavan Chebbi
2022-11-28 18:26 ` Sergey Shtylyov
2022-11-29 17:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox