From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Simon Horman <horms@verge.net.au>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
Chris Paterson <Chris.Paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: Re: [PATCH 1/8] arm64: dts: renesas: hihope-common: Move du clk properties out of common dtsi
Date: Tue, 1 Oct 2019 21:11:34 +0300 [thread overview]
Message-ID: <20191001181134.GC4735@pendragon.ideasonboard.com> (raw)
In-Reply-To: <1569932124-32010-2-git-send-email-biju.das@bp.renesas.com>
Hi Biju,
Thank you for the patch.
On Tue, Oct 01, 2019 at 01:15:17PM +0100, Biju Das wrote:
> RZ/G2N board is pin compatible with RZ/G2M board. However on the SoC
> side RZ/G2N uses DU3 where as RZ/G2M uses DU2 for the DPAD. In order to
> reuse the common dtsi for both the boards, it is required to move du clock
> properties from common dtsi to board specific dts.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
It would be nice if DT had a syntax that allowed extending an existing
property. It would allow us to write
&du {
clocks += <&versaclock5 1>,
<&x302_clk>,
<&versaclock5 2>;
clock-names += "dclkin.0", "dclkin.1", "dclkin.2";
};
in hihope-common.dtsi and be done with it.
Rob, do you think that's something worth adding ?
In any case, until we have that, this patch looks good to me.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/hihope-common.dtsi | 8 --------
> arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dts | 11 +++++++++++
> 2 files changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> index 3e376d2..355d0a2 100644
> --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> @@ -142,14 +142,6 @@
> };
>
> &du {
> - clocks = <&cpg CPG_MOD 724>,
> - <&cpg CPG_MOD 723>,
> - <&cpg CPG_MOD 722>,
> - <&versaclock5 1>,
> - <&x302_clk>,
> - <&versaclock5 2>;
> - clock-names = "du.0", "du.1", "du.2",
> - "dclkin.0", "dclkin.1", "dclkin.2";
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dts b/arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dts
> index 93ca973..96f2fb0 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dts
> @@ -24,3 +24,14 @@
> reg = <0x6 0x00000000 0x0 0x80000000>;
> };
> };
> +
> +&du {
> + clocks = <&cpg CPG_MOD 724>,
> + <&cpg CPG_MOD 723>,
> + <&cpg CPG_MOD 722>,
> + <&versaclock5 1>,
> + <&x302_clk>,
> + <&versaclock5 2>;
> + clock-names = "du.0", "du.1", "du.2",
> + "dclkin.0", "dclkin.1", "dclkin.2";
> +};
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-10-01 18:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 12:15 [PATCH 0/8] Add Display support Biju Das
2019-10-01 12:15 ` [PATCH 1/8] arm64: dts: renesas: hihope-common: Move du clk properties out of common dtsi Biju Das
2019-10-01 18:11 ` Laurent Pinchart [this message]
2019-10-01 18:17 ` Geert Uytterhoeven
2019-10-01 12:15 ` [PATCH 2/8] arm64: dts: renesas: r8a774b1: Add DU device to DT Biju Das
2019-10-01 18:13 ` Laurent Pinchart
2019-10-01 12:15 ` [PATCH 3/8] arm64: dts: renesas: r8a774b1: Add HDMI encoder instance Biju Das
2019-10-01 18:15 ` Laurent Pinchart
2019-10-01 12:15 ` [PATCH 4/8] arm64: dts: renesas: r8a774b1-hihope-rzg2n: Add display clock properties Biju Das
2019-10-01 18:15 ` Laurent Pinchart
2019-10-01 12:15 ` [PATCH 5/8] arm64: dts: renesas: r8a774b1: Add FDP1 device nodes Biju Das
2019-10-01 18:16 ` Laurent Pinchart
2019-10-01 12:15 ` [PATCH 6/8] arm64: dts: renesas: r8a774b1: Add PWM " Biju Das
2019-10-01 18:17 ` Laurent Pinchart
2019-10-01 12:15 ` [PATCH 7/8] arm64: dts: renesas: hihope-rzg2-ex: Enable backlight Biju Das
2019-10-01 18:18 ` Laurent Pinchart
2019-10-01 12:15 ` [PATCH 8/8] arm64: dts: renesas: hihope-rzg2-ex: Add LVDS panel support Biju Das
2019-10-01 18:25 ` Laurent Pinchart
2019-10-02 8:30 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001181134.GC4735@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox