From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Biju Das <biju.das.jz@bp.renesas.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Sergei Shtylyov <sergei.shtylyov@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Adam Ford <aford173@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Yuusuke Ashizuka <ashiduka@fujitsu.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
<netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
"Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 02/10] ravb: Rename "no_ptp_cfg_active" and "ptp_cfg_active" variables
Date: Fri, 1 Oct 2021 23:43:23 +0300 [thread overview]
Message-ID: <232c6ad6-c35b-76c0-2800-e05ca2631048@omp.ru> (raw)
In-Reply-To: <20211001150636.7500-3-biju.das.jz@bp.renesas.com>
On 10/1/21 6:06 PM, Biju Das wrote:
> Rename the variable "no_ptp_cfg_active" with "gptp" and
This shouldn't be a rename but the extension of the meaning instead...
> "ptp_cfg_active" with "ccc_gac" to match the HW features.
>
> There is no functional change.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Suggested-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> RFc->v1:
> * Renamed the variable "no_ptp_cfg_active" with "gptp" and
> "ptp_cfg_active" with "ccc_gac
> ---
> drivers/net/ethernet/renesas/ravb.h | 4 ++--
> drivers/net/ethernet/renesas/ravb_main.c | 26 ++++++++++++------------
> 2 files changed, 15 insertions(+), 15 deletions(-)
[...]
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 8f2358caef34..dc7654abfe55 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -1274,7 +1274,7 @@ static int ravb_set_ringparam(struct net_device *ndev,
> if (netif_running(ndev)) {
> netif_device_detach(ndev);
> /* Stop PTP Clock driver */
> - if (info->no_ptp_cfg_active)
> + if (info->gptp)
Where have you lost !info->ccc_gac?
> ravb_ptp_stop(ndev);
> /* Wait for DMA stopping */
> error = ravb_stop_dma(ndev);
> @@ -1306,7 +1306,7 @@ static int ravb_set_ringparam(struct net_device *ndev,
> ravb_emac_init(ndev);
>
> /* Initialise PTP Clock driver */
> - if (info->no_ptp_cfg_active)
> + if (info->gptp)
> ravb_ptp_init(ndev, priv->pdev);
The same question here...
> netif_device_attach(ndev);
> @@ -1446,7 +1446,7 @@ static int ravb_open(struct net_device *ndev)
> ravb_emac_init(ndev);
>
> /* Initialise PTP Clock driver */
> - if (info->no_ptp_cfg_active)
> + if (info->gptp)
... and here.
> ravb_ptp_init(ndev, priv->pdev);
>
> netif_tx_start_all_queues(ndev);
> @@ -1460,7 +1460,7 @@ static int ravb_open(struct net_device *ndev)
>
> out_ptp_stop:
> /* Stop PTP Clock driver */
> - if (info->no_ptp_cfg_active)
> + if (info->gptp)
> ravb_ptp_stop(ndev);
... and here.
> out_free_irq_nc_tx:
> if (!info->multi_irqs)
> @@ -1508,7 +1508,7 @@ static void ravb_tx_timeout_work(struct work_struct *work)
> netif_tx_stop_all_queues(ndev);
>
> /* Stop PTP Clock driver */
> - if (info->no_ptp_cfg_active)
> + if (info->gptp)
... and here.
> ravb_ptp_stop(ndev);
>
> /* Wait for DMA stopping */
> @@ -1543,7 +1543,7 @@ static void ravb_tx_timeout_work(struct work_struct *work)
>
> out:
> /* Initialise PTP Clock driver */
> - if (info->no_ptp_cfg_active)
> + if (info->gptp)
> ravb_ptp_init(ndev, priv->pdev);
... and here.
> netif_tx_start_all_queues(ndev);
> @@ -1752,7 +1752,7 @@ static int ravb_close(struct net_device *ndev)
> ravb_write(ndev, 0, TIC);
>
> /* Stop PTP Clock driver */
> - if (info->no_ptp_cfg_active)
> + if (info->gptp)
... and here.
> ravb_ptp_stop(ndev);
>
> /* Set the config mode to stop the AVB-DMAC's processes */
> @@ -2018,7 +2018,7 @@ static const struct ravb_hw_info ravb_gen3_hw_info = {
> .internal_delay = 1,
> .tx_counters = 1,
> .multi_irqs = 1,
> - .ptp_cfg_active = 1,
Where is 'gptp'?
> + .ccc_gac = 1,
> };
>
> static const struct ravb_hw_info ravb_gen2_hw_info = {
[...]
> @@ -2080,7 +2080,7 @@ static void ravb_set_config_mode(struct net_device *ndev)
> struct ravb_private *priv = netdev_priv(ndev);
> const struct ravb_hw_info *info = priv->info;
>
> - if (info->no_ptp_cfg_active) {
> + if (info->gptp) {
Where have you lost !info->ccc_gac?
> ravb_modify(ndev, CCC, CCC_OPC, CCC_OPC_CONFIG);
> /* Set CSEL value */
> ravb_modify(ndev, CCC, CCC_CSEL, CCC_CSEL_HPB);
[...]
MBR, Sergey
next prev parent reply other threads:[~2021-10-01 20:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 15:06 [PATCH 00/10] Add Gigabit Ethernet driver support Biju Das
2021-10-01 15:06 ` [PATCH 01/10] ravb: Rename "ravb_set_features_rx_csum" function to "ravb_set_features_rcar" Biju Das
2021-10-01 15:06 ` [PATCH 02/10] ravb: Rename "no_ptp_cfg_active" and "ptp_cfg_active" variables Biju Das
2021-10-01 20:43 ` Sergey Shtylyov [this message]
2021-10-02 7:53 ` Biju Das
2021-10-02 18:19 ` Sergey Shtylyov
2021-10-03 7:05 ` Biju Das
2021-10-01 15:06 ` [PATCH 03/10] ravb: Add nc_queue to struct ravb_hw_info Biju Das
2021-10-02 18:35 ` Sergey Shtylyov
2021-10-03 6:58 ` Biju Das
2021-10-06 19:45 ` Sergei Shtylyov
2021-10-06 20:12 ` Biju Das
2021-10-01 15:06 ` [PATCH 04/10] ravb: Add support for RZ/G2L SoC Biju Das
2021-10-02 19:43 ` Sergey Shtylyov
2021-10-03 6:51 ` Biju Das
2021-10-04 7:10 ` Geert Uytterhoeven
2021-10-04 7:49 ` Biju Das
2021-10-04 13:28 ` Biju Das
2021-10-01 15:06 ` [PATCH 05/10] ravb: Initialize GbEthernet DMAC Biju Das
2021-10-04 12:40 ` Sergey Shtylyov
2021-10-04 13:12 ` Biju Das
2021-10-04 15:50 ` Sergei Shtylyov
2021-10-04 18:42 ` Biju Das
2021-10-01 15:06 ` [PATCH 06/10] ravb: Exclude gPTP feature support for RZ/G2L Biju Das
2021-10-01 15:06 ` [PATCH 07/10] ravb: Add tsrq to struct ravb_hw_info Biju Das
2021-10-04 18:00 ` Sergey Shtylyov
2021-10-04 18:37 ` Sergei Shtylyov
2021-10-04 18:47 ` Biju Das
2021-10-04 18:54 ` Sergey Shtylyov
2021-10-04 19:28 ` Biju Das
2021-10-01 15:06 ` [PATCH 08/10] ravb: Add magic_pkt " Biju Das
2021-10-01 15:06 ` [PATCH 09/10] ravb: Add half_duplex " Biju Das
2021-10-01 15:06 ` [PATCH 10/10] ravb: Initialize GbEthernet E-MAC Biju Das
2021-10-04 18:55 ` Sergey Shtylyov
2021-10-04 19:23 ` Biju Das
2021-10-04 19:27 ` Sergey Shtylyov
2021-10-04 19:33 ` Biju Das
2021-10-02 13:00 ` [PATCH 00/10] Add Gigabit Ethernet driver support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=232c6ad6-c35b-76c0-2800-e05ca2631048@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=Chris.Paterson2@renesas.com \
--cc=aford173@gmail.com \
--cc=andrew@lunn.ch \
--cc=ashiduka@fujitsu.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sergei.shtylyov@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox