From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Sergey Shtylyov <s.shtylyov@omprussia.ru>,
Adam Ford <aford173@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Yuusuke Ashizuka <ashiduka@fujitsu.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 03/10] ravb: Add nc_queue to struct ravb_hw_info
Date: Wed, 6 Oct 2021 22:45:58 +0300 [thread overview]
Message-ID: <757eb986-d3cc-322a-64e8-3b23a3dd07d3@gmail.com> (raw)
In-Reply-To: <OS0PR01MB59222DB9D710A944235FD1D586AD9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On 10/3/21 9:58 AM, Biju Das wrote:
>>> R-Car supports network control queue whereas RZ/G2L does not support
>>> it. Add nc_queue to struct ravb_hw_info, so that NC queue is handled
>>> only by R-Car.
>>>
>>> This patch also renames ravb_rcar_dmac_init to ravb_dmac_init_rcar to
>>> be consistent with the naming convention used in sh_eth driver.
>>>
>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>>> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>
>> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>
>> One little nit below:
>>
>>> ---
>>> RFC->v1:
>>> * Handled NC queue only for R-Car.
>>> ---
>>> drivers/net/ethernet/renesas/ravb.h | 3 +-
>>> drivers/net/ethernet/renesas/ravb_main.c | 140
>>> +++++++++++++++--------
>>> 2 files changed, 94 insertions(+), 49 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/renesas/ravb.h
>>> b/drivers/net/ethernet/renesas/ravb.h
>>> index a33fbcb4aac3..c91e93e5590f 100644
>>> --- a/drivers/net/ethernet/renesas/ravb.h
>>> +++ b/drivers/net/ethernet/renesas/ravb.h
>>> @@ -986,7 +986,7 @@ struct ravb_hw_info {
>>> bool (*receive)(struct net_device *ndev, int *quota, int q);
>>> void (*set_rate)(struct net_device *ndev);
>>> int (*set_feature)(struct net_device *ndev, netdev_features_t
>> features);
>>> - void (*dmac_init)(struct net_device *ndev);
>>> + int (*dmac_init)(struct net_device *ndev);
>>> void (*emac_init)(struct net_device *ndev);
>>> const char (*gstrings_stats)[ETH_GSTRING_LEN];
>>> size_t gstrings_size;
>>> @@ -1002,6 +1002,7 @@ struct ravb_hw_info {
>>> unsigned multi_irqs:1; /* AVB-DMAC and E-MAC has multiple
>> irqs */
>>> unsigned gptp:1; /* AVB-DMAC has gPTP support */
>>> unsigned ccc_gac:1; /* AVB-DMAC has gPTP support active in
>> config mode */
>>> + unsigned nc_queue:1; /* AVB-DMAC has NC queue */
>>
>> Rather "queues" as there are RX and TX NC queues, no?
>
> It has NC queue on both RX and TX.
>
> If needed, I can send a follow up patch as RFC with the following changes.
>
> unsigned nc_queue:1; /* AVB-DMAC has NC queue on both RX and TX */
>
> or
>
> unsigned nc_queues:1; /* AVB-DMAC has RX and TX NC queues */
>
> please let me know.
Yes, please do it.
> Regards,
> Biju
MNR, Sergey
next prev parent reply other threads:[~2021-10-06 19:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 15:06 [PATCH 00/10] Add Gigabit Ethernet driver support Biju Das
2021-10-01 15:06 ` [PATCH 01/10] ravb: Rename "ravb_set_features_rx_csum" function to "ravb_set_features_rcar" Biju Das
2021-10-01 15:06 ` [PATCH 02/10] ravb: Rename "no_ptp_cfg_active" and "ptp_cfg_active" variables Biju Das
2021-10-01 20:43 ` Sergey Shtylyov
2021-10-02 7:53 ` Biju Das
2021-10-02 18:19 ` Sergey Shtylyov
2021-10-03 7:05 ` Biju Das
2021-10-01 15:06 ` [PATCH 03/10] ravb: Add nc_queue to struct ravb_hw_info Biju Das
2021-10-02 18:35 ` Sergey Shtylyov
2021-10-03 6:58 ` Biju Das
2021-10-06 19:45 ` Sergei Shtylyov [this message]
2021-10-06 20:12 ` Biju Das
2021-10-01 15:06 ` [PATCH 04/10] ravb: Add support for RZ/G2L SoC Biju Das
2021-10-02 19:43 ` Sergey Shtylyov
2021-10-03 6:51 ` Biju Das
2021-10-04 7:10 ` Geert Uytterhoeven
2021-10-04 7:49 ` Biju Das
2021-10-04 13:28 ` Biju Das
2021-10-01 15:06 ` [PATCH 05/10] ravb: Initialize GbEthernet DMAC Biju Das
2021-10-04 12:40 ` Sergey Shtylyov
2021-10-04 13:12 ` Biju Das
2021-10-04 15:50 ` Sergei Shtylyov
2021-10-04 18:42 ` Biju Das
2021-10-01 15:06 ` [PATCH 06/10] ravb: Exclude gPTP feature support for RZ/G2L Biju Das
2021-10-01 15:06 ` [PATCH 07/10] ravb: Add tsrq to struct ravb_hw_info Biju Das
2021-10-04 18:00 ` Sergey Shtylyov
2021-10-04 18:37 ` Sergei Shtylyov
2021-10-04 18:47 ` Biju Das
2021-10-04 18:54 ` Sergey Shtylyov
2021-10-04 19:28 ` Biju Das
2021-10-01 15:06 ` [PATCH 08/10] ravb: Add magic_pkt " Biju Das
2021-10-01 15:06 ` [PATCH 09/10] ravb: Add half_duplex " Biju Das
2021-10-01 15:06 ` [PATCH 10/10] ravb: Initialize GbEthernet E-MAC Biju Das
2021-10-04 18:55 ` Sergey Shtylyov
2021-10-04 19:23 ` Biju Das
2021-10-04 19:27 ` Sergey Shtylyov
2021-10-04 19:33 ` Biju Das
2021-10-02 13:00 ` [PATCH 00/10] Add Gigabit Ethernet driver support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=757eb986-d3cc-322a-64e8-3b23a3dd07d3@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=Chris.Paterson2@renesas.com \
--cc=aford173@gmail.com \
--cc=andrew@lunn.ch \
--cc=ashiduka@fujitsu.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=s.shtylyov@omp.ru \
--cc=s.shtylyov@omprussia.ru \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox