From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Biju Das <biju.das.jz@bp.renesas.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Sergei Shtylyov <sergei.shtylyov@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Sergey Shtylyov <s.shtylyov@omprussia.ru>,
"Adam Ford" <aford173@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Yuusuke Ashizuka <ashiduka@fujitsu.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 10/10] ravb: Initialize GbEthernet E-MAC
Date: Mon, 4 Oct 2021 22:27:55 +0300 [thread overview]
Message-ID: <fc3cce12-e16b-41b2-1aeb-7ddc22e03e91@omp.ru> (raw)
In-Reply-To: <OS0PR01MB5922AD9E0E01812FC4A11E1386AE9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On 10/4/21 10:23 PM, Biju Das wrote:
[...]
>>> Initialize GbEthernet E-MAC found on RZ/G2L SoC.
>>> This patch also renames ravb_set_rate to ravb_set_rate_rcar and
>>> ravb_rcar_emac_init to ravb_emac_init_rcar to be consistent with the
>>> naming convention used in sh_eth driver.
>>>
>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>>> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>> ---
>>> RFC->v1:
>>> * Moved CSR0 intialization to later patch.
>>> * started using ravb_modify for initializing link registers.
>>> ---
>>> drivers/net/ethernet/renesas/ravb.h | 20 +++++++--
>>> drivers/net/ethernet/renesas/ravb_main.c | 55
>>> ++++++++++++++++++++----
>>> 2 files changed, 62 insertions(+), 13 deletions(-)
>>>
[...]
>>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c
>>> b/drivers/net/ethernet/renesas/ravb_main.c
>>> index 3e694738e683..9a4888543384 100644
>>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>> [...]
>>> @@ -449,10 +461,35 @@ static int ravb_ring_init(struct net_device
>>> *ndev, int q)
>>>
>>> static void ravb_emac_init_gbeth(struct net_device *ndev) {
>>> - /* Place holder */
>>> + struct ravb_private *priv = netdev_priv(ndev);
>>> +
>>> + /* Receive frame limit set register */
>>> + ravb_write(ndev, GBETH_RX_BUFF_MAX + ETH_FCS_LEN, RFLR);
>>> +
>>> + /* PAUSE prohibition */
>>
>> Should be:
>>
>> /* EMAC Mode: PAUSE prohibition; Duplex; TX; RX */
>>
>>> + ravb_write(ndev, ECMR_ZPF | ((priv->duplex > 0) ? ECMR_DM : 0) |
>>> + ECMR_TE | ECMR_RE | ECMR_RCPT |
>>> + ECMR_TXF | ECMR_RXF | ECMR_PRM, ECMR);
>>> +
>>> + ravb_set_rate_gbeth(ndev);
>>> +
>>> + /* Set MAC address */
>>> + ravb_write(ndev,
>>> + (ndev->dev_addr[0] << 24) | (ndev->dev_addr[1] << 16) |
>>> + (ndev->dev_addr[2] << 8) | (ndev->dev_addr[3]), MAHR);
>>> + ravb_write(ndev, (ndev->dev_addr[4] << 8) | (ndev->dev_addr[5]),
>>> +MALR);
>>> +
>>> + /* E-MAC status register clear */
>>> + ravb_write(ndev, ECSR_ICD | ECSR_LCHNG | ECSR_PFRI, ECSR);
>>> +
>>> + /* E-MAC interrupt enable register */
>>> + ravb_write(ndev, ECSIPR_ICDIP, ECSIPR);
>>
>> Too much repetitive code, I think...
>
> Can you please clarify what are the codes repetitive here?
MAHR/MALR reading, mainly...
The following code turned out to be different from gen2/3 indeed...
[...]
MBR, Sergey
next prev parent reply other threads:[~2021-10-04 19:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 15:06 [PATCH 00/10] Add Gigabit Ethernet driver support Biju Das
2021-10-01 15:06 ` [PATCH 01/10] ravb: Rename "ravb_set_features_rx_csum" function to "ravb_set_features_rcar" Biju Das
2021-10-01 15:06 ` [PATCH 02/10] ravb: Rename "no_ptp_cfg_active" and "ptp_cfg_active" variables Biju Das
2021-10-01 20:43 ` Sergey Shtylyov
2021-10-02 7:53 ` Biju Das
2021-10-02 18:19 ` Sergey Shtylyov
2021-10-03 7:05 ` Biju Das
2021-10-01 15:06 ` [PATCH 03/10] ravb: Add nc_queue to struct ravb_hw_info Biju Das
2021-10-02 18:35 ` Sergey Shtylyov
2021-10-03 6:58 ` Biju Das
2021-10-06 19:45 ` Sergei Shtylyov
2021-10-06 20:12 ` Biju Das
2021-10-01 15:06 ` [PATCH 04/10] ravb: Add support for RZ/G2L SoC Biju Das
2021-10-02 19:43 ` Sergey Shtylyov
2021-10-03 6:51 ` Biju Das
2021-10-04 7:10 ` Geert Uytterhoeven
2021-10-04 7:49 ` Biju Das
2021-10-04 13:28 ` Biju Das
2021-10-01 15:06 ` [PATCH 05/10] ravb: Initialize GbEthernet DMAC Biju Das
2021-10-04 12:40 ` Sergey Shtylyov
2021-10-04 13:12 ` Biju Das
2021-10-04 15:50 ` Sergei Shtylyov
2021-10-04 18:42 ` Biju Das
2021-10-01 15:06 ` [PATCH 06/10] ravb: Exclude gPTP feature support for RZ/G2L Biju Das
2021-10-01 15:06 ` [PATCH 07/10] ravb: Add tsrq to struct ravb_hw_info Biju Das
2021-10-04 18:00 ` Sergey Shtylyov
2021-10-04 18:37 ` Sergei Shtylyov
2021-10-04 18:47 ` Biju Das
2021-10-04 18:54 ` Sergey Shtylyov
2021-10-04 19:28 ` Biju Das
2021-10-01 15:06 ` [PATCH 08/10] ravb: Add magic_pkt " Biju Das
2021-10-01 15:06 ` [PATCH 09/10] ravb: Add half_duplex " Biju Das
2021-10-01 15:06 ` [PATCH 10/10] ravb: Initialize GbEthernet E-MAC Biju Das
2021-10-04 18:55 ` Sergey Shtylyov
2021-10-04 19:23 ` Biju Das
2021-10-04 19:27 ` Sergey Shtylyov [this message]
2021-10-04 19:33 ` Biju Das
2021-10-02 13:00 ` [PATCH 00/10] Add Gigabit Ethernet driver support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc3cce12-e16b-41b2-1aeb-7ddc22e03e91@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=Chris.Paterson2@renesas.com \
--cc=aford173@gmail.com \
--cc=andrew@lunn.ch \
--cc=ashiduka@fujitsu.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=s.shtylyov@omprussia.ru \
--cc=sergei.shtylyov@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox