[PATCH LOCAL] arm64: renesas: defconfig: Restore graphical consoles

[PATCH LOCAL] arm64: renesas: defconfig: Restore graphical consoles

[Geert Uytterhoeven]

As of commit f611b1e7624ccdbd ("drm: Avoid circular dependencies for
CONFIG_FB"), CONFIG_FB is no longer auto-enabled.

Restore support for graphical consoles by enabling it explicitly in the
defconfig for Renesas R-Car Gen3 and RZ/G2 systems.

Fixes: f611b1e7624ccdbd ("drm: Avoid circular dependencies for CONFIG_FB")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Not intended for upstream merge.
To be queued in topic/renesas-defconfig, unless the rcar-du experts
consider CONFIG_FB to be no longer needed nor wanted on systems where
graphics are provided by a DRM driver.
---
 arch/arm64/configs/renesas_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/renesas_defconfig b/arch/arm64/configs/renesas_defconfig
index 27b55fcc3bbca4dc..2fc00cadc30eb26b 100644
--- a/arch/arm64/configs/renesas_defconfig
+++ b/arch/arm64/configs/renesas_defconfig
@@ -243,6 +243,7 @@ CONFIG_DRM_I2C_ADV7511_AUDIO=y
 CONFIG_DRM_DW_HDMI_AHB_AUDIO=y
 CONFIG_DRM_DW_HDMI_I2S_AUDIO=y
 CONFIG_DRM_DW_HDMI_CEC=y
+CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_BACKLIGHT_CLASS_DEVICE=y
 CONFIG_BACKLIGHT_PWM=y
-- 
2.25.1

Re: [PATCH LOCAL] arm64: renesas: defconfig: Restore graphical consoles

[Laurent Pinchart]

Hi Geert,

Thank you for the patch.

On Mon, Jul 12, 2021 at 12:19:33PM +0200, Geert Uytterhoeven wrote:
> As of commit f611b1e7624ccdbd ("drm: Avoid circular dependencies for
> CONFIG_FB"), CONFIG_FB is no longer auto-enabled.
> 
> Restore support for graphical consoles by enabling it explicitly in the
> defconfig for Renesas R-Car Gen3 and RZ/G2 systems.
> 
> Fixes: f611b1e7624ccdbd ("drm: Avoid circular dependencies for CONFIG_FB")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Not intended for upstream merge.

Why not ? We have no KMS console driver yet, FB is currently the only
option.

> To be queued in topic/renesas-defconfig, unless the rcar-du experts
> consider CONFIG_FB to be no longer needed nor wanted on systems where
> graphics are provided by a DRM driver.
> ---
>  arch/arm64/configs/renesas_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/renesas_defconfig b/arch/arm64/configs/renesas_defconfig
> index 27b55fcc3bbca4dc..2fc00cadc30eb26b 100644
> --- a/arch/arm64/configs/renesas_defconfig
> +++ b/arch/arm64/configs/renesas_defconfig
> @@ -243,6 +243,7 @@ CONFIG_DRM_I2C_ADV7511_AUDIO=y
>  CONFIG_DRM_DW_HDMI_AHB_AUDIO=y
>  CONFIG_DRM_DW_HDMI_I2S_AUDIO=y
>  CONFIG_DRM_DW_HDMI_CEC=y
> +CONFIG_FB=y
>  CONFIG_FB_MODE_HELPERS=y
>  CONFIG_BACKLIGHT_CLASS_DEVICE=y
>  CONFIG_BACKLIGHT_PWM=y

-- 
Regards,

Laurent Pinchart

Re: [PATCH LOCAL] arm64: renesas: defconfig: Restore graphical consoles

[Geert Uytterhoeven]

Hi Laurent,

On Mon, Jul 12, 2021 at 1:22 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Mon, Jul 12, 2021 at 12:19:33PM +0200, Geert Uytterhoeven wrote:
> > As of commit f611b1e7624ccdbd ("drm: Avoid circular dependencies for
> > CONFIG_FB"), CONFIG_FB is no longer auto-enabled.
> >
> > Restore support for graphical consoles by enabling it explicitly in the
> > defconfig for Renesas R-Car Gen3 and RZ/G2 systems.
> >
> > Fixes: f611b1e7624ccdbd ("drm: Avoid circular dependencies for CONFIG_FB")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Not intended for upstream merge.
>
> Why not ? We have no KMS console driver yet, FB is currently the only
> option.

Because there is no renesas-defconfig in upstream.

> > To be queued in topic/renesas-defconfig, unless the rcar-du experts
> > consider CONFIG_FB to be no longer needed nor wanted on systems where
> > graphics are provided by a DRM driver.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH LOCAL] arm64: renesas: defconfig: Restore graphical consoles

[Laurent Pinchart]

On Mon, Jul 12, 2021 at 01:36:19PM +0200, Geert Uytterhoeven wrote:
> On Mon, Jul 12, 2021 at 1:22 PM Laurent Pinchart wrote:
> > On Mon, Jul 12, 2021 at 12:19:33PM +0200, Geert Uytterhoeven wrote:
> > > As of commit f611b1e7624ccdbd ("drm: Avoid circular dependencies for
> > > CONFIG_FB"), CONFIG_FB is no longer auto-enabled.
> > >
> > > Restore support for graphical consoles by enabling it explicitly in the
> > > defconfig for Renesas R-Car Gen3 and RZ/G2 systems.
> > >
> > > Fixes: f611b1e7624ccdbd ("drm: Avoid circular dependencies for CONFIG_FB")
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > Not intended for upstream merge.
> >
> > Why not ? We have no KMS console driver yet, FB is currently the only
> > option.
> 
> Because there is no renesas-defconfig in upstream.

Obviously. I'll wake up first and then continue reviewing patches...

> > > To be queued in topic/renesas-defconfig, unless the rcar-du experts
> > > consider CONFIG_FB to be no longer needed nor wanted on systems where
> > > graphics are provided by a DRM driver.

-- 
Regards,

Laurent Pinchart