From: cp0613@linux.alibaba.com
To: krzk@kernel.org
Cc: alex@ghiti.fr, aou@eecs.berkeley.edu, cp0613@linux.alibaba.com,
guoren@kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, palmer@dabbelt.com,
paul.walmsley@sifive.com
Subject: Re: [RFC PATCH 1/4] dt-bindings: riscv: Add trace components description
Date: Mon, 15 Sep 2025 10:39:15 +0800 [thread overview]
Message-ID: <20250915023915.630-1-cp0613@linux.alibaba.com> (raw)
In-Reply-To: <a1749113-0b7e-43e7-a603-d1cf00c6a03f@kernel.org>
On Thu, 11 Sep 2025 19:24:39 +0200, krzk@kernel.org wrote:
> > This patch has added property definitions related to the riscv>
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94>
> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.>
> Please kindly resend and include all necessary To/Cc entries.
> </form letter>>
>
> > trace component, providing a foundation for subsequent driver
> > implementations.
Thank you very much for your review.
My next resend will include all necessary To/Cc entries.
>> + items:
>> + - const: riscv_trace,funnel-controller>
>You need to start following DTS coding style.>
>
>
>> + reg:
>> + description: A memory region containing registers for funnel controller
Indeed, the current dt-bindings are very primitive and may contain some
errors. I should improve and check them before sending them out. I will
pay attention to it next time.
Thank you,
Pei
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-09-15 2:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 12:44 [RFC PATCH 0/4] riscv: tarce: Implement riscv trace pmu driver and perf support cp0613
2025-09-11 12:44 ` [RFC PATCH 1/4] dt-bindings: riscv: Add trace components description cp0613
2025-09-11 17:24 ` Krzysztof Kozlowski
2025-09-15 2:39 ` cp0613 [this message]
2025-09-11 12:44 ` [RFC PATCH 2/4] riscv: event: Initial riscv trace driver support cp0613
2025-09-11 12:44 ` [RFC PATCH 3/4] tools: perf: Support perf record with aux buffer for riscv trace cp0613
2025-09-11 12:44 ` [RFC PATCH 4/4] riscv: trace: Support sink using dma buffer cp0613
2025-09-17 7:27 ` [RFC PATCH 0/4] riscv: tarce: Implement riscv trace pmu driver and perf support Bo Gan
2025-09-18 6:19 ` cp0613
2025-10-13 4:22 ` Anup Patel
2025-10-14 2:54 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915023915.630-1-cp0613@linux.alibaba.com \
--to=cp0613@linux.alibaba.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=guoren@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox