Re: [RFC PATCH 1/4] dt-bindings: riscv: Add trace components description

[Krzysztof Kozlowski <krzk@kernel.org>]

On 11/09/2025 14:44, cp0613@linux.alibaba.com wrote:
> From: Chen Pei <cp0613@linux.alibaba.com>
> 
> This patch has added property definitions related to the riscv

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>


> trace component, providing a foundation for subsequent driver
> implementations.
> 


...

> +$id: http://devicetree.org/schemas/riscv/trace/riscv,trace,funnel.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: RISC-V Trace Funnel Controller
> +
> +description: |
> +  riscv trace funnel controller description.
> +
> +maintainers:
> +  - Chen Pei <cp0613@linux.alibaba.com>
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: riscv_trace,funnel-controller

You need to start following DTS coding style.



> +  reg:
> +    description: A memory region containing registers for funnel controller
> +
> +  ports:
> +    description: Input/Output port definitions
> +
> +  level:
> +    description: Level of the funnel (e.g., 1 means close to the encoder)
> +
> +additionalProperties: true

No clue from where you got this, but that's not how DT bindings are
written. Maybe you used some AI tools for that - in that case, it would
be strong grumpy NAK. :( You just waste community time with such approach.

Please start from scratch from example-schema or known good bindings.

Best regards,
Krzysztof

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv