From: Conor Dooley <conor@kernel.org>
To: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
Cc: Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Djordje Todorovic <djordje.todorovic@htecgroup.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Chao-ying Fu <cfu@wavecomp.com>
Subject: Re: [PATCH] riscv: Update MIPS vendor id to 0x127.
Date: Mon, 3 Nov 2025 22:07:50 +0000 [thread overview]
Message-ID: <20251103-tabby-laurel-bc895f236a69@spud> (raw)
In-Reply-To: <20251103-mips-vendorid-v1-1-4fcb5f4d53fe@htecgroup.com>
[-- Attachment #1.1: Type: text/plain, Size: 1560 bytes --]
On Mon, Nov 03, 2025 at 04:05:48PM +0100, Aleksa Paunovic wrote:
> From: Chao-ying Fu <cfu@wavecomp.com>
>
> [1] defines MIPS vendor id as 0x127.
>
> [1] https://mips.com/wp-content/uploads/2025/06/P8700_Programmers_Reference_Manual_Rev1.84_5-31-2025.pdf
>
> Fixes: a8fed1bc03ace27902338e4f0d318335883ac847 ("riscv: Add xmipsexectl as a vendor extension")
Incorrect format for fixes tags!
> Signed-off-by: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
> ---
> arch/riscv/include/asm/vendorid_list.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/include/asm/vendorid_list.h b/arch/riscv/include/asm/vendorid_list.h
> index 3b09874d7a6dfb8f8aa45b0be41c20711d539e78..55205f7938055ba2b744dba5118bba935bcac008 100644
> --- a/arch/riscv/include/asm/vendorid_list.h
> +++ b/arch/riscv/include/asm/vendorid_list.h
> @@ -9,6 +9,6 @@
> #define MICROCHIP_VENDOR_ID 0x029
> #define SIFIVE_VENDOR_ID 0x489
> #define THEAD_VENDOR_ID 0x5b7
> -#define MIPS_VENDOR_ID 0x722
> +#define MIPS_VENDOR_ID 0x127
How was this ever wrong? Do devices exist with this old ID? Do we need
to support both as vendor IDs for MIPS?
Also, this was added in the wrong point in the list (it's meant to be
alphanumeric order IIRC). Sorting by the ID makes things annoying to
humans to read.
>
> #endif
>
> ---
> base-commit: dcb6fa37fd7bc9c3d2b066329b0d27dedf8becaa
> change-id: 20251031-mips-vendorid-df103aedf117
>
> Best regards,
> --
> Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-11-03 22:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 15:05 [PATCH] riscv: Update MIPS vendor id to 0x127 Aleksa Paunovic via B4 Relay
2025-11-03 22:07 ` Conor Dooley [this message]
2025-11-04 11:53 ` Aleksa Paunovic
2025-11-04 13:18 ` Conor Dooley
2025-11-04 14:06 ` Aleksa Paunovic
2025-11-04 14:09 ` Conor Dooley
2025-11-13 16:07 ` Aleksa Paunovic
2025-11-19 3:26 ` Paul Walmsley
2025-11-20 10:05 ` Aleksa Paunovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103-tabby-laurel-bc895f236a69@spud \
--to=conor@kernel.org \
--cc=aleksa.paunovic@htecgroup.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=cfu@wavecomp.com \
--cc=djordje.todorovic@htecgroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox