Re: [PATCH] riscv: Update MIPS vendor id to 0x127.

From: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
To: "conor@kernel.org" <conor@kernel.org>
Cc: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>,
	"alex@ghiti.fr" <alex@ghiti.fr>,
	"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
	"cfu@wavecomp.com" <cfu@wavecomp.com>,
	Djordje Todorovic <Djordje.Todorovic@htecgroup.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	"palmer@dabbelt.com" <palmer@dabbelt.com>,
	"pjw@kernel.org" <pjw@kernel.org>
Subject: Re: [PATCH] riscv: Update MIPS vendor id to 0x127.
Date: Tue, 4 Nov 2025 11:53:49 +0000	[thread overview]
Message-ID: <e0e4d521-cf50-4384-8461-e87b15044089@htecgroup.com> (raw)
In-Reply-To: <20251103-tabby-laurel-bc895f236a69@spud>

Hi Conor,

Thank you for your response!

On 11/3/25 23:07, Conor Dooley wrote:

> On Mon, Nov 03, 2025 at 04:05:48PM +0100, Aleksa Paunovic wrote:
>> From: Chao-ying Fu <cfu@wavecomp.com>
>>
>> [1] defines MIPS vendor id as 0x127.
>>
>> [1] https://mips.com/wp-content/uploads/2025/06/P8700_Programmers_Reference_Manual_Rev1.84_5-31-2025.pdf
>>
>> Fixes: a8fed1bc03ace27902338e4f0d318335883ac847 ("riscv: Add xmipsexectl as a vendor extension")
> Incorrect format for fixes tags!
Will fix that in v2.
>
>> Signed-off-by: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
>> ---
>>  arch/riscv/include/asm/vendorid_list.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/include/asm/vendorid_list.h b/arch/riscv/include/asm/vendorid_list.h
>> index 3b09874d7a6dfb8f8aa45b0be41c20711d539e78..55205f7938055ba2b744dba5118bba935bcac008 100644
>> --- a/arch/riscv/include/asm/vendorid_list.h
>> +++ b/arch/riscv/include/asm/vendorid_list.h
>> @@ -9,6 +9,6 @@
>>  #define MICROCHIP_VENDOR_ID	0x029
>>  #define SIFIVE_VENDOR_ID	0x489
>>  #define THEAD_VENDOR_ID		0x5b7
>> -#define MIPS_VENDOR_ID		0x722
>> +#define MIPS_VENDOR_ID		0x127
> How was this ever wrong? Do devices exist with this old ID? Do we need
> to support both as vendor IDs for MIPS?
I'm not sure how it first started, but since we worked on qemu as well, we never noticed any issues while testing. 
It shouldn't cause any problems in the future though.
> Also, this was added in the wrong point in the list (it's meant to be
> alphanumeric order IIRC). Sorting by the ID makes things annoying to
> humans to read.
Will fix that as well.

Best regards,

Aleksa

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv