From: Andreas Schwab <schwab@suse.de>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: linux-riscv@lists.infradead.org, alex@ghiti.fr,
Charlie Jenkins <charlie@rivosinc.com>,
Mr.Bossman075@gmail.com, Jesse Taube <jesse@rivosinc.com>
Subject: Re: [PATCH v2 1/2] RISC-V: hwprobe: Use BIT macro to avoid warnings
Date: Thu, 06 Feb 2025 09:58:33 +0100 [thread overview]
Message-ID: <mvmo6zf1mbq.fsf@suse.de> (raw)
In-Reply-To: <20250205204129.10639-2-palmer@rivosinc.com> (Palmer Dabbelt's message of "Wed, 5 Feb 2025 12:40:26 -0800")
On Feb 05 2025, Palmer Dabbelt wrote:
> From: Jesse Taube <jesse@rivosinc.com>
>
> In uapi/asm/hwprobe.h file, (1 << N) is used to define the bit field
> which causes checkpatch to warn. Use BIT(N) and BIT_ULL(N) to avoid
> these warnings.
_BITUL(N) and _BITULL(N)
> @@ -98,6 +99,6 @@ struct riscv_hwprobe {
> /* Increase RISCV_HWPROBE_MAX_KEY when adding items. */
>
> /* Flags */
> -#define RISCV_HWPROBE_WHICH_CPUS (1 << 0)
> +#define RISCV_HWPROBE_WHICH_CPUS BIT(0)
s/BIT/_BITUL/
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-02-06 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 20:40 [PATCH v2 0/2] RISC-V: Use BIT_ULL(x) instead of 1ULL << x Palmer Dabbelt
2025-02-05 20:40 ` [PATCH v2 1/2] RISC-V: hwprobe: Use BIT macro to avoid warnings Palmer Dabbelt
2025-02-06 8:58 ` Andreas Schwab [this message]
2025-02-05 20:40 ` [PATCH v2 2/2] RISC-V: Use BIT_ULL(x) instead of 1ULL << x Palmer Dabbelt
2025-02-06 6:15 ` Tomasz Jeznach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmo6zf1mbq.fsf@suse.de \
--to=schwab@suse.de \
--cc=Mr.Bossman075@gmail.com \
--cc=alex@ghiti.fr \
--cc=charlie@rivosinc.com \
--cc=jesse@rivosinc.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox