* [PATCH] arm64: dts: rockchip: enable rng on all rk356x [not found] <a> @ 2024-12-01 23:46 ` Peter Robinson 2024-12-02 3:55 ` Dragan Simic 0 siblings, 1 reply; 6+ messages in thread From: Peter Robinson @ 2024-12-01 23:46 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip Cc: Peter Robinson The rk356x rng is available on both the rk3566 and rk3568 parts, the IP is all self contained within the SoCs so it's enabled already by default on rk3568 so let's enable it in the base rk356x.dtsi so it's enabled consistently everywhere. Signed-off-by: Peter Robinson <pbrobinson@gmail.com> --- arch/arm64/boot/dts/rockchip/rk3568.dtsi | 4 ---- arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 1 - 2 files changed, 5 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi index ecaefe208e3e..9dc09db5034d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi @@ -397,10 +397,6 @@ power-domain@RK3568_PD_PIPE { }; }; -&rng { - status = "okay"; -}; - &usb_host0_xhci { phys = <&usb2phy0_otg>, <&combphy0 PHY_TYPE_USB3>; phy-names = "usb2-phy", "usb3-phy"; diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi index 62be06f3b863..2994cddb3464 100644 --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi @@ -1038,7 +1038,6 @@ rng: rng@fe388000 { clocks = <&cru CLK_TRNG_NS>, <&cru HCLK_TRNG_NS>; clock-names = "core", "ahb"; resets = <&cru SRST_TRNG_NS>; - status = "disabled"; }; i2s0_8ch: i2s@fe400000 { -- 2.47.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: enable rng on all rk356x 2024-12-01 23:46 ` [PATCH] arm64: dts: rockchip: enable rng on all rk356x Peter Robinson @ 2024-12-02 3:55 ` Dragan Simic 2024-12-02 10:40 ` Marcin Juszkiewicz 0 siblings, 1 reply; 6+ messages in thread From: Dragan Simic @ 2024-12-02 3:55 UTC (permalink / raw) To: Peter Robinson Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip Hello Peter, On 2024-12-02 00:46, Peter Robinson wrote: > The rk356x rng is available on both the rk3566 and rk3568 > parts, the IP is all self contained within the SoCs so > it's enabled already by default on rk3568 so let's enable > it in the base rk356x.dtsi so it's enabled consistently > everywhere. Please, go through the mailing list threads [1][2] that have led us to the current state. To sum it up, it isn't about what's supported in the two RK356x SoC variants, but about the RK3566's HWRNG being disabled because the testing showed that it produces unacceptably low quality of random data, for some yet unknown reason. [1] https://lore.kernel.org/linux-rockchip/cover.1720969799.git.daniel@makrotopia.org/T/#u [2] https://lore.kernel.org/linux-rockchip/cover.1722355365.git.daniel@makrotopia.org/T/#u > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > --- > arch/arm64/boot/dts/rockchip/rk3568.dtsi | 4 ---- > arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 1 - > 2 files changed, 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi > b/arch/arm64/boot/dts/rockchip/rk3568.dtsi > index ecaefe208e3e..9dc09db5034d 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi > @@ -397,10 +397,6 @@ power-domain@RK3568_PD_PIPE { > }; > }; > > -&rng { > - status = "okay"; > -}; > - > &usb_host0_xhci { > phys = <&usb2phy0_otg>, <&combphy0 PHY_TYPE_USB3>; > phy-names = "usb2-phy", "usb3-phy"; > diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi > b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi > index 62be06f3b863..2994cddb3464 100644 > --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi > @@ -1038,7 +1038,6 @@ rng: rng@fe388000 { > clocks = <&cru CLK_TRNG_NS>, <&cru HCLK_TRNG_NS>; > clock-names = "core", "ahb"; > resets = <&cru SRST_TRNG_NS>; > - status = "disabled"; > }; > > i2s0_8ch: i2s@fe400000 { _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: enable rng on all rk356x 2024-12-02 3:55 ` Dragan Simic @ 2024-12-02 10:40 ` Marcin Juszkiewicz 2024-12-02 12:01 ` Diederik de Haas 0 siblings, 1 reply; 6+ messages in thread From: Marcin Juszkiewicz @ 2024-12-02 10:40 UTC (permalink / raw) To: Dragan Simic, Peter Robinson Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip W dniu 2.12.2024 o 04:55, Dragan Simic pisze: > On 2024-12-02 00:46, Peter Robinson wrote: >> The rk356x rng is available on both the rk3566 and rk3568 >> parts, the IP is all self contained within the SoCs so >> it's enabled already by default on rk3568 so let's enable >> it in the base rk356x.dtsi so it's enabled consistently >> everywhere. > > Please, go through the mailing list threads [1][2] that have led us > to the current state. To sum it up, it isn't about what's supported > in the two RK356x SoC variants, but about the RK3566's HWRNG being > disabled because the testing showed that it produces unacceptably > low quality of random data, for some yet unknown reason. So maybe there should be a comment in rockchip/rk3568.dtsi so we would not get back to it again. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: enable rng on all rk356x 2024-12-02 10:40 ` Marcin Juszkiewicz @ 2024-12-02 12:01 ` Diederik de Haas 2024-12-02 14:50 ` Dragan Simic 0 siblings, 1 reply; 6+ messages in thread From: Diederik de Haas @ 2024-12-02 12:01 UTC (permalink / raw) To: Marcin Juszkiewicz, Dragan Simic, Peter Robinson Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip [-- Attachment #1.1: Type: text/plain, Size: 1180 bytes --] On Mon Dec 2, 2024 at 11:40 AM CET, Marcin Juszkiewicz wrote: > W dniu 2.12.2024 o 04:55, Dragan Simic pisze: > > On 2024-12-02 00:46, Peter Robinson wrote: > >> The rk356x rng is available on both the rk3566 and rk3568 > >> parts, the IP is all self contained within the SoCs so > >> it's enabled already by default on rk3568 so let's enable > >> it in the base rk356x.dtsi so it's enabled consistently > >> everywhere. > > > > Please, go through the mailing list threads [1][2] that have led us > > to the current state. To sum it up, it isn't about what's supported > > in the two RK356x SoC variants, but about the RK3566's HWRNG being > > disabled because the testing showed that it produces unacceptably > > low quality of random data, for some yet unknown reason. > > So maybe there should be a comment in rockchip/rk3568.dtsi so we would > not get back to it again. I suggested to put that in the (original) commit message: https://lore.kernel.org/linux-rockchip/6690040.iosknibmi9@bagend/ precisely because this was quite predictable to happen. So a +1 on a comment in the dtsi with a link to the discussion in the commit message. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 170 bytes --] _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: enable rng on all rk356x 2024-12-02 12:01 ` Diederik de Haas @ 2024-12-02 14:50 ` Dragan Simic 2024-12-02 15:32 ` Heiko Stübner 0 siblings, 1 reply; 6+ messages in thread From: Dragan Simic @ 2024-12-02 14:50 UTC (permalink / raw) To: Diederik de Haas Cc: Marcin Juszkiewicz, Peter Robinson, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip Hello Diederik and Marcin, On 2024-12-02 13:01, Diederik de Haas wrote: > On Mon Dec 2, 2024 at 11:40 AM CET, Marcin Juszkiewicz wrote: >> W dniu 2.12.2024 o 04:55, Dragan Simic pisze: >> > On 2024-12-02 00:46, Peter Robinson wrote: >> >> The rk356x rng is available on both the rk3566 and rk3568 >> >> parts, the IP is all self contained within the SoCs so >> >> it's enabled already by default on rk3568 so let's enable >> >> it in the base rk356x.dtsi so it's enabled consistently >> >> everywhere. >> > >> > Please, go through the mailing list threads [1][2] that have led us >> > to the current state. To sum it up, it isn't about what's >> supported >> > in the two RK356x SoC variants, but about the RK3566's HWRNG being >> > disabled because the testing showed that it produces unacceptably >> > low quality of random data, for some yet unknown reason. >> >> So maybe there should be a comment in rockchip/rk3568.dtsi so we would >> not get back to it again. > > I suggested to put that in the (original) commit message: > https://lore.kernel.org/linux-rockchip/6690040.iosknibmi9@bagend/ > precisely because this was quite predictable to happen. > > So a +1 on a comment in the dtsi with a link to the discussion in the > commit message. Totally agreed on adding a brief summary to the RK356x base SoC dtsi, so I went ahead and sent a patch that adds it. [1] I also expected that to be described in the base dtsi back when the HWRNG support was added, but it somehow went in without the description. [1] https://lore.kernel.org/linux-rockchip/6b272e2f8f916c04b05db50df621659a5a7f29ab.1733149874.git.dsimic@manjaro.org/ _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: enable rng on all rk356x 2024-12-02 14:50 ` Dragan Simic @ 2024-12-02 15:32 ` Heiko Stübner 0 siblings, 0 replies; 6+ messages in thread From: Heiko Stübner @ 2024-12-02 15:32 UTC (permalink / raw) To: Diederik de Haas, Dragan Simic Cc: Marcin Juszkiewicz, Peter Robinson, Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree, linux-arm-kernel, linux-rockchip Am Montag, 2. Dezember 2024, 15:50:07 CET schrieb Dragan Simic: > Hello Diederik and Marcin, > > On 2024-12-02 13:01, Diederik de Haas wrote: > > On Mon Dec 2, 2024 at 11:40 AM CET, Marcin Juszkiewicz wrote: > >> W dniu 2.12.2024 o 04:55, Dragan Simic pisze: > >> > On 2024-12-02 00:46, Peter Robinson wrote: > >> >> The rk356x rng is available on both the rk3566 and rk3568 > >> >> parts, the IP is all self contained within the SoCs so > >> >> it's enabled already by default on rk3568 so let's enable > >> >> it in the base rk356x.dtsi so it's enabled consistently > >> >> everywhere. > >> > > >> > Please, go through the mailing list threads [1][2] that have led us > >> > to the current state. To sum it up, it isn't about what's > >> supported > >> > in the two RK356x SoC variants, but about the RK3566's HWRNG being > >> > disabled because the testing showed that it produces unacceptably > >> > low quality of random data, for some yet unknown reason. > >> > >> So maybe there should be a comment in rockchip/rk3568.dtsi so we would > >> not get back to it again. > > > > I suggested to put that in the (original) commit message: > > https://lore.kernel.org/linux-rockchip/6690040.iosknibmi9@bagend/ > > precisely because this was quite predictable to happen. > > > > So a +1 on a comment in the dtsi with a link to the discussion in the > > commit message. > > Totally agreed on adding a brief summary to the RK356x base SoC dtsi, > so I went ahead and sent a patch that adds it. [1] I also expected > that to be described in the base dtsi back when the HWRNG support was > added, but it somehow went in without the description. thanks a lot for doing that, so I'll drop this patch here now from my inbox. Heiko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-12-02 15:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <a>
2024-12-01 23:46 ` [PATCH] arm64: dts: rockchip: enable rng on all rk356x Peter Robinson
2024-12-02 3:55 ` Dragan Simic
2024-12-02 10:40 ` Marcin Juszkiewicz
2024-12-02 12:01 ` Diederik de Haas
2024-12-02 14:50 ` Dragan Simic
2024-12-02 15:32 ` Heiko Stübner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox