public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: Damon Ding <damon.ding@rock-chips.com>
To: heiko@sntech.de
Cc: robh@kernel.org, conor+dt@kernel.org, algea.cao@rock-chips.com,
	rfoss@kernel.org, devicetree@vger.kernel.org,
	linux-phy@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	sebastian.reichel@collabora.com, dri-devel@lists.freedesktop.org,
	hjc@rock-chips.com, kever.yang@rock-chips.com,
	dmitry.baryshkov@linaro.org, vkoul@kernel.org,
	Damon Ding <damon.ding@rock-chips.com>,
	andy.yan@rock-chips.com, krzk+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de
Subject: [PATCH v6 03/14] drm/rockchip: analogix_dp: Expand device data to support multiple edp display
Date: Thu, 23 Jan 2025 18:07:36 +0800	[thread overview]
Message-ID: <20250123100747.1841357-4-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20250123100747.1841357-1-damon.ding@rock-chips.com>

There are two main modifications: one is expanding struct
rockchip_dp_chip_data to an array, and the other is adding
&rockchip_dp_chip_data.reg to separate different edp devices.

Signed-off-by: Damon Ding <damon.ding@rock-chips.com>

---

Changes in v6:
- Add the description of &rockchip_dp_chip_data.reg
- Use drm_...() uniformly rather than mixing drm_...() and dev_..()
---
 .../gpu/drm/rockchip/analogix_dp-rockchip.c   | 42 +++++++++++++++----
 1 file changed, 35 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index 648ea608cdf3..a63c2c867059 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -52,10 +52,12 @@ struct rockchip_grf_reg_field {
  * struct rockchip_dp_chip_data - splite the grf setting of kind of chips
  * @lcdc_sel: grf register field of lcdc_sel
  * @chip_type: specific chip type
+ * @reg: register base address
  */
 struct rockchip_dp_chip_data {
 	const struct rockchip_grf_reg_field lcdc_sel;
 	u32	chip_type;
+	u32	reg;
 };
 
 struct rockchip_dp_device {
@@ -397,6 +399,8 @@ static int rockchip_dp_probe(struct platform_device *pdev)
 	const struct rockchip_dp_chip_data *dp_data;
 	struct drm_panel *panel = NULL;
 	struct rockchip_dp_device *dp;
+	struct resource *res;
+	int i;
 	int ret;
 
 	dp_data = of_device_get_match_data(dev);
@@ -411,9 +415,25 @@ static int rockchip_dp_probe(struct platform_device *pdev)
 	if (!dp)
 		return -ENOMEM;
 
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+
+	i = 0;
+	while (dp_data[i].reg) {
+		if (dp_data[i].reg == res->start) {
+			dp->data = &dp_data[i];
+			break;
+		}
+
+		i++;
+	}
+
+	if (!dp->data) {
+		drm_err(dp, "no chip-data for %s node\n", dev->of_node->name);
+		return -ENODEV;
+	}
+
 	dp->dev = dev;
 	dp->adp = ERR_PTR(-ENODEV);
-	dp->data = dp_data;
 	dp->plat_data.panel = panel;
 	dp->plat_data.dev_type = dp->data->chip_type;
 	dp->plat_data.power_on = rockchip_dp_poweron;
@@ -465,14 +485,22 @@ static int rockchip_dp_resume(struct device *dev)
 static DEFINE_RUNTIME_DEV_PM_OPS(rockchip_dp_pm_ops, rockchip_dp_suspend,
 		rockchip_dp_resume, NULL);
 
-static const struct rockchip_dp_chip_data rk3399_edp = {
-	.lcdc_sel = GRF_REG_FIELD(0x6250, 5, 5),
-	.chip_type = RK3399_EDP,
+static const struct rockchip_dp_chip_data rk3399_edp[] = {
+	{
+		.lcdc_sel = GRF_REG_FIELD(0x6250, 5, 5),
+		.chip_type = RK3399_EDP,
+		.reg = 0xff970000,
+	},
+	{ /* sentinel */ }
 };
 
-static const struct rockchip_dp_chip_data rk3288_dp = {
-	.lcdc_sel = GRF_REG_FIELD(0x025c, 5, 5),
-	.chip_type = RK3288_DP,
+static const struct rockchip_dp_chip_data rk3288_dp[] = {
+	{
+		.lcdc_sel = GRF_REG_FIELD(0x025c, 5, 5),
+		.chip_type = RK3288_DP,
+		.reg = 0xff970000,
+	},
+	{ /* sentinel */ }
 };
 
 static const struct of_device_id rockchip_dp_dt_ids[] = {
-- 
2.34.1


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2025-01-23 10:14 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 10:07 [PATCH v6 00/14] Add eDP support for RK3588 Damon Ding
2025-01-23 10:07 ` [PATCH v6 01/14] drm/rockchip: analogix_dp: Replace DRM_...() functions with drm_...() Damon Ding
2025-01-23 12:25   ` Jani Nikula
2025-01-23 15:12     ` Jani Nikula
2025-01-23 10:07 ` [PATCH v6 02/14] drm/rockchip: analogix_dp: Use formalized struct definition for grf field Damon Ding
2025-01-23 10:07 ` Damon Ding [this message]
2025-01-23 10:07 ` [PATCH v6 04/14] drm/bridge: analogix_dp: Add support for phy configuration Damon Ding
2025-01-23 10:07 ` [PATCH v6 05/14] dt-bindings: display: rockchip: analogix-dp: Add support to get panel from the DP AUX bus Damon Ding
2025-01-23 10:07 ` [PATCH v6 06/14] drm/bridge: analogix_dp: support to get &analogix_dp_device.plat_data and &analogix_dp_device.aux Damon Ding
2025-01-23 11:19   ` Dmitry Baryshkov
2025-01-24  8:26     ` Damon Ding
2025-01-23 10:07 ` [PATCH v6 07/14] drm/bridge: analogix_dp: Add support to get panel from the DP AUX bus Damon Ding
2025-01-23 11:25   ` Dmitry Baryshkov
2025-01-24  3:13     ` Doug Anderson
2025-02-16  9:06       ` Damon Ding
2025-01-23 10:07 ` [PATCH v6 08/14] drm/rockchip: " Damon Ding
2025-01-23 11:26   ` Dmitry Baryshkov
2025-01-30 20:33   ` Heiko Stübner
2025-02-22 11:25     ` Damon Ding
2025-02-22 11:42       ` Damon Ding
2025-02-07 19:42   ` Lucas Stach
2025-02-22 11:57     ` Damon Ding
2025-01-23 10:07 ` [PATCH v6 09/14] dt-bindings: display: rockchip: analogix-dp: Add support for RK3588 Damon Ding
2025-01-23 11:22   ` Rob Herring (Arm)
2025-01-24 10:20     ` Damon Ding
2025-01-23 10:07 ` [PATCH v6 10/14] drm/bridge: analogix_dp: " Damon Ding
2025-01-23 10:07 ` [PATCH v6 11/14] drm/rockchip: " Damon Ding
2025-01-23 11:29   ` Dmitry Baryshkov
2025-01-23 10:07 ` [PATCH v6 12/14] drm/edp-panel: Add LG Display panel model LP079QX1-SP0V Damon Ding
2025-01-23 11:31   ` Dmitry Baryshkov
2025-01-24  0:30     ` Doug Anderson
2025-01-25  4:18       ` Damon Ding
2025-01-26  0:44         ` Doug Anderson
2025-01-25  2:59     ` Damon Ding
2025-01-23 10:07 ` [PATCH v6 13/14] arm64: dts: rockchip: Add eDP0 node for RK3588 Damon Ding
2025-01-23 10:07 ` [PATCH v6 14/14] arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board Damon Ding
2025-01-23 11:32   ` Dmitry Baryshkov
2025-01-25  3:25     ` Damon Ding
2025-02-13 14:54 ` [PATCH v6 00/14] Add eDP support for RK3588 Piotr Oniszczuk
2025-02-13 16:56   ` Diederik de Haas
2025-02-13 17:20     ` Piotr Oniszczuk
2025-02-13 17:33     ` Sebastian Reichel
2025-02-13 18:20       ` Diederik de Haas
2025-02-13 17:26   ` Sebastian Reichel
2025-02-14 12:00     ` Piotr Oniszczuk
2025-02-24  3:21       ` Damon Ding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250123100747.1841357-4-damon.ding@rock-chips.com \
    --to=damon.ding@rock-chips.com \
    --cc=algea.cao@rock-chips.com \
    --cc=andy.yan@rock-chips.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=krzk+dt@kernel.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox