public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
To: Damon Ding <damon.ding@rock-chips.com>
Cc: heiko@sntech.de, robh@kernel.org, conor+dt@kernel.org,
	algea.cao@rock-chips.com, rfoss@kernel.org,
	devicetree@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	sebastian.reichel@collabora.com, dri-devel@lists.freedesktop.org,
	hjc@rock-chips.com, kever.yang@rock-chips.com,
	dmitry.baryshkov@linaro.org, vkoul@kernel.org,
	andy.yan@rock-chips.com, krzk+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de
Subject: Re: [PATCH v6 00/14] Add eDP support for RK3588
Date: Thu, 13 Feb 2025 15:54:00 +0100	[thread overview]
Message-ID: <5044FFCB-B325-40D0-BA82-03AF64EAF029@gmail.com> (raw)
In-Reply-To: <20250123100747.1841357-1-damon.ding@rock-chips.com>



> Wiadomość napisana przez Damon Ding <damon.ding@rock-chips.com> w dniu 23 sty 2025, o godz. 11:07:
> 
> Picked from:
> https://patchwork.kernel.org/project/linux-rockchip/list/?series=923593
> 
> These patchs have been tested with a 1536x2048p60 eDP panel on
> RK3588S EVB1 board, and HDMI 1080P/4K display also has been verified
> on RK3588 EVB1 board. Furthermore, the eDP display has been rechecked
> on RK3399 sapphire excavator board.
> 
> Patch 1~4   are preparations for the RK3588 eDP support on both Analogix
>            side and Rockchip side.
> Patch 5~8  are to support to get panel from the DP AUX bus.
> Patch 9~11 are the RK3588 Analogix DP driver support.
> Patch 12    is to add the power sequencing delays for panel model
>            LP079QX1-SP0V.
> Patch 13    is the addition of RK3588 eDP0 node.
> Patch 14    is to enable the eDP0 display on RK3588S EVB1 board.
> 
> Damon Ding (14):
>  drm/rockchip: analogix_dp: Replace DRM_...() functions with drm_...()
>  drm/rockchip: analogix_dp: Use formalized struct definition for grf
>    field
>  drm/rockchip: analogix_dp: Expand device data to support multiple edp
>    display
>  drm/bridge: analogix_dp: Add support for phy configuration.
>  dt-bindings: display: rockchip: analogix-dp: Add support to get panel
>    from the DP AUX bus
>  drm/bridge: analogix_dp: support to get &analogix_dp_device.plat_data
>    and &analogix_dp_device.aux
>  drm/bridge: analogix_dp: Add support to get panel from the DP AUX bus
>  drm/rockchip: analogix_dp: Add support to get panel from the DP AUX
>    bus
>  dt-bindings: display: rockchip: analogix-dp: Add support for RK3588
>  drm/bridge: analogix_dp: Add support for RK3588
>  drm/rockchip: analogix_dp: Add support for RK3588
>  drm/edp-panel: Add LG Display panel model LP079QX1-SP0V
>  arm64: dts: rockchip: Add eDP0 node for RK3588
>  arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board
> 
> .../rockchip/rockchip,analogix-dp.yaml        |  25 +-
> arch/arm64/boot/dts/rockchip/rk3588-base.dtsi |  28 +++
> .../boot/dts/rockchip/rk3588s-evb1-v10.dts    |  54 ++++
> .../drm/bridge/analogix/analogix_dp_core.c    |  76 +++---
> .../drm/bridge/analogix/analogix_dp_core.h    |   1 +
> .../gpu/drm/bridge/analogix/analogix_dp_reg.c |  52 ++++
> drivers/gpu/drm/panel/panel-edp.c             |   8 +
> .../gpu/drm/rockchip/analogix_dp-rockchip.c   | 238 +++++++++++++-----
> include/drm/bridge/analogix_dp.h              |   8 +-
> 9 files changed, 401 insertions(+), 89 deletions(-)
> 
> -- 
> 2.34.1
> 

Damon,

I’m playing with hdmi0 port enablement on radxa rock5 itx board with 6.14 mainline.

rock5 itx has 2 hdmi ports: hdmi0 is wired to rk3588 typeC1/eDP1 eDP with ra620 eDP->HDMI converter and hdmi1 from hdmi/edp tx1
(see page3 & page29 at https://dl.radxa.com/rock5/5itx/v1110/radxa_rock_5itx_v1110_schematic.pdf)

I’m on 6.14-rc2 with applied: 
[1] Cristicc hdmi code (https://gitlab.collabora.com/cristicc/linux-next/-/commits/rk3588-hdmi-bridge)
[2] eDP support for RK3588 (https://patchwork.kernel.org/project/linux-rockchip/list/?series=927765)
[3] Add eDP mode support for Rockchip Samsung HDPTX PHY (https://patchwork.kernel.org/project/linux-rockchip/cover/20250205105157.580060-1-damon.ding@rock-chips.com/)

Is edp1 supported by yours [2] series?

If yes - may you pls hint me about required dts additions in https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts?h=v6.14-rc2 ?

(for reference: rock5 itx bsp dts goes like this: https://github.com/radxa/kernel/blob/linux-6.1-stan-rkr1/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts)

in [2] i see dts adds for EVB1 - but i’m not sure will simple extrapolation of evb1 edp0 dts additions to edp1 in rock5 be enough….

thx in advance!


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2025-02-13 14:56 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 10:07 [PATCH v6 00/14] Add eDP support for RK3588 Damon Ding
2025-01-23 10:07 ` [PATCH v6 01/14] drm/rockchip: analogix_dp: Replace DRM_...() functions with drm_...() Damon Ding
2025-01-23 12:25   ` Jani Nikula
2025-01-23 15:12     ` Jani Nikula
2025-01-23 10:07 ` [PATCH v6 02/14] drm/rockchip: analogix_dp: Use formalized struct definition for grf field Damon Ding
2025-01-23 10:07 ` [PATCH v6 03/14] drm/rockchip: analogix_dp: Expand device data to support multiple edp display Damon Ding
2025-01-23 10:07 ` [PATCH v6 04/14] drm/bridge: analogix_dp: Add support for phy configuration Damon Ding
2025-01-23 10:07 ` [PATCH v6 05/14] dt-bindings: display: rockchip: analogix-dp: Add support to get panel from the DP AUX bus Damon Ding
2025-01-23 10:07 ` [PATCH v6 06/14] drm/bridge: analogix_dp: support to get &analogix_dp_device.plat_data and &analogix_dp_device.aux Damon Ding
2025-01-23 11:19   ` Dmitry Baryshkov
2025-01-24  8:26     ` Damon Ding
2025-01-23 10:07 ` [PATCH v6 07/14] drm/bridge: analogix_dp: Add support to get panel from the DP AUX bus Damon Ding
2025-01-23 11:25   ` Dmitry Baryshkov
2025-01-24  3:13     ` Doug Anderson
2025-02-16  9:06       ` Damon Ding
2025-01-23 10:07 ` [PATCH v6 08/14] drm/rockchip: " Damon Ding
2025-01-23 11:26   ` Dmitry Baryshkov
2025-01-30 20:33   ` Heiko Stübner
2025-02-22 11:25     ` Damon Ding
2025-02-22 11:42       ` Damon Ding
2025-02-07 19:42   ` Lucas Stach
2025-02-22 11:57     ` Damon Ding
2025-01-23 10:07 ` [PATCH v6 09/14] dt-bindings: display: rockchip: analogix-dp: Add support for RK3588 Damon Ding
2025-01-23 11:22   ` Rob Herring (Arm)
2025-01-24 10:20     ` Damon Ding
2025-01-23 10:07 ` [PATCH v6 10/14] drm/bridge: analogix_dp: " Damon Ding
2025-01-23 10:07 ` [PATCH v6 11/14] drm/rockchip: " Damon Ding
2025-01-23 11:29   ` Dmitry Baryshkov
2025-01-23 10:07 ` [PATCH v6 12/14] drm/edp-panel: Add LG Display panel model LP079QX1-SP0V Damon Ding
2025-01-23 11:31   ` Dmitry Baryshkov
2025-01-24  0:30     ` Doug Anderson
2025-01-25  4:18       ` Damon Ding
2025-01-26  0:44         ` Doug Anderson
2025-01-25  2:59     ` Damon Ding
2025-01-23 10:07 ` [PATCH v6 13/14] arm64: dts: rockchip: Add eDP0 node for RK3588 Damon Ding
2025-01-23 10:07 ` [PATCH v6 14/14] arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board Damon Ding
2025-01-23 11:32   ` Dmitry Baryshkov
2025-01-25  3:25     ` Damon Ding
2025-02-13 14:54 ` Piotr Oniszczuk [this message]
2025-02-13 16:56   ` [PATCH v6 00/14] Add eDP support for RK3588 Diederik de Haas
2025-02-13 17:20     ` Piotr Oniszczuk
2025-02-13 17:33     ` Sebastian Reichel
2025-02-13 18:20       ` Diederik de Haas
2025-02-13 17:26   ` Sebastian Reichel
2025-02-14 12:00     ` Piotr Oniszczuk
2025-02-24  3:21       ` Damon Ding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5044FFCB-B325-40D0-BA82-03AF64EAF029@gmail.com \
    --to=piotr.oniszczuk@gmail.com \
    --cc=algea.cao@rock-chips.com \
    --cc=andy.yan@rock-chips.com \
    --cc=conor+dt@kernel.org \
    --cc=damon.ding@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=krzk+dt@kernel.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox