Re: [PATCH v6 00/14] Add eDP support for RK3588

From: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Damon Ding <damon.ding@rock-chips.com>,
	heiko@sntech.de, robh@kernel.org, conor+dt@kernel.org,
	algea.cao@rock-chips.com, rfoss@kernel.org,
	devicetree@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, hjc@rock-chips.com,
	kever.yang@rock-chips.com, dmitry.baryshkov@linaro.org,
	vkoul@kernel.org, andy.yan@rock-chips.com, krzk+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de
Subject: Re: [PATCH v6 00/14] Add eDP support for RK3588
Date: Fri, 14 Feb 2025 13:00:03 +0100	[thread overview]
Message-ID: <C81810F2-6E9B-4DCC-85D1-CCB63CBFBFEA@gmail.com> (raw)
In-Reply-To: <tg6eyew4qahuxqakmmejne7xx2rkouj6htp55acun4ajz2irz2@vlmvqv3zc5vc>

> Wiadomość napisana przez Sebastian Reichel <sebastian.reichel@collabora.com> w dniu 13 lut 2025, o godz. 18:26:
> 
> Hello Piotr,
> 
> 
> The RK3588 has two different DP controllers. The one handled in this
> series should get the eDP port running, which is routed to the
> "eDP Panel" in the block diagram on page 3 of the Rock 5 ITX schematics.
> So this series adds support for using "HDMI/eDP TX0" and "HDMI/eDP TX1"
> in DP mode.
> 
> The port routed to HDMI0 via RA620 is the other DP controller, which
> also exists twice: "TYPEC0/DP0" and "TYPEC1/DP1". This DP controller
> is not yet supported upstream and there is no pending patchset. As far
> as I know Rockchip plans to work on preparing upstream support for that
> soon.
> 

Oh - this is very valuable info and explains a lot.
Thx. 

> Note, that the two DisplayPort controllers are completely different.
> The HDMI/eDP controller is a design from Analogix and the TypeC/DP
> controller is a design from Synopsys.
> 
> P.S.: Heiko merged support for HDMI1 (RK3588 SoC level) recently. So you
> should be able to get that running by some DT additions to the Rock 5
> ITX board DT with the latest linux-next code :)
> 

And it works perfectly on all my 3588 bards (including audio and my cec addition)
But only on boards using both hdmi tx0 and tx1 to hdmi0/hdmi1 ports.

on rock5 itx:  

With both hdmi tx0 and tx1 enabled in dts it looks like kernel detects hdmi tx0 as connected and tries read edid. 
As nothing is connected to J11 (eDP con) - i’m getting i2c ddc timeouts 
[   54.188880] dwhdmiqp-rockchip fde80000.hdmi: i2c read timed out
[   54.292207] dwhdmiqp-rockchip fde80000.hdmi: i2c read timed out
[   54.395554] dwhdmiqp-rockchip fde80000.hdmi: i2c read timed out

disabling hdmi0 makes kernel talking to hdmi1 but with issues: 
[    0.540446] dwhdmiqp-rockchip fdea0000.hdmi: registered DesignWare HDMI QP I2C bus driver
[    0.541230] rockchip-drm display-subsystem: bound fdea0000.hdmi (ops dw_hdmi_qp_rockchip_ops)
[    0.542285] [drm] Initialized rockchip 1.0.0 for display-subsystem on minor 0
[    0.542933] rockchip-drm display-subsystem: [drm] Cannot find any crtc or sizes
[    0.543605] rockchip-drm display-subsystem: [drm] Cannot find any crtc or sizes

and here i’m a bit puzzled as on other 3588 boards (i.e. rock5b) - when i connected monitor to hdmi1 - all works perfectly
(kernel, OS and app nicely skipping hdmi0 and talking to actually connected hdmi1 port. all works) 

on rock5 itx this not works.

my observations so far are:
-on rock5 itx hdmi0 is falsely detected as connected - even when eDP connector (J11) has nothing connected
-on rock5 itx disabling hdmi0 in dts breaks hdmi1 
-on other 3588 (e.g. rock 5b) disabling hdmi0 in dts NOT breaks hdmi1  

strange….

> Greetings,
> 
> -- Sebastian
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip