* [PATCH v1] media: platform: synopsys: hdmirx: Fix compilation on 32bit arches
@ 2025-03-07 9:21 Dmitry Osipenko
2025-03-07 9:54 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Osipenko @ 2025-03-07 9:21 UTC (permalink / raw)
To: Shreeya Patel, Heiko Stuebner, Mauro Carvalho Chehab,
Hans Verkuil, jose.abreu, nelson.costa, shawn.wen,
nicolas.dufresne, Sebastian Reichel
Cc: kernel, linux-media, linux-kernel, linux-rockchip, Tim Surber
The pixelclock is specified as 64bit integer and for this driver it
won't be above 600MHz. Fix the 64bit division of the pixclock for 32bit
kernel builds.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202503070743.WnRxStlk-lkp@intel.com/
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
index 4d42da7255f3..7e342bbde967 100644
--- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
+++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
@@ -291,7 +291,7 @@ static void hdmirx_get_timings(struct snps_hdmirx_dev *hdmirx_dev,
hfp = htotal - hact - hs - hbp;
vfp = vtotal - vact - vs - vbp;
- fps = (bt->pixelclock + (htotal * vtotal) / 2) / (htotal * vtotal);
+ fps = ((u32)bt->pixelclock + (htotal * vtotal) / 2) / (htotal * vtotal);
bt->width = hact;
bt->height = vact;
bt->hfrontporch = hfp;
--
2.48.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] media: platform: synopsys: hdmirx: Fix compilation on 32bit arches
2025-03-07 9:21 [PATCH v1] media: platform: synopsys: hdmirx: Fix compilation on 32bit arches Dmitry Osipenko
@ 2025-03-07 9:54 ` Hans Verkuil
2025-03-07 9:58 ` Dmitry Osipenko
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2025-03-07 9:54 UTC (permalink / raw)
To: Dmitry Osipenko, Shreeya Patel, Heiko Stuebner,
Mauro Carvalho Chehab, jose.abreu, nelson.costa, shawn.wen,
nicolas.dufresne, Sebastian Reichel
Cc: kernel, linux-media, linux-kernel, linux-rockchip, Tim Surber
Hi Dmitry,
On 07/03/2025 10:21, Dmitry Osipenko wrote:
> The pixelclock is specified as 64bit integer and for this driver it
> won't be above 600MHz. Fix the 64bit division of the pixclock for 32bit
> kernel builds.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202503070743.WnRxStlk-lkp@intel.com/
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> ---
> drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> index 4d42da7255f3..7e342bbde967 100644
> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> @@ -291,7 +291,7 @@ static void hdmirx_get_timings(struct snps_hdmirx_dev *hdmirx_dev,
> hfp = htotal - hact - hs - hbp;
> vfp = vtotal - vact - vs - vbp;
>
> - fps = (bt->pixelclock + (htotal * vtotal) / 2) / (htotal * vtotal);
> + fps = ((u32)bt->pixelclock + (htotal * vtotal) / 2) / (htotal * vtotal);
I just merged:
https://patchwork.linuxtv.org/project/linux-media/patch/20250306-synopsys-hdmirx-fix-64-div-v1-1-dd5ff38bba5e@kernel.org/
So you can either leave that patch in, or provide a patch on top.
Regards,
Hans
> bt->width = hact;
> bt->height = vact;
> bt->hfrontporch = hfp;
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] media: platform: synopsys: hdmirx: Fix compilation on 32bit arches
2025-03-07 9:54 ` Hans Verkuil
@ 2025-03-07 9:58 ` Dmitry Osipenko
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Osipenko @ 2025-03-07 9:58 UTC (permalink / raw)
To: Hans Verkuil, Shreeya Patel, Heiko Stuebner,
Mauro Carvalho Chehab, jose.abreu, nelson.costa, shawn.wen,
nicolas.dufresne, Sebastian Reichel
Cc: kernel, linux-media, linux-kernel, linux-rockchip, Tim Surber
On 3/7/25 12:54, Hans Verkuil wrote:
> Hi Dmitry,
>
> On 07/03/2025 10:21, Dmitry Osipenko wrote:
>> The pixelclock is specified as 64bit integer and for this driver it
>> won't be above 600MHz. Fix the 64bit division of the pixclock for 32bit
>> kernel builds.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202503070743.WnRxStlk-lkp@intel.com/
>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> ---
>> drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>> index 4d42da7255f3..7e342bbde967 100644
>> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>> @@ -291,7 +291,7 @@ static void hdmirx_get_timings(struct snps_hdmirx_dev *hdmirx_dev,
>> hfp = htotal - hact - hs - hbp;
>> vfp = vtotal - vact - vs - vbp;
>>
>> - fps = (bt->pixelclock + (htotal * vtotal) / 2) / (htotal * vtotal);
>> + fps = ((u32)bt->pixelclock + (htotal * vtotal) / 2) / (htotal * vtotal);
>
> I just merged:
>
> https://patchwork.linuxtv.org/project/linux-media/patch/20250306-synopsys-hdmirx-fix-64-div-v1-1-dd5ff38bba5e@kernel.org/
>
> So you can either leave that patch in, or provide a patch on top.
Missed that patch you merged. No need to do anything then, thanks!
--
Best regards,
Dmitry
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-07 9:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-07 9:21 [PATCH v1] media: platform: synopsys: hdmirx: Fix compilation on 32bit arches Dmitry Osipenko
2025-03-07 9:54 ` Hans Verkuil
2025-03-07 9:58 ` Dmitry Osipenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox