* [PATCH 1/2] dt-bindings: mfd: rockchip: drop redundant wakeup-source definitions
@ 2026-04-23 4:28 phucduc.bui
2026-04-23 4:28 ` [PATCH 2/2] ASoC: dt-bindings: " phucduc.bui
2026-04-23 9:18 ` [PATCH 1/2] dt-bindings: mfd: rockchip: " Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: phucduc.bui @ 2026-04-23 4:28 UTC (permalink / raw)
To: Lee Jones, Mark Brown, Liam Girdwood, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
Cc: Joseph Chen, Chris Zhong, Zhang Qing, David Rau, Animesh Agarwal,
devicetree, linux-sound, linux-rockchip, linux-arm-kernel,
linux-kernel, bui duc phuc
From: bui duc phuc <phucduc.bui@gmail.com>
The 'wakeup-source' property already has its type defined in the core
schema. The Rockchip MFD bindings redundantly specify 'type: boolean'
and provide descriptions which only repeat the generic meaning of the
property. Drop these redundant definitions and descriptions to clean
up the binding files and rely on the core schema instead.
No functional change intended.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml | 5 +----
Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml | 5 +----
Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml | 5 +----
Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 5 +----
Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml | 5 +----
5 files changed, 5 insertions(+), 20 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml
index 7c71447200ba..8e394ab6879b 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml
@@ -29,10 +29,7 @@ properties:
description:
Telling whether or not this PMIC is controlling the system power.
- wakeup-source:
- type: boolean
- description:
- Device can be used as a wakeup source.
+ wakeup-source: true
vcc1-supply:
description:
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
index da2391530c16..548ba1f30712 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
@@ -48,10 +48,7 @@ properties:
system-power-controller: true
- wakeup-source:
- type: boolean
- description:
- Device can be used as a wakeup source.
+ wakeup-source: true
vcc1-supply:
description:
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml
index 50dfffac8fbf..40f8f23afad3 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml
@@ -43,10 +43,7 @@ properties:
system-power-controller: true
- wakeup-source:
- type: boolean
- description:
- Device can be used as a wakeup source.
+ wakeup-source: true
vcc1-supply:
description:
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
index 2cb6d176a84c..b99aaff100fb 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
@@ -55,10 +55,7 @@ properties:
system-power-controller: true
- wakeup-source:
- type: boolean
- description:
- Device can be used as a wakeup source.
+ wakeup-source: true
vcc1-supply:
description:
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml
index 90d944c27ba1..b7af774b1395 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml
@@ -43,10 +43,7 @@ properties:
system-power-controller: true
- wakeup-source:
- type: boolean
- description:
- Device can be used as a wakeup source.
+ wakeup-source: true
vcc1-supply:
description:
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ASoC: dt-bindings: drop redundant wakeup-source definitions
2026-04-23 4:28 [PATCH 1/2] dt-bindings: mfd: rockchip: drop redundant wakeup-source definitions phucduc.bui
@ 2026-04-23 4:28 ` phucduc.bui
2026-04-23 9:19 ` Krzysztof Kozlowski
2026-04-23 9:18 ` [PATCH 1/2] dt-bindings: mfd: rockchip: " Krzysztof Kozlowski
1 sibling, 1 reply; 4+ messages in thread
From: phucduc.bui @ 2026-04-23 4:28 UTC (permalink / raw)
To: Lee Jones, Mark Brown, Liam Girdwood, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
Cc: Joseph Chen, Chris Zhong, Zhang Qing, David Rau, Animesh Agarwal,
devicetree, linux-sound, linux-rockchip, linux-arm-kernel,
linux-kernel, bui duc phuc
From: bui duc phuc <phucduc.bui@gmail.com>
The 'wakeup-source' property already has its type defined in the core
schema. A number of sound binding files redundantly specify the
'type: boolean' and provide descriptions which only repeat the generic
meaning of the property.
Drop these redundant definitions and descriptions to clean up the binding
files and rely on the core schema instead.
No functional change intended.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
Documentation/devicetree/bindings/sound/dialog,da7219.yaml | 5 +----
Documentation/devicetree/bindings/sound/realtek,rt5514.yaml | 4 +---
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
index 19137abdba3e..fab37cd92e0d 100644
--- a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
+++ b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
@@ -45,10 +45,7 @@ properties:
- wakeup
- irq
- wakeup-source:
- type: boolean
- description:
- Flag to indicate this device can wake system (suspend/resume).
+ wakeup-source: true
"#clock-cells":
const: 1
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5514.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5514.yaml
index 7fbf7739c371..57e5c09c05c0 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5514.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5514.yaml
@@ -48,9 +48,7 @@ properties:
spi-max-frequency: true
- wakeup-source:
- type: boolean
- description: Flag to indicate this device can wake system (suspend/resume).
+ wakeup-source: true
required:
- compatible
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] ASoC: dt-bindings: drop redundant wakeup-source definitions
2026-04-23 4:28 ` [PATCH 2/2] ASoC: dt-bindings: " phucduc.bui
@ 2026-04-23 9:19 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-23 9:19 UTC (permalink / raw)
To: phucduc.bui
Cc: Lee Jones, Mark Brown, Liam Girdwood, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Joseph Chen,
Chris Zhong, Zhang Qing, David Rau, Animesh Agarwal, devicetree,
linux-sound, linux-rockchip, linux-arm-kernel, linux-kernel
On Thu, Apr 23, 2026 at 11:28:31AM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> The 'wakeup-source' property already has its type defined in the core
TYPES. It is plural.
> schema. A number of sound binding files redundantly specify the
> 'type: boolean' and provide descriptions which only repeat the generic
> meaning of the property.
> Drop these redundant definitions and descriptions to clean up the binding
> files and rely on the core schema instead.
> No functional change intended.
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
> Documentation/devicetree/bindings/sound/dialog,da7219.yaml | 5 +----
> Documentation/devicetree/bindings/sound/realtek,rt5514.yaml | 4 +---
> 2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> index 19137abdba3e..fab37cd92e0d 100644
> --- a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> +++ b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> @@ -45,10 +45,7 @@ properties:
> - wakeup
> - irq
>
> - wakeup-source:
> - type: boolean
> - description:
> - Flag to indicate this device can wake system (suspend/resume).
> + wakeup-source: true
That's wrong. Commit msg is making here false statements that it is
redundant. I checked (and you should too!) and driver does clearly
device_property_read_bool() thus the property CANNOT be the second type.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: rockchip: drop redundant wakeup-source definitions
2026-04-23 4:28 [PATCH 1/2] dt-bindings: mfd: rockchip: drop redundant wakeup-source definitions phucduc.bui
2026-04-23 4:28 ` [PATCH 2/2] ASoC: dt-bindings: " phucduc.bui
@ 2026-04-23 9:18 ` Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-23 9:18 UTC (permalink / raw)
To: phucduc.bui
Cc: Lee Jones, Mark Brown, Liam Girdwood, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Joseph Chen,
Chris Zhong, Zhang Qing, David Rau, Animesh Agarwal, devicetree,
linux-sound, linux-rockchip, linux-arm-kernel, linux-kernel
On Thu, Apr 23, 2026 at 11:28:30AM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> The 'wakeup-source' property already has its type defined in the core
> schema. The Rockchip MFD bindings redundantly specify 'type: boolean'
No, core schema has TWO types.
Defining it as type boolean is not redundant, because
of_property_read_bool() on non-bool is deprecated.
This must be explained somehow - are these device drivers expecting bool
or not?
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-23 9:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-23 4:28 [PATCH 1/2] dt-bindings: mfd: rockchip: drop redundant wakeup-source definitions phucduc.bui
2026-04-23 4:28 ` [PATCH 2/2] ASoC: dt-bindings: " phucduc.bui
2026-04-23 9:19 ` Krzysztof Kozlowski
2026-04-23 9:18 ` [PATCH 1/2] dt-bindings: mfd: rockchip: " Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox